All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ian Campbell <Ian.Campbell@citrix.com>
To: Xing Lin <linxingnku@gmail.com>, Jim Fehlig <jfehlig@suse.com>
Cc: xen-devel@lists.xen.org, "Roger Pau Monné" <roger.pau@citrix.com>
Subject: Re: dom0 kenrel crashes for openstack + libvirt + libxl
Date: Fri, 21 Nov 2014 09:28:46 +0000	[thread overview]
Message-ID: <1416562126.26869.8.camel@citrix.com> (raw)
In-Reply-To: <CA+J9cpam6taP+V9Eh7ifmC5S29uXgRaehLcuPW6NVC5-MsnTKA@mail.gmail.com>

On Thu, 2014-11-20 at 16:53 -0700, Xing Lin wrote:

> I git clone nova-juno from github and searched for 'pygrub'. Here is what i get. 
> 
> 
> .//etc/nova/rootwrap.d/compute.filters:104:# nova/virt/xenapi/vm_utils.py: 'pygrub', '-qn', dev_path
> .//etc/nova/rootwrap.d/compute.filters:105:pygrub: CommandFilter, pygrub, root
> .//nova/tests/unit/virt/xenapi/test_xenapi.py:667:        self.assertEqual(self.vm['PV_bootloader'], 'pygrub')
> .//nova/virt/xenapi/vm_utils.py:298:            rec['PV_bootloader'] = 'pygrub'
> 
> 
> It seems that nova does not specify absolute path for pygrub. 
> 
> 
> I checked libvirt source code and found the following definition.
> 
> 
> .//src/libxl/libxl_conf.h:52:# define LIBXL_BOOTLOADER_PATH BINDIR "/pygrub"

Thanks for investigating.

I think libvirt is wrong to specify an absolute path here, IMHO by
default it should just specify "pygrub" and let libxl figure out the
correct path. Jim, what do you think?

Ian.

  reply	other threads:[~2014-11-21  9:28 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-12 18:41 dom0 kenrel crashes for openstack + libvirt + libxl Xing Lin
2014-11-13  8:12 ` Ian Campbell
2014-11-13 11:15   ` Ian Campbell
2014-11-13 10:40 ` David Vrabel
2014-11-13 10:57 ` Roger Pau Monné
2014-11-13 11:22   ` Stefan Bader
2014-11-14  5:54   ` Xing Lin
2014-11-14  9:01     ` Ian Campbell
2014-11-15  4:10       ` Xing Lin
2014-11-17 12:35         ` Stefano Stabellini
2014-11-17 12:40           ` Ian Campbell
2014-11-17 12:39         ` Ian Campbell
2014-11-17 14:44           ` Stefan Bader
2014-11-17 14:49             ` Ian Campbell
2014-11-17 15:10             ` Stefano Stabellini
2014-11-19 18:57           ` Xing Lin
2014-11-20  9:30             ` Ian Campbell
2014-11-20 23:53               ` Xing Lin
2014-11-21  9:28                 ` Ian Campbell [this message]
2014-11-21 14:05                   ` Ian Campbell
2014-11-21 14:18                     ` David Vrabel
2014-11-21 14:32                       ` Ian Campbell
2014-11-21 17:21                         ` Ian Campbell
2014-11-21 20:03                         ` Jim Fehlig
2014-11-21 16:59             ` Ian Campbell
2014-11-21 17:14               ` Stefan Bader

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1416562126.26869.8.camel@citrix.com \
    --to=ian.campbell@citrix.com \
    --cc=jfehlig@suse.com \
    --cc=linxingnku@gmail.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.