All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adam Williamson <awilliam@redhat.com>
To: git@vger.kernel.org
Subject: Re: 'simple' push check that branch name matches does not work if push.default is unset (and hence implicitly simple)
Date: Wed, 26 Nov 2014 14:38:20 -0800	[thread overview]
Message-ID: <1417041500.12457.79.camel@redhat.com> (raw)
In-Reply-To: <1417040968.12457.78.camel@redhat.com>

On Wed, 2014-11-26 at 14:29 -0800, Adam Williamson wrote:
> Hi, folks. Ran into an unfortunate issue with git which helped me mess
> up a Fedora package repo today :/
> 
> The problem can be reproduced thus:

Whoops, I missed step 0:

0. Ensure push.default is not configured globally

> 1. Create an empty repo, clone it
> 2. Push its master branch with something in it (just to get started)
> 3. git branch --track moo origin/master
> 4. git checkout moo
> 5. echo moo >> moo && git commit -a -m "create moo"
> 6. git push
> ** BUG HAPPENS - CHANGES ARE PUSHED TO origin/master **
> 7. git config --local push.default simple
> 8. echo moo2 >> moo && git commit -a -m "update moo"
> 9. git push
> ** PUSH IS CORRECTLY REJECTED **
-- 
Adam Williamson
Fedora QA Community Monkey
IRC: adamw | Twitter: AdamW_Fedora | XMPP: adamw AT happyassassin . net
http://www.happyassassin.net

  reply	other threads:[~2014-11-26 22:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 22:29 'simple' push check that branch name matches does not work if push.default is unset (and hence implicitly simple) Adam Williamson
2014-11-26 22:38 ` Adam Williamson [this message]
2014-11-27  3:43 ` Jeff King
2014-11-27  4:24   ` Adam Williamson
2014-11-27 17:12   ` Adam Williamson
2014-11-28  4:55     ` Jeff King
2014-12-01  2:21       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417041500.12457.79.camel@redhat.com \
    --to=awilliam@redhat.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.