All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Adam Williamson <awilliam@redhat.com>,
	Ramkumar Ramachandra <artagnon@gmail.com>,
	git@vger.kernel.org
Subject: Re: 'simple' push check that branch name matches does not work if push.default is unset (and hence implicitly simple)
Date: Sun, 30 Nov 2014 18:21:20 -0800	[thread overview]
Message-ID: <xmqqmw78rty7.fsf@gitster.dls.corp.google.com> (raw)
In-Reply-To: <20141128045518.GB19456@peff.net> (Jeff King's message of "Thu, 27 Nov 2014 23:55:18 -0500")

Jeff King <peff@peff.net> writes:

> There is some other magic with "simple", too, around triangular
> workflows. Describing it in detail would probably be too verbose in this
> message, but we do refer to the description of push.default, which is
> probably enough.  Technically this new bit you are adding here is
> covered there, too. But since we can improve the description by adding
> such a small amount of text in this case, it seems like a reasonable
> tradeoff.
>
> I suppose we could also customize the message based on the triangular
> and non-triangular cases. I dunno.

Yeah, I vaguely recall suggesting to polish advice message further
to help users along a similar line, but probably that fell in the
cracks.

Thanks for a quick fix.

      reply	other threads:[~2014-12-01  2:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 22:29 'simple' push check that branch name matches does not work if push.default is unset (and hence implicitly simple) Adam Williamson
2014-11-26 22:38 ` Adam Williamson
2014-11-27  3:43 ` Jeff King
2014-11-27  4:24   ` Adam Williamson
2014-11-27 17:12   ` Adam Williamson
2014-11-28  4:55     ` Jeff King
2014-12-01  2:21       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqmw78rty7.fsf@gitster.dls.corp.google.com \
    --to=gitster@pobox.com \
    --cc=artagnon@gmail.com \
    --cc=awilliam@redhat.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.