From: tixy@linaro.org (Jon Medhurst (Tixy))
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v10 2/2] ARM: kprobes: enable OPTPROBES for ARM 32
Date: Fri, 28 Nov 2014 11:17:36 +0000 [thread overview]
Message-ID: <1417173456.1845.3.camel@linaro.org> (raw)
In-Reply-To: <20141128111327.GR3836@n2100.arm.linux.org.uk>
On Fri, 2014-11-28 at 11:13 +0000, Russell King - ARM Linux wrote:
> On Fri, Nov 28, 2014 at 10:08:28AM +0000, Jon Medhurst (Tixy) wrote:
> > On Fri, 2014-11-28 at 12:12 +0900, Masami Hiramatsu wrote:
> > > (2014/11/27 23:36), Jon Medhurst (Tixy) wrote:
> > [...]
> > > > I thought it good to see what sort of benefits this code achieves,
> > > > especially as it could grow quite complex over time, and the cost of
> > > > that versus the benefit should be considered.
> > >
> > > I don't think it's so complex. It's actually cleanly separated.
> > > However, ARM tree should have arch/arm/kernel/kprobe/ dir,
> > > since there are too many kprobe related files under arch/arm/kernel/ ...
> >
> > Yes, that does seem like a good idea. Or rather a 'probes' directory to
> > also include uprobes as that shares a lot of code with kprobes.
>
> If you want to do this, then please make it arch/arm/probes rather than
> making the directory tree deeper than it needs to be.
Yes, good point.
--
Tixy
WARNING: multiple messages have this Message-ID (diff)
From: "Jon Medhurst (Tixy)" <tixy@linaro.org>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>,
Wang Nan <wangnan0@huawei.com>,
will.deacon@arm.com, taras.kondratiuk@linaro.org,
ben.dooks@codethink.co.uk, cl@linux.com, rabin@rab.in,
davem@davemloft.net, lizefan@huawei.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: Re: [PATCH v10 2/2] ARM: kprobes: enable OPTPROBES for ARM 32
Date: Fri, 28 Nov 2014 11:17:36 +0000 [thread overview]
Message-ID: <1417173456.1845.3.camel@linaro.org> (raw)
In-Reply-To: <20141128111327.GR3836@n2100.arm.linux.org.uk>
On Fri, 2014-11-28 at 11:13 +0000, Russell King - ARM Linux wrote:
> On Fri, Nov 28, 2014 at 10:08:28AM +0000, Jon Medhurst (Tixy) wrote:
> > On Fri, 2014-11-28 at 12:12 +0900, Masami Hiramatsu wrote:
> > > (2014/11/27 23:36), Jon Medhurst (Tixy) wrote:
> > [...]
> > > > I thought it good to see what sort of benefits this code achieves,
> > > > especially as it could grow quite complex over time, and the cost of
> > > > that versus the benefit should be considered.
> > >
> > > I don't think it's so complex. It's actually cleanly separated.
> > > However, ARM tree should have arch/arm/kernel/kprobe/ dir,
> > > since there are too many kprobe related files under arch/arm/kernel/ ...
> >
> > Yes, that does seem like a good idea. Or rather a 'probes' directory to
> > also include uprobes as that shares a lot of code with kprobes.
>
> If you want to do this, then please make it arch/arm/probes rather than
> making the directory tree deeper than it needs to be.
Yes, good point.
--
Tixy
next prev parent reply other threads:[~2014-11-28 11:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-21 6:35 [PATCH v10 0/2] ARM: kprobes: enable OPTPROBES for ARM32 Wang Nan
2014-11-21 6:35 ` Wang Nan
2014-11-21 6:35 ` [PATCH v10 1/2] kprobes: Pass the original kprobe for preparing optimized kprobe Wang Nan
2014-11-21 6:35 ` Wang Nan
2014-11-21 6:35 ` [PATCH v10 2/2] ARM: kprobes: enable OPTPROBES for ARM 32 Wang Nan
2014-11-21 6:35 ` Wang Nan
2014-11-27 14:36 ` Jon Medhurst (Tixy)
2014-11-27 14:36 ` Jon Medhurst (Tixy)
2014-11-28 3:12 ` Masami Hiramatsu
2014-11-28 3:12 ` Masami Hiramatsu
2014-11-28 10:08 ` Jon Medhurst (Tixy)
2014-11-28 10:08 ` Jon Medhurst (Tixy)
2014-11-28 10:43 ` Masami Hiramatsu
2014-11-28 10:43 ` Re: " Masami Hiramatsu
2014-11-28 11:13 ` Russell King - ARM Linux
2014-11-28 11:13 ` Russell King - ARM Linux
2014-11-28 11:17 ` Jon Medhurst (Tixy) [this message]
2014-11-28 11:17 ` Jon Medhurst (Tixy)
2014-11-29 1:28 ` Wang Nan
2014-11-29 1:28 ` Wang Nan
2014-12-01 1:29 ` Wang Nan
2014-12-01 1:29 ` Wang Nan
2014-12-01 8:59 ` Wang Nan
2014-12-01 8:59 ` Wang Nan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417173456.1845.3.camel@linaro.org \
--to=tixy@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.