Re: [PATCH for-4.5 0/3] Coverity fixes for python lowlevel libraries

[Ian Campbell <Ian.Campbell@citrix.com>]

On Thu, 2014-11-27 at 12:34 +0000, Andrew Cooper wrote:

> While Xend is certainly dead and gone, XenServer at the very least still has
> consumers of these python libraries.

AIUI XS mainly uses the xs.c stuff, with the xc.c stuff being mainly
debug utilities.

This is important because while the xs.c is simple and obviously correct
the xc.c patches are a little more involved.

> 
> Konrad: I am requesting a release ack for this.  All 5 issues are bugs with
> the handling of error cases, rather than with the basic functionality
> provided.  With these changes, Coverity is of the opinion that the python
> libraries are perfect (0 issues), and I feel this is a worthy position to be
> in for 4.5
> 
> Andrew Cooper (3):
>   python/xc: Fix multiple issues in pyflask_context_to_sid()
>   python/xc: Fix multiple issues in pyxc_readconsolering()
>   python/xs: Correct the indirection of the NULL xshandle() check
> 
>  tools/python/xen/lowlevel/xc/xc.c |   34 +++++++++-------------------------
>  tools/python/xen/lowlevel/xs/xs.c |    2 +-
>  2 files changed, 10 insertions(+), 26 deletions(-)
>