From: Ian Campbell <Ian.Campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen Coverity Team <coverity@xen.org>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for-4.5 2/3] python/xc: Fix multiple issues in pyxc_readconsolering()
Date: Tue, 2 Dec 2014 13:50:37 +0000 [thread overview]
Message-ID: <1417528237.24320.34.camel@citrix.com> (raw)
In-Reply-To: <20141201211456.GH22021@laptop.dumpdata.com>
On Mon, 2014-12-01 at 16:14 -0500, Konrad Rzeszutek Wilk wrote:
> On Fri, Nov 28, 2014 at 11:38:52AM +0000, Ian Campbell wrote:
> > On Thu, 2014-11-27 at 12:34 +0000, Andrew Cooper wrote:
> > > Don't leak a 16k allocation if PyArg_ParseTupleAndKeywords() or the first
> > > xc_readconsolering() fail. It is trivial to run throught the processes memory
> > > by repeatedly passing junk parameters to this function.
> > >
> > > In the case that the call to xc_readconsolering() in the while loop fails,
> > > reinstate str before breaking out, and passing a spurious pointer to free().
> > >
> > > Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> > > Coverity-IDs: 1054984 1055906
> > > CC: Ian Campbell <Ian.Campbell@citrix.com>
> > > CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> > > CC: Wei Liu <wei.liu2@citrix.com>
> > > CC: Xen Coverity Team <coverity@xen.org>
> >
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
>
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Did you intend to also ack patch #1? (or have I missed a mail?)
next prev parent reply other threads:[~2014-12-02 13:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-27 12:34 [PATCH for-4.5 0/3] Coverity fixes for python lowlevel libraries Andrew Cooper
2014-11-27 12:34 ` [PATCH for-4.5 1/3] python/xc: Fix multiple issues in pyflask_context_to_sid() Andrew Cooper
2014-11-28 11:37 ` Ian Campbell
2014-11-28 11:47 ` Andrew Cooper
2014-11-28 12:15 ` Ian Campbell
2014-12-09 14:27 ` Ian Campbell
2014-12-09 14:30 ` Andrew Cooper
2014-12-09 16:20 ` Konrad Rzeszutek Wilk
2014-12-09 16:43 ` [PATCH v2 " Andrew Cooper
2014-12-10 17:13 ` Konrad Rzeszutek Wilk
2014-12-16 17:16 ` Ian Campbell
2014-11-27 12:34 ` [PATCH for-4.5 2/3] python/xc: Fix multiple issues in pyxc_readconsolering() Andrew Cooper
2014-11-28 11:38 ` Ian Campbell
2014-12-01 21:14 ` Konrad Rzeszutek Wilk
2014-12-02 13:50 ` Ian Campbell [this message]
2014-12-02 18:47 ` Konrad Rzeszutek Wilk
2014-12-04 13:26 ` Ian Campbell
2014-11-27 12:34 ` [PATCH for-4.5 3/3] python/xs: Correct the indirection of the NULL xshandle() check Andrew Cooper
2014-11-28 11:32 ` Ian Campbell
2014-12-01 21:14 ` Konrad Rzeszutek Wilk
2014-11-28 12:07 ` [PATCH for-4.5 0/3] Coverity fixes for python lowlevel libraries Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417528237.24320.34.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=coverity@xen.org \
--cc=konrad.wilk@oracle.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.