From: Ian Campbell <Ian.Campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Dave Scott <Dave.Scott@citrix.com>, Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <Andrew.Cooper3@citrix.com>,
Zheng Li <dev@zheng.li>, Xen-devel <xen-devel@lists.xen.org>,
"Zheng Li (3P)" <zheng.li3@citrix.com>,
Ian Jackson <Ian.Jackson@citrix.com>
Subject: Re: [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling
Date: Fri, 28 Nov 2014 12:11:28 +0000 [thread overview]
Message-ID: <1417176688.23604.28.camel@citrix.com> (raw)
In-Reply-To: <20141126210940.GA15328@laptop.dumpdata.com>
On Wed, 2014-11-26 at 16:09 -0500, Konrad Rzeszutek Wilk wrote:
> On Wed, Nov 26, 2014 at 08:44:41PM +0000, Dave Scott wrote:
> >
> > > On 26 Nov 2014, at 18:41, Konrad Rzeszutek Wilk <konrad.wilk@oracle.com> wrote:
> > >
> > > On Wed, Nov 26, 2014 at 06:24:11PM +0000, Dave Scott wrote:
> > >>
> > >>> On 26 Nov 2014, at 15:38, Zheng Li <dev@zheng.li> wrote:
> > >>>
> > >>> On 26/11/2014 15:09, Andrew Cooper wrote:
> > >>>> This makes fields 0 and 1 true more often than they should be, resulting
> > >>>> problems when handling events.
> > >>>
> > >>> Indeed, looks like a mistake I made when rewriting the logic terms lately. The result is POLLUP or POLLERR events being returned in more categories than we'd interest. Thanks for fixing this!
> > >>>
> > >>> Acked-by: Zheng Li <dev@zheng.li>
> > >>
> > >> This also looks fine to me
> > >>
> > >> Acked-by: David Scott <dave.scott@citrix.com>
> > >
> > > Would it be possible to get an Reviewed-by please?
> >
> > I’ll certainly offer
> >
> > Reviewed-by: David Scott <dave.scott@citrix.com>
>
> OK, Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Applied, thanks.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
prev parent reply other threads:[~2014-11-28 12:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 15:09 [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling Andrew Cooper
2014-11-26 15:38 ` Zheng Li
2014-11-26 18:24 ` Dave Scott
2014-11-26 18:41 ` Konrad Rzeszutek Wilk
2014-11-26 19:03 ` Andrew Cooper
2014-11-26 20:08 ` Zheng Li
2014-11-27 8:55 ` Ian Campbell
2014-11-26 20:44 ` Dave Scott
2014-11-26 21:09 ` Konrad Rzeszutek Wilk
2014-11-28 12:11 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417176688.23604.28.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Andrew.Cooper3@citrix.com \
--cc=Dave.Scott@citrix.com \
--cc=Ian.Jackson@citrix.com \
--cc=dev@zheng.li \
--cc=konrad.wilk@oracle.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
--cc=zheng.li3@citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.