All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zheng Li <dev@zheng.li>
To: Andrew Cooper <andrew.cooper3@citrix.com>,
	Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
	Dave Scott <Dave.Scott@citrix.com>
Cc: Ian Jackson <Ian.Jackson@citrix.com>,
	Wei Liu <wei.liu2@citrix.com>,
	Ian Campbell <Ian.Campbell@citrix.com>,
	Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling
Date: Wed, 26 Nov 2014 20:08:06 +0000	[thread overview]
Message-ID: <54763326.7050705@zheng.li> (raw)
In-Reply-To: <547623EE.2070303@citrix.com>

On 26/11/2014 19:03, Andrew Cooper wrote:
> Strictly speaking Zheng, not being a maintainer, can't ack the patch,
> given what I believe to be Xens current rules for these things.
> However, as the author of the code and comment in this thread, his ack
> can reasonably be considered equivalent to a  Reviewed-by:  I guess this
> is just a matter of semantics.
>
> Furthermore, as we all share an office, I have already been through this
> process informally, and have confirmed the fix under my Xen-4.5 based
> XenServer branch.  There appear to be 100% less "error -EINVAL" messages
> in the logs.
>

Agreed. I was a bit confused by the "XXX-by" semantics. As Andy mentioned, he already went through the patch with me offline, so here is the line if more appropriate:

Reviewed-by: Zheng Li <dev@zheng.li>

Thanks,
Zheng

  reply	other threads:[~2014-11-26 20:08 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-26 15:09 [PATCH for-4.5] tools/oxenstored: Fix | vs & error in fd event handling Andrew Cooper
2014-11-26 15:38 ` Zheng Li
2014-11-26 18:24   ` Dave Scott
2014-11-26 18:41     ` Konrad Rzeszutek Wilk
2014-11-26 19:03       ` Andrew Cooper
2014-11-26 20:08         ` Zheng Li [this message]
2014-11-27  8:55         ` Ian Campbell
2014-11-26 20:44       ` Dave Scott
2014-11-26 21:09         ` Konrad Rzeszutek Wilk
2014-11-28 12:11           ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54763326.7050705@zheng.li \
    --to=dev@zheng.li \
    --cc=Dave.Scott@citrix.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=Ian.Jackson@citrix.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=konrad.wilk@oracle.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.