From: Ian Campbell <Ian.Campbell@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>, xen-devel@lists.xen.org
Subject: Re: [PATCH v2 for-4.5 0/2] xl/libxl: fix API and two memory leaks
Date: Mon, 1 Dec 2014 11:51:15 +0000 [thread overview]
Message-ID: <1417434675.29138.17.camel@citrix.com> (raw)
In-Reply-To: <20141201115044.GA19889@zion.uk.xensource.com>
On Mon, 2014-12-01 at 11:50 +0000, Wei Liu wrote:
> On Mon, Dec 01, 2014 at 11:40:09AM +0000, Ian Campbell wrote:
> > On Mon, 2014-12-01 at 11:31 +0000, Wei Liu wrote:
> > > Return value of libxl_basename was erroneously marked as "const". This
> > > series removes that "const" and fixes two memory leaks in xl.
> > >
> > > I think these fixes should be included in 4.5, given that they fix real
> > > issues and are very straight foward to reason about.
> >
> > Agreed. Both patches:
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > I've added the CCs to this intro mail...
> >
> > Did you by any chance look for other const char * return values?
> >
>
> I've looked at other public API headers. I didn't spot other obvious
> problems with regard to const char * return values.
Super, thanks!
next prev parent reply other threads:[~2014-12-01 11:51 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 11:31 [PATCH v2 for-4.5 0/2] xl/libxl: fix API and two memory leaks Wei Liu
2014-12-01 11:31 ` [PATCH v2 for-4.5 1/2] libxl: un-constify return value of libxl_basename Wei Liu
2014-12-02 18:44 ` Andrew Cooper
2014-12-03 9:51 ` Ian Campbell
2014-12-01 11:31 ` [PATCH v2 for-4.5 2/2] xl: fix two memory leaks Wei Liu
2014-12-02 14:19 ` Ian Campbell
2014-12-02 14:23 ` Wei Liu
2014-12-01 11:40 ` [PATCH v2 for-4.5 0/2] xl/libxl: fix API and " Ian Campbell
2014-12-01 11:50 ` Wei Liu
2014-12-01 11:51 ` Ian Campbell [this message]
2014-12-01 21:54 ` Konrad Rzeszutek Wilk
2014-12-02 15:35 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417434675.29138.17.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.