From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] scsi: set fmt to NULL scsi_extd_sense_format() by default
Date: Tue, 02 Dec 2014 14:50:48 +0000 [thread overview]
Message-ID: <1417531848.2424.0.camel@HansenPartnership.com> (raw)
In-Reply-To: <20141202110729.GA17562@mwanda>
On Tue, 2014-12-02 at 14:07 +0300, Dan Carpenter wrote:
> One of the two callers passes an unintialized pointer as "fmt" and
> expects it to be set to NULL if there is no format string. Let's make
> this function work as expected.
>
> Fixes: d811b848ebb7 ('scsi: use sdev as argument for sense code printing')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Change scsi_extd_sense_format() instead of the caller
Reviewed-by: James Bottomley <JBottomley@Parallels.com>
James
WARNING: multiple messages have this Message-ID (diff)
From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-scsi@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch v2] scsi: set fmt to NULL scsi_extd_sense_format() by default
Date: Tue, 02 Dec 2014 06:50:48 -0800 [thread overview]
Message-ID: <1417531848.2424.0.camel@HansenPartnership.com> (raw)
In-Reply-To: <20141202110729.GA17562@mwanda>
On Tue, 2014-12-02 at 14:07 +0300, Dan Carpenter wrote:
> One of the two callers passes an unintialized pointer as "fmt" and
> expects it to be set to NULL if there is no format string. Let's make
> this function work as expected.
>
> Fixes: d811b848ebb7 ('scsi: use sdev as argument for sense code printing')
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> ---
> v2: Change scsi_extd_sense_format() instead of the caller
Reviewed-by: James Bottomley <JBottomley@Parallels.com>
James
next prev parent reply other threads:[~2014-12-02 14:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-29 12:48 [patch] usb: storage: debug: uninitialized var in usb_stor_show_sense() Dan Carpenter
2014-11-29 12:48 ` Dan Carpenter
2014-11-29 16:07 ` James Bottomley
2014-11-29 16:07 ` James Bottomley
2014-12-01 10:42 ` Dan Carpenter
2014-12-01 10:42 ` Dan Carpenter
2014-12-02 11:07 ` [patch v2] scsi: set fmt to NULL scsi_extd_sense_format() by default Dan Carpenter
2014-12-02 11:07 ` Dan Carpenter
2014-12-02 14:50 ` James Bottomley [this message]
2014-12-02 14:50 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417531848.2424.0.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.