From: Ian Campbell <Ian.Campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Ian.Jackson@eu.citrix.com, Euan Harris <euan.harris@citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] libxl: Don't derefence null new_name pointer in libxl_domain_rename()
Date: Tue, 2 Dec 2014 15:35:33 +0000 [thread overview]
Message-ID: <1417534533.24320.59.camel@citrix.com> (raw)
In-Reply-To: <20141201220242.GI24289@laptop.dumpdata.com>
On Mon, 2014-12-01 at 17:02 -0500, Konrad Rzeszutek Wilk wrote:
> On Mon, Dec 01, 2014 at 02:50:56PM +0000, Ian Campbell wrote:
> > On Mon, 2014-12-01 at 14:27 +0000, Euan Harris wrote:
> > > libxl__domain_rename() unconditionally dereferences its new_name
> > > parameter, to check whether it is an empty string. Add a check to
> > > avoid a segfault if new_name is null.
> > >
> > > Signed-off-by: Euan Harris <euan.harris@citrix.com>
> >
> > Acked-by: Ian Campbell <ian.campbell@citrix.com>
> >
> > I think this is a good fix to have for 4.5, Konrad CCd.
>
> Release-Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Applied, fixing the typo in the subject as I went.
prev parent reply other threads:[~2014-12-02 15:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-01 14:27 [PATCH] libxl: Don't derefence null new_name pointer in libxl_domain_rename() Euan Harris
2014-12-01 14:50 ` Ian Campbell
2014-12-01 22:02 ` Konrad Rzeszutek Wilk
2014-12-02 15:35 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417534533.24320.59.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=euan.harris@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.