From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ed Swierk <eswierk@skyportsystems.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] libxl: Fix building libxlu_cfg_y.y with bison 3.0
Date: Wed, 3 Dec 2014 09:53:50 +0000 [thread overview]
Message-ID: <1417600430.11243.1.camel@citrix.com> (raw)
In-Reply-To: <CAO_EM_m72QsRdWcrYNg_VCcFKuexyZFZyF2waJyTvnn-OO8DxA@mail.gmail.com>
On Tue, 2014-12-02 at 09:49 -0800, Ed Swierk wrote:
> On Tue, Dec 2, 2014 at 6:00 AM, Andrew Cooper <andrew.cooper3@citrix.com> wrote:
> > The automatically generating doesn't actually work. Depending on the
> > relative timestamps caused by a SCM checkout, or a tarball extraction,
> > the files will be attempted to be regenerated.
> >
> > These files are regenerated in the XenServer build, simply because of
> > their order in the archived tarball.
>
> When I clone the xen tree from git, the timestamps match about 95% of
> the time, but the 5% failure rate was annoying enough that I finally
> dug in to fix the parser build.
>
> IMHO the generated files should be omitted from the source tree; as
> long as the source files are actually buildable, there's no reason not
> to treat them like any other source file.
There was a point in time where the prevailing version of bison (or
maybe flex) in stable distro releases had a bug which meant these files
could not be regenerated easily on common distros. I don't recall the
details well enough to know if that time has now passed. Perhaps Ian J
does.
Ian.
next prev parent reply other threads:[~2014-12-03 9:53 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 5:23 [PATCH] libxl: Fix building libxlu_cfg_y.y with bison 3.0 Ed Swierk
2014-12-01 9:42 ` Ian Campbell
2014-12-01 12:19 ` Wei Liu
2014-12-02 13:47 ` Ian Campbell
2014-12-02 14:00 ` Andrew Cooper
2014-12-02 17:49 ` Ed Swierk
2014-12-03 9:53 ` Ian Campbell [this message]
2014-12-03 10:01 ` Olaf Hering
2014-12-09 15:25 ` Ian Jackson
2014-12-10 16:41 ` Konrad Rzeszutek Wilk
2014-12-10 16:44 ` Ian Campbell
2014-12-10 17:02 ` Konrad Rzeszutek Wilk
2015-01-06 15:28 ` Ian Jackson
2014-12-02 18:32 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417600430.11243.1.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=eswierk@skyportsystems.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.