From: Ian Campbell <Ian.Campbell@citrix.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Ed Swierk <eswierk@skyportsystems.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] libxl: Fix building libxlu_cfg_y.y with bison 3.0
Date: Wed, 10 Dec 2014 16:44:00 +0000 [thread overview]
Message-ID: <1418229840.3505.88.camel@citrix.com> (raw)
In-Reply-To: <20141210164131.GG4268@laptop.dumpdata.com>
On Wed, 2014-12-10 at 11:41 -0500, Konrad Rzeszutek Wilk wrote:
> On Tue, Dec 09, 2014 at 03:25:29PM +0000, Ian Jackson wrote:
> > Ian Campbell writes ("Re: [Xen-devel] [PATCH] libxl: Fix building libxlu_cfg_y.y with bison 3.0"):
> > > There was a point in time where the prevailing version of bison (or
> > > maybe flex) in stable distro releases had a bug which meant these files
> > > could not be regenerated easily on common distros. I don't recall the
> > > details well enough to know if that time has now passed. Perhaps Ian J
> > > does.
> >
> > We use (essential) features found only in non-ancient versions of
> > bison and flex. The last time it was proposed to remove these
> > pregenerated files, there were complaints from people who were using
> > six-year-old bison and flex.
> >
> > I think we should prioritise compatibility with new versions of bison
> > and flex, and retain the pregenerated versions of people with
> > incompatibly old version.
> >
> > I think for 4.5 we should:
> >
> > * Regenerate the flex files with current wheezy's flex. (I have
> > reviewed the diff in the generated code. It produces trivial
> > changes which add declarations of xlu__cfg_yyget_column and
> > xlu__cfg_yyset_column, but no code body changes - see below.)
> >
> > * Take the patch from Ed and regenerate the bison files too.
> >
> >
> > Konrad: can we have two freeze exceptions please ?
> >
> > Risk analysis for Ed's patch:
> >
> > Not taking the patch hurts systems with bison 2.7.1 or later:
> >
> > - Affected systems include Debian jessie, which will be
> > released during the lifetime of 4.5.
>
> My understanding is that Jessie won't be using Xen 4.5 but Xen 4.4 And the
> next version of Debian that will be released will be most likely using Xen 4.6.
What Jessie (or Fedora etc) has available in packages has no real
bearing on whether people might run Xen 4.5 on them, plenty of people
will still build from source, including developers.
Ian.
next prev parent reply other threads:[~2014-12-10 16:44 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-30 5:23 [PATCH] libxl: Fix building libxlu_cfg_y.y with bison 3.0 Ed Swierk
2014-12-01 9:42 ` Ian Campbell
2014-12-01 12:19 ` Wei Liu
2014-12-02 13:47 ` Ian Campbell
2014-12-02 14:00 ` Andrew Cooper
2014-12-02 17:49 ` Ed Swierk
2014-12-03 9:53 ` Ian Campbell
2014-12-03 10:01 ` Olaf Hering
2014-12-09 15:25 ` Ian Jackson
2014-12-10 16:41 ` Konrad Rzeszutek Wilk
2014-12-10 16:44 ` Ian Campbell [this message]
2014-12-10 17:02 ` Konrad Rzeszutek Wilk
2015-01-06 15:28 ` Ian Jackson
2014-12-02 18:32 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418229840.3505.88.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=eswierk@skyportsystems.com \
--cc=konrad.wilk@oracle.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.