All of lore.kernel.org
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Mike Turquette <mturquette@linaro.org>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: Tomasz Figa <tomasz.figa@gmail.com>,
	Kukjin Kim <kgene@kernel.org>,
	linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	Javier Martinez Canillas <javier.martinez@collabora.co.uk>,
	Linus Walleij <linus.walleij@linaro.org>,
	linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
	Vivek Gautam <gautam.vivek@samsung.com>,
	Kevin Hilman <khilman@kernel.org>,
	Kyungmin Park <kyungmin.park@samsung.com>,
	Marek Szyprowski <m.szyprowski@samsung.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Subject: Re: [PATCH v3 0/3] Fix Arndale Octa/Peach Pi boot on Audio subsystem clocks
Date: Thu, 04 Dec 2014 11:52:43 +0100	[thread overview]
Message-ID: <1417690363.3314.7.camel@AMDC1943> (raw)
In-Reply-To: <1417690075-13483-1-git-send-email-k.kozlowski@samsung.com>

On czw, 2014-12-04 at 11:47 +0100, Krzysztof Kozlowski wrote:
> Hi,
> 
> 
> Changes since v2
> ================
> 1. Patch 1 applied ("clk: samsung: Fix double add of syscore ops after
>    driver rebind"), remove it.
> 2. Squash patch 5 with "clk: samsung: Fix clock disable
>    failure because domain being gated". Suggested by Sylwester.
> 3. Patch 1/3: Fix issues pointed by Sylwester.
> 4. Patch 2/3: Fix redundant clk_disable when removing driver (clk is
>    already disabled). Add missing check !=null when removing driver.
> 5. Patch 3/3: Extend commit message.


Aaa, I forgot to add tested-by Javier Martinez Canillas
<javier.martinez@collabora.co.uk>
https://lkml.org/lkml/2014/11/26/420

These are minor changes so I think the "tested-by" still applies.
If patches are OK and someone applies the, please don't forget about
that tag.

Best regards,
Krzysztof

> 
> Changes since v1
> ================
> 1. clocks-audss: Reimplement own clock register functions instead
>    changing clk API. Minor fixes. (after idea from Tomasz Figa)
> 2. Add new patches: fix for pinctrl and minor fixes in clk-audss.
> 
> Description
> ===========
> This patchset tries to solve dependency between AudioSS components
> (clocks and GPIO) and main clock controller on Exynos 5420 platform.
> 
> This solves boot failure of Peach Pi/Pit and Arndale Octa [1].
> 
> Any access to memory of audss block (like checking if clock is enabled
> or configuring GPIO) will hang if main audss clock is gated.
> 
> Tested on Arndale Octa board.
> 
> [1] http://www.spinics.net/lists/linux-samsung-soc/msg39331.html
> 
> Best regards,
> Krzysztof Kozlowski
> 
> 
> Krzysztof Kozlowski (3):
>   clk: samsung: Fix clock disable failure because domain being gated
>   pinctrl: exynos: Fix GPIO setup failure because domain clock being
>     gated
>   ARM: dts: exynos5420: Add clock for audss pinctrl (fixing GPIO setup
>     failure)
> 
>  .../bindings/pinctrl/samsung-pinctrl.txt           |   6 +
>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi          |   3 +
>  drivers/clk/samsung/clk-exynos-audss.c             | 357 ++++++++++++++++++---
>  drivers/pinctrl/samsung/pinctrl-samsung.c          | 111 ++++++-
>  drivers/pinctrl/samsung/pinctrl-samsung.h          |   2 +
>  5 files changed, 436 insertions(+), 43 deletions(-)
> 

WARNING: multiple messages have this Message-ID (diff)
From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 0/3] Fix Arndale Octa/Peach Pi boot on Audio subsystem clocks
Date: Thu, 04 Dec 2014 11:52:43 +0100	[thread overview]
Message-ID: <1417690363.3314.7.camel@AMDC1943> (raw)
In-Reply-To: <1417690075-13483-1-git-send-email-k.kozlowski@samsung.com>

On czw, 2014-12-04 at 11:47 +0100, Krzysztof Kozlowski wrote:
> Hi,
> 
> 
> Changes since v2
> ================
> 1. Patch 1 applied ("clk: samsung: Fix double add of syscore ops after
>    driver rebind"), remove it.
> 2. Squash patch 5 with "clk: samsung: Fix clock disable
>    failure because domain being gated". Suggested by Sylwester.
> 3. Patch 1/3: Fix issues pointed by Sylwester.
> 4. Patch 2/3: Fix redundant clk_disable when removing driver (clk is
>    already disabled). Add missing check !=null when removing driver.
> 5. Patch 3/3: Extend commit message.


Aaa, I forgot to add tested-by Javier Martinez Canillas
<javier.martinez@collabora.co.uk>
https://lkml.org/lkml/2014/11/26/420

These are minor changes so I think the "tested-by" still applies.
If patches are OK and someone applies the, please don't forget about
that tag.

Best regards,
Krzysztof

> 
> Changes since v1
> ================
> 1. clocks-audss: Reimplement own clock register functions instead
>    changing clk API. Minor fixes. (after idea from Tomasz Figa)
> 2. Add new patches: fix for pinctrl and minor fixes in clk-audss.
> 
> Description
> ===========
> This patchset tries to solve dependency between AudioSS components
> (clocks and GPIO) and main clock controller on Exynos 5420 platform.
> 
> This solves boot failure of Peach Pi/Pit and Arndale Octa [1].
> 
> Any access to memory of audss block (like checking if clock is enabled
> or configuring GPIO) will hang if main audss clock is gated.
> 
> Tested on Arndale Octa board.
> 
> [1] http://www.spinics.net/lists/linux-samsung-soc/msg39331.html
> 
> Best regards,
> Krzysztof Kozlowski
> 
> 
> Krzysztof Kozlowski (3):
>   clk: samsung: Fix clock disable failure because domain being gated
>   pinctrl: exynos: Fix GPIO setup failure because domain clock being
>     gated
>   ARM: dts: exynos5420: Add clock for audss pinctrl (fixing GPIO setup
>     failure)
> 
>  .../bindings/pinctrl/samsung-pinctrl.txt           |   6 +
>  arch/arm/boot/dts/exynos5420-pinctrl.dtsi          |   3 +
>  drivers/clk/samsung/clk-exynos-audss.c             | 357 ++++++++++++++++++---
>  drivers/pinctrl/samsung/pinctrl-samsung.c          | 111 ++++++-
>  drivers/pinctrl/samsung/pinctrl-samsung.h          |   2 +
>  5 files changed, 436 insertions(+), 43 deletions(-)
> 

  parent reply	other threads:[~2014-12-04 10:52 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-04 10:47 [PATCH v3 0/3] Fix Arndale Octa/Peach Pi boot on Audio subsystem clocks Krzysztof Kozlowski
2014-12-04 10:47 ` Krzysztof Kozlowski
2014-12-04 10:47 ` [PATCH v3 1/3] clk: samsung: Fix clock disable failure because domain being gated Krzysztof Kozlowski
2014-12-04 10:47   ` Krzysztof Kozlowski
2014-12-04 11:49   ` Sylwester Nawrocki
2014-12-04 11:49     ` Sylwester Nawrocki
2014-12-04 12:03     ` Krzysztof Kozlowski
2014-12-04 12:03       ` Krzysztof Kozlowski
2014-12-04 10:47 ` [PATCH v3 2/3] pinctrl: exynos: Fix GPIO setup failure because domain clock " Krzysztof Kozlowski
2014-12-04 10:47   ` Krzysztof Kozlowski
     [not found] ` <1417690075-13483-1-git-send-email-k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
2014-12-04 10:47   ` [PATCH v3 3/3] ARM: dts: exynos5420: Add clock for audss pinctrl (fixing GPIO setup failure) Krzysztof Kozlowski
2014-12-04 10:47     ` Krzysztof Kozlowski
2014-12-04 10:47     ` Krzysztof Kozlowski
2014-12-04 10:52 ` Krzysztof Kozlowski [this message]
2014-12-04 10:52   ` [PATCH v3 0/3] Fix Arndale Octa/Peach Pi boot on Audio subsystem clocks Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1417690363.3314.7.camel@AMDC1943 \
    --to=k.kozlowski@samsung.com \
    --cc=b.zolnierkie@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=gautam.vivek@samsung.com \
    --cc=javier.martinez@collabora.co.uk \
    --cc=kgene@kernel.org \
    --cc=khilman@kernel.org \
    --cc=kyungmin.park@samsung.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=m.szyprowski@samsung.com \
    --cc=mturquette@linaro.org \
    --cc=s.nawrocki@samsung.com \
    --cc=tomasz.figa@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.