From: Ian Campbell <Ian.Campbell@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: keir@xen.org, ufimtseva@gmail.com,
stefano.stabellini@eu.citrix.com, ian.jackson@eu.citrix.com,
xen-devel@lists.xen.org, jbeulich@suse.com, wei.liu2@citrix.com,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH 3/4] sysctl/libxl: Provide information about IO topology
Date: Thu, 4 Dec 2014 13:28:13 +0000 [thread overview]
Message-ID: <1417699693.22808.37.camel@citrix.com> (raw)
In-Reply-To: <1417695730.31647.35.camel@Abyss.station>
On Thu, 2014-12-04 at 13:22 +0100, Dario Faggioli wrote:
> On Tue, 2014-12-02 at 16:34 -0500, Boris Ostrovsky wrote:
>
> > --- a/tools/libxl/libxl_internal.h
> > +++ b/tools/libxl/libxl_internal.h
> > @@ -1168,6 +1168,11 @@ _hidden int libxl__try_phy_backend(mode_t st_mode);
> >
> > _hidden char *libxl__devid_to_localdev(libxl__gc *gc, int devid);
> >
> > +_hidden int libxl_pci_numdevs(libxl_ctx *ctx);
> > +_hidden int libxl_pci_topology_init(libxl_ctx *ctx,
> > + xen_sysctl_iotopo_t *iotopo,
> > + int numdev);
> > +
> IIRC, internal/hidden function should have libxl__* as prefix.
And, generally, take a gc instead of a ctx.
next prev parent reply other threads:[~2014-12-04 13:28 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 21:34 [PATCH 0/4] Display IO topology when PXM data is available Boris Ostrovsky
2014-12-02 21:34 ` [PATCH 1/4] pci: Do not ignore device's PXM information Boris Ostrovsky
2014-12-03 15:01 ` Andrew Cooper
2014-12-03 15:19 ` Boris Ostrovsky
2014-12-05 15:53 ` Jan Beulich
2014-12-05 17:02 ` Boris Ostrovsky
2014-12-02 21:34 ` [PATCH 2/4] sysctl/libxl: Add interface for returning IO topology data Boris Ostrovsky
2014-12-03 15:20 ` Andrew Cooper
2014-12-03 15:37 ` Boris Ostrovsky
2014-12-04 11:24 ` Wei Liu
2014-12-04 11:55 ` Dario Faggioli
2014-12-04 16:26 ` Boris Ostrovsky
2014-12-04 16:44 ` Andrew Cooper
2014-12-04 17:11 ` Jan Beulich
2014-12-05 15:55 ` Jan Beulich
2014-12-05 16:03 ` Jan Beulich
2014-12-05 17:10 ` Boris Ostrovsky
2014-12-08 8:33 ` Jan Beulich
2014-12-08 14:56 ` Boris Ostrovsky
2014-12-08 15:19 ` Jan Beulich
2014-12-08 15:30 ` Andrew Cooper
2014-12-02 21:34 ` [PATCH 3/4] sysctl/libxl: Provide information about IO topology Boris Ostrovsky
2014-12-04 12:22 ` Dario Faggioli
2014-12-04 13:28 ` Ian Campbell [this message]
2014-12-05 15:59 ` Jan Beulich
2014-12-02 21:34 ` [PATCH 4/4] libxl: Switch to using new topology interface Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1417699693.22808.37.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=dario.faggioli@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=ufimtseva@gmail.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.