From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: scottwood@freescale.com, Paul Mackerras <paulus@samba.org>,
linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: powerpc32: missing accessors to pgprot_t objects
Date: Tue, 09 Dec 2014 21:13:14 +1100 [thread overview]
Message-ID: <1418119994.13358.43.camel@kernel.crashing.org> (raw)
In-Reply-To: <20141209100617.630111400EA@ozlabs.org>
On Tue, 2014-12-09 at 21:06 +1100, Michael Ellerman wrote:
> On Mon, 2014-08-12 at 14:16:29 UTC, LEROY Christophe wrote:
> > Compilation with #define STRICT_MM_TYPECHECKS in arch/powerpc/include/asm/page.h
> > fails due to missing use of pgprot_val() when using pgprot_t objects.
>
> Any idea when this broke? Recently, or has it gone unnoticed for a long time?
Probably a very long time...
Now the reason we didn't leave STRICT_MM_TYPECHECKS enable back in the
day is that gcc was doing a terrible job at compiling it resulting in
bloated inefficient code.
I wouldn't be surprised if that is all fixed...
Cheers,
Ben.
WARNING: multiple messages have this Message-ID (diff)
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <mpe@ellerman.id.au>
Cc: LEROY Christophe <christophe.leroy@c-s.fr>,
Paul Mackerras <paulus@samba.org>,
scottwood@freescale.com, linuxppc-dev@lists.ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: powerpc32: missing accessors to pgprot_t objects
Date: Tue, 09 Dec 2014 21:13:14 +1100 [thread overview]
Message-ID: <1418119994.13358.43.camel@kernel.crashing.org> (raw)
In-Reply-To: <20141209100617.630111400EA@ozlabs.org>
On Tue, 2014-12-09 at 21:06 +1100, Michael Ellerman wrote:
> On Mon, 2014-08-12 at 14:16:29 UTC, LEROY Christophe wrote:
> > Compilation with #define STRICT_MM_TYPECHECKS in arch/powerpc/include/asm/page.h
> > fails due to missing use of pgprot_val() when using pgprot_t objects.
>
> Any idea when this broke? Recently, or has it gone unnoticed for a long time?
Probably a very long time...
Now the reason we didn't leave STRICT_MM_TYPECHECKS enable back in the
day is that gcc was doing a terrible job at compiling it resulting in
bloated inefficient code.
I wouldn't be surprised if that is all fixed...
Cheers,
Ben.
next prev parent reply other threads:[~2014-12-09 10:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-08 14:16 [PATCH] powerpc32: missing accessors to pgprot_t objects Christophe Leroy
2014-12-08 14:16 ` Christophe Leroy
2014-12-09 10:06 ` Michael Ellerman
2014-12-09 10:13 ` Benjamin Herrenschmidt [this message]
2014-12-09 10:13 ` Benjamin Herrenschmidt
2014-12-09 10:18 ` Michael Ellerman
2014-12-09 15:06 ` Aneesh Kumar K.V
2014-12-09 15:06 ` Aneesh Kumar K.V
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418119994.13358.43.camel@kernel.crashing.org \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=mpe@ellerman.id.au \
--cc=paulus@samba.org \
--cc=scottwood@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.