From: k.kozlowski@samsung.com (Krzysztof Kozlowski)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] arm64: psci: Fix build breakage without PM_SLEEP
Date: Tue, 09 Dec 2014 13:38:09 +0100 [thread overview]
Message-ID: <1418128689.19339.3.camel@AMDC1943> (raw)
In-Reply-To: <2290734.BRljGaICu4@wuerfel>
On wto, 2014-12-09 at 13:29 +0100, Arnd Bergmann wrote:
> On Tuesday 09 December 2014 12:48:36 Krzysztof Kozlowski wrote:
> > Fix build failure of defconfig when PM_SLEEP is disabled (e.g. by
> > disabling SUSPEND) and CPU_IDLE enabled:
> >
> > arch/arm64/kernel/psci.c:543:2: error: unknown field ?cpu_suspend? specified in initializer
> > .cpu_suspend = cpu_psci_cpu_suspend,
> > ^
> > arch/arm64/kernel/psci.c:543:2: warning: initialization from incompatible pointer type [enabled by default]
> > arch/arm64/kernel/psci.c:543:2: warning: (near initialization for ?cpu_psci_ops.cpu_prepare?) [enabled by default]
> > make[1]: *** [arch/arm64/kernel/psci.o] Error 1
> >
> > The cpu_operations.cpu_suspend field exists only if ARM64_CPU_SUSPEND is
> > defined, not CPU_IDLE.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >
>
> No objection to fixing this obvious build bug, but why do we even have
> an ARM64_CPU_SUSPEND option? On ARM32 we only have the respective option
> because we have a random collection of platform specific drivers that
> use the symbols, but that's not the case on ARM64.
I believe because of cpuidle. It's the same as on ARM32: the cpu_suspend
is used by both PM_SLEEP and CPU_IDLE.
Best regards,
Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Krzysztof Kozlowski <k.kozlowski@samsung.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Will Deacon <will.deacon@arm.com>,
Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm64: psci: Fix build breakage without PM_SLEEP
Date: Tue, 09 Dec 2014 13:38:09 +0100 [thread overview]
Message-ID: <1418128689.19339.3.camel@AMDC1943> (raw)
In-Reply-To: <2290734.BRljGaICu4@wuerfel>
On wto, 2014-12-09 at 13:29 +0100, Arnd Bergmann wrote:
> On Tuesday 09 December 2014 12:48:36 Krzysztof Kozlowski wrote:
> > Fix build failure of defconfig when PM_SLEEP is disabled (e.g. by
> > disabling SUSPEND) and CPU_IDLE enabled:
> >
> > arch/arm64/kernel/psci.c:543:2: error: unknown field ‘cpu_suspend’ specified in initializer
> > .cpu_suspend = cpu_psci_cpu_suspend,
> > ^
> > arch/arm64/kernel/psci.c:543:2: warning: initialization from incompatible pointer type [enabled by default]
> > arch/arm64/kernel/psci.c:543:2: warning: (near initialization for ‘cpu_psci_ops.cpu_prepare’) [enabled by default]
> > make[1]: *** [arch/arm64/kernel/psci.o] Error 1
> >
> > The cpu_operations.cpu_suspend field exists only if ARM64_CPU_SUSPEND is
> > defined, not CPU_IDLE.
> >
> > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> >
>
> No objection to fixing this obvious build bug, but why do we even have
> an ARM64_CPU_SUSPEND option? On ARM32 we only have the respective option
> because we have a random collection of platform specific drivers that
> use the symbols, but that's not the case on ARM64.
I believe because of cpuidle. It's the same as on ARM32: the cpu_suspend
is used by both PM_SLEEP and CPU_IDLE.
Best regards,
Krzysztof
next prev parent reply other threads:[~2014-12-09 12:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-09 11:48 [PATCH] arm64: psci: Fix build breakage without PM_SLEEP Krzysztof Kozlowski
2014-12-09 11:48 ` Krzysztof Kozlowski
2014-12-09 12:29 ` Arnd Bergmann
2014-12-09 12:29 ` Arnd Bergmann
2014-12-09 12:38 ` Krzysztof Kozlowski [this message]
2014-12-09 12:38 ` Krzysztof Kozlowski
2014-12-09 16:15 ` Catalin Marinas
2014-12-09 16:15 ` Catalin Marinas
2014-12-12 15:06 ` Lorenzo Pieralisi
2014-12-12 15:06 ` Lorenzo Pieralisi
2014-12-15 17:46 ` Catalin Marinas
2014-12-15 17:46 ` Catalin Marinas
2014-12-15 18:32 ` Lorenzo Pieralisi
2014-12-15 18:32 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418128689.19339.3.camel@AMDC1943 \
--to=k.kozlowski@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.