From: Ian Campbell <Ian.Campbell@citrix.com>
To: Daniel Kiper <daniel.kiper@oracle.com>
Cc: xen-devel@lists.xenproject.org, keir@xen.org,
ian.jackson@eu.citrix.com, jbeulich@suse.com,
andrew.cooper3@citrix.com
Subject: Re: [PATCH for-xen-4.5 1/3] tools/hotplug: distclean target should remove files generated by configure
Date: Tue, 9 Dec 2014 14:35:37 +0000 [thread overview]
Message-ID: <1418135737.14361.71.camel@citrix.com> (raw)
In-Reply-To: <1417533390-29035-2-git-send-email-daniel.kiper@oracle.com>
On Tue, 2014-12-02 at 16:16 +0100, Daniel Kiper wrote:
> +distclean:
> + rm -f Linux/init.d/sysconfig.xencommons Linux/init.d/xencommons NetBSD/rc.d/xencommons
Configure generates a boatload more things than this, see e.g.
$ grep hotplug/ tools/configure.ac
Perhaps the answer would be to recurse into tools/hotplug/* and refactor
the existing XEN_SCRIPTS to have the generated stuff in XEN_SCRIPTS_GEN
instead and XEN_SCRIPTS += $(XEN_SCRIPTS). The on distclean remove the
XEN_SCRIPTS_GEN ones.
It's not ideal, but at least it puts the distclean logic in the same
place as the logic to install the files, if not their generation, which
at least increases the chance of someone adding it to the right place.
Ian.
next prev parent reply other threads:[~2014-12-09 14:35 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 15:16 [PATCH for-xen-4.5 0/3] tools: build system fixes and cleanups Daniel Kiper
2014-12-02 15:16 ` [PATCH for-xen-4.5 1/3] tools/hotplug: distclean target should remove files generated by configure Daniel Kiper
2014-12-02 18:36 ` Konrad Rzeszutek Wilk
2014-12-03 15:53 ` Daniel Kiper
2014-12-03 20:36 ` Konrad Rzeszutek Wilk
2014-12-04 8:17 ` [Pkg-xen-devel] " Ian Campbell
2014-12-05 1:53 ` Konrad Rzeszutek Wilk
2014-12-05 14:52 ` Daniel Kiper
2014-12-09 14:35 ` Ian Campbell [this message]
2014-12-09 15:32 ` Konrad Rzeszutek Wilk
2014-12-02 15:16 ` [PATCH for-xen-4.5 2/3] gitignore: ignore some " Daniel Kiper
2014-12-04 13:25 ` Ian Campbell
2014-12-05 14:52 ` Daniel Kiper
2014-12-02 15:16 ` [PATCH for-xen-4.5 3/3] gitignore: group tools/hotplug files in one place Daniel Kiper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418135737.14361.71.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=daniel.kiper@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=keir@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.