From: Joe Perches <joe-6d6DIl74uiNBDgjK7y7TUQ@public.gmane.org>
To: David Miller <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>,
Andrew Morton
<akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org>,
Christopher Li <sparse-55XgFHCVCFZAfugRpC6u6w@public.gmane.org>,
Michal Marek <mmarek-AlSwsSmVLrQ@public.gmane.org>
Cc: m-karicheri2-l0cyMroinI0@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org,
grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org,
linux-sparse-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: default enable sparse __CHECK_ENDIAN__ (was: Re: [PATCH v7 2/3] net: Add Keystone NetCP ethernet driver)
Date: Wed, 10 Dec 2014 19:04:59 -0800 [thread overview]
Message-ID: <1418267099.18092.28.camel@perches.com> (raw)
In-Reply-To: <20141210.204110.618599360537141819.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
On Wed, 2014-12-10 at 20:41 -0500, David Miller wrote:
> From: Murali Karicheri <m-karicheri2-l0cyMroinI0@public.gmane.org>
> > Are you referring to the static code analyser sparse that is invoked
> > through?
> You have to explicitly enable endian checking, it's not on by
> default.
There don't seem to be thousands of warnings anymore.
Maybe it's time to default enable it when using C=?
from: Documentation/sparse.txt:
The optional make variable CF can be used to pass arguments to sparse. The
build system passes -Wbitwise to sparse automatically. To perform endianness
checks, you may define __CHECK_ENDIAN__:
make C=2 CF="-D__CHECK_ENDIAN__"
These checks are disabled by default as they generate a host of warnings.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: default enable sparse __CHECK_ENDIAN__ (was: Re: [PATCH v7 2/3] net: Add Keystone NetCP ethernet driver)
Date: Wed, 10 Dec 2014 19:04:59 -0800 [thread overview]
Message-ID: <1418267099.18092.28.camel@perches.com> (raw)
In-Reply-To: <20141210.204110.618599360537141819.davem@davemloft.net>
On Wed, 2014-12-10 at 20:41 -0500, David Miller wrote:
> From: Murali Karicheri <m-karicheri2@ti.com>
> > Are you referring to the static code analyser sparse that is invoked
> > through?
> You have to explicitly enable endian checking, it's not on by
> default.
There don't seem to be thousands of warnings anymore.
Maybe it's time to default enable it when using C=?
from: Documentation/sparse.txt:
The optional make variable CF can be used to pass arguments to sparse. The
build system passes -Wbitwise to sparse automatically. To perform endianness
checks, you may define __CHECK_ENDIAN__:
make C=2 CF="-D__CHECK_ENDIAN__"
These checks are disabled by default as they generate a host of warnings.
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: David Miller <davem@davemloft.net>,
Andrew Morton <akpm@linux-foundation.org>,
Christopher Li <sparse@chrisli.org>,
Michal Marek <mmarek@suse.cz>
Cc: m-karicheri2@ti.com, netdev@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
robh+dt@kernel.org, grant.likely@linaro.org,
linux-sparse@vger.kernel.org
Subject: default enable sparse __CHECK_ENDIAN__ (was: Re: [PATCH v7 2/3] net: Add Keystone NetCP ethernet driver)
Date: Wed, 10 Dec 2014 19:04:59 -0800 [thread overview]
Message-ID: <1418267099.18092.28.camel@perches.com> (raw)
In-Reply-To: <20141210.204110.618599360537141819.davem@davemloft.net>
On Wed, 2014-12-10 at 20:41 -0500, David Miller wrote:
> From: Murali Karicheri <m-karicheri2@ti.com>
> > Are you referring to the static code analyser sparse that is invoked
> > through?
> You have to explicitly enable endian checking, it's not on by
> default.
There don't seem to be thousands of warnings anymore.
Maybe it's time to default enable it when using C=?
from: Documentation/sparse.txt:
The optional make variable CF can be used to pass arguments to sparse. The
build system passes -Wbitwise to sparse automatically. To perform endianness
checks, you may define __CHECK_ENDIAN__:
make C=2 CF="-D__CHECK_ENDIAN__"
These checks are disabled by default as they generate a host of warnings.
next prev parent reply other threads:[~2014-12-11 3:04 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 21:41 [PATCH v7 0/3] net: Add Keystone NetCP ethernet driver support Murali Karicheri
2014-12-02 21:41 ` Murali Karicheri
2014-12-02 21:41 ` Murali Karicheri
2014-12-02 21:41 ` Murali Karicheri
2014-12-02 21:41 ` [PATCH v7 1/3] Documentation: dt: net: Add binding doc for Keystone NetCP ethernet driver Murali Karicheri
2014-12-02 21:41 ` Murali Karicheri
2014-12-02 21:41 ` Murali Karicheri
2014-12-02 21:41 ` [PATCH v7 2/3] net: Add " Murali Karicheri
2014-12-02 21:41 ` Murali Karicheri
2014-12-09 18:10 ` David Miller
2014-12-09 18:10 ` David Miller
2014-12-09 18:10 ` David Miller
2014-12-10 21:31 ` Murali Karicheri
2014-12-10 21:31 ` Murali Karicheri
2014-12-10 21:31 ` Murali Karicheri
2014-12-10 21:31 ` Murali Karicheri
2014-12-11 1:41 ` David Miller
2014-12-11 1:41 ` David Miller
2014-12-11 1:41 ` David Miller
[not found] ` <20141210.204110.618599360537141819.davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>
2014-12-11 3:04 ` Joe Perches [this message]
2014-12-11 3:04 ` default enable sparse __CHECK_ENDIAN__ (was: Re: [PATCH v7 2/3] net: Add Keystone NetCP ethernet driver) Joe Perches
2014-12-11 3:04 ` Joe Perches
2014-12-11 11:18 ` Marcel Holtmann
2014-12-11 11:18 ` Marcel Holtmann
2014-12-11 14:14 ` [PATCH v7 2/3] net: Add Keystone NetCP ethernet driver Murali Karicheri
2014-12-11 14:14 ` Murali Karicheri
2014-12-11 14:14 ` Murali Karicheri
2014-12-11 14:14 ` Murali Karicheri
2014-12-11 17:01 ` David Miller
2014-12-11 17:01 ` David Miller
2014-12-11 17:17 ` Murali Karicheri
2014-12-11 17:17 ` Murali Karicheri
2014-12-11 17:17 ` Murali Karicheri
2014-12-11 17:17 ` Murali Karicheri
2014-12-11 18:34 ` Joe Perches
2014-12-11 18:34 ` Joe Perches
2014-12-11 20:21 ` Murali Karicheri
2014-12-11 20:21 ` Murali Karicheri
2014-12-11 20:21 ` Murali Karicheri
2014-12-11 20:21 ` Murali Karicheri
2014-12-02 21:41 ` [PATCH v7 3/3] MAINTAINER: net: Add TI NETCP Ethernet driver entry Murali Karicheri
2014-12-02 21:41 ` Murali Karicheri
2014-12-02 21:41 ` Murali Karicheri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418267099.18092.28.camel@perches.com \
--to=joe-6d6dil74uinbdgjk7y7tuq@public.gmane.org \
--cc=akpm-de/tnXTf+JLsfHDXvbKv3WD2FQJk+8+b@public.gmane.org \
--cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \
--cc=devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=grant.likely-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sparse-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m-karicheri2-l0cyMroinI0@public.gmane.org \
--cc=mmarek-AlSwsSmVLrQ@public.gmane.org \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
--cc=sparse-55XgFHCVCFZAfugRpC6u6w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.