From: Huang Ying <ying.huang@intel.com>
To: lkp@lists.01.org
Subject: Re: [userns] BUG: unable to handle kernel NULL pointer dereference at (null)
Date: Tue, 16 Dec 2014 09:47:39 +0800 [thread overview]
Message-ID: <1418694459.5745.198.camel@intel.com> (raw)
In-Reply-To: <87iohcx1k1.fsf@x220.int.ebiederm.org>
[-- Attachment #1: Type: text/plain, Size: 1408 bytes --]
On Mon, 2014-12-15 at 11:31 -0600, Eric W. Biederman wrote:
> Huang Ying <ying.huang@intel.com> writes:
>
> > FYI, we noticed the below changes on
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-testing
> > commit bbea5f5532501fdd67f46442ba7b1122d7ff3123
> > ("userns: Add a knob to disable setgroups on a per user namespace basis")
>
> Thank you.
>
> I am quite puzzled by this failure. There was an similar failure when
> /proc/[pid]/setgroups was read (if I recall correctly). I don't see how
> that change could result at failures during open or failures during
> boot. I added a new file to proc which any reasonable system should
> leave alone. Are you by chance running trinity during boot?
Yes. We are running trinity during boot.
> If the reproducer gave me any clue about which file that was opened or
> which code path this happened on I would be bery interested. If for no
> other reason that to confirm that I have fixed the issue.
This is just boot test, with trinity running after kernel boot.
Fengguang, do you have more information?
Best Regards,
Huang, Ying
> I have rewritten the implementation of /proc/[pid]/setgroups so it is
> simpler and more robust and does not have any errors I can detect.
>
> Thank you very much for picking up my for-testing branch and beating up
> on it.
>
> Eric
WARNING: multiple messages have this Message-ID (diff)
From: Huang Ying <ying.huang@intel.com>
To: "Eric W. Biederman" <ebiederm@xmission.com>,
Wu Fengguang <fengguang.wu@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, LKP ML <lkp@01.org>
Subject: Re: [LKP] [userns] BUG: unable to handle kernel NULL pointer dereference at (null)
Date: Tue, 16 Dec 2014 09:47:39 +0800 [thread overview]
Message-ID: <1418694459.5745.198.camel@intel.com> (raw)
In-Reply-To: <87iohcx1k1.fsf@x220.int.ebiederm.org>
On Mon, 2014-12-15 at 11:31 -0600, Eric W. Biederman wrote:
> Huang Ying <ying.huang@intel.com> writes:
>
> > FYI, we noticed the below changes on
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/ebiederm/user-namespace.git for-testing
> > commit bbea5f5532501fdd67f46442ba7b1122d7ff3123
> > ("userns: Add a knob to disable setgroups on a per user namespace basis")
>
> Thank you.
>
> I am quite puzzled by this failure. There was an similar failure when
> /proc/[pid]/setgroups was read (if I recall correctly). I don't see how
> that change could result at failures during open or failures during
> boot. I added a new file to proc which any reasonable system should
> leave alone. Are you by chance running trinity during boot?
Yes. We are running trinity during boot.
> If the reproducer gave me any clue about which file that was opened or
> which code path this happened on I would be bery interested. If for no
> other reason that to confirm that I have fixed the issue.
This is just boot test, with trinity running after kernel boot.
Fengguang, do you have more information?
Best Regards,
Huang, Ying
> I have rewritten the implementation of /proc/[pid]/setgroups so it is
> simpler and more robust and does not have any errors I can detect.
>
> Thank you very much for picking up my for-testing branch and beating up
> on it.
>
> Eric
next prev parent reply other threads:[~2014-12-16 1:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 3:21 [userns] BUG: unable to handle kernel NULL pointer dereference at (null) Huang Ying
2014-12-15 3:21 ` [LKP] " Huang Ying
2014-12-15 17:31 ` Eric W. Biederman
2014-12-15 17:31 ` [LKP] " Eric W. Biederman
2014-12-16 1:47 ` Huang Ying [this message]
2014-12-16 1:47 ` Huang Ying
2014-12-16 6:29 ` Fengguang Wu
2014-12-16 6:29 ` [LKP] " Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418694459.5745.198.camel@intel.com \
--to=ying.huang@intel.com \
--cc=lkp@lists.01.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.