From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] mac80211: notify NSS changed when IBSS and HT
Date: Tue, 16 Dec 2014 20:54:23 +0100 [thread overview]
Message-ID: <1418759663.1943.7.camel@sipsolutions.net> (raw)
In-Reply-To: <1418720165-19810-1-git-send-email-janusz.dziedzic@tieto.com> (sfid-20141216_095709_865462_C6672725)
On Tue, 2014-12-16 at 09:56 +0100, Janusz Dziedzic wrote:
> drv_sta_rc_update(local, sdata, &sta->sta,
> IEEE80211_RC_SUPP_RATES_CHANGED);
> + /* Force rx_nss recalculation */
> + sta->sta.rx_nss = 0;
> rate_control_rate_init(sta);
> + if (rx_nss != sta->sta.rx_nss)
> + drv_sta_rc_update(local, sdata, &sta->sta,
> + IEEE80211_RC_NSS_CHANGED);
Seems to me you should consolidate those two drv_sta_rc_update() calls
and just make the flags dependent on the NSS change?
johannes
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Johannes Berg <johannes@sipsolutions.net>
To: Janusz Dziedzic <janusz.dziedzic@tieto.com>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] mac80211: notify NSS changed when IBSS and HT
Date: Tue, 16 Dec 2014 20:54:23 +0100 [thread overview]
Message-ID: <1418759663.1943.7.camel@sipsolutions.net> (raw)
In-Reply-To: <1418720165-19810-1-git-send-email-janusz.dziedzic@tieto.com> (sfid-20141216_095709_865462_C6672725)
On Tue, 2014-12-16 at 09:56 +0100, Janusz Dziedzic wrote:
> drv_sta_rc_update(local, sdata, &sta->sta,
> IEEE80211_RC_SUPP_RATES_CHANGED);
> + /* Force rx_nss recalculation */
> + sta->sta.rx_nss = 0;
> rate_control_rate_init(sta);
> + if (rx_nss != sta->sta.rx_nss)
> + drv_sta_rc_update(local, sdata, &sta->sta,
> + IEEE80211_RC_NSS_CHANGED);
Seems to me you should consolidate those two drv_sta_rc_update() calls
and just make the flags dependent on the NSS change?
johannes
next prev parent reply other threads:[~2014-12-16 19:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 8:56 [PATCH] mac80211: notify NSS changed when IBSS and HT Janusz Dziedzic
2014-12-16 8:56 ` Janusz Dziedzic
2014-12-16 19:54 ` Johannes Berg [this message]
2014-12-16 19:54 ` Johannes Berg
2014-12-17 8:06 ` Janusz Dziedzic
2014-12-17 8:06 ` Janusz Dziedzic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418759663.1943.7.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ath10k@lists.infradead.org \
--cc=janusz.dziedzic@tieto.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.