From: Joe Perches <realty@perches.com>
To: Kevin Cernekee <cernekee@gmail.com>
Cc: Brian Norris <computersforpeace@gmail.com>,
Andy Whitcroft <apw@canonical.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] checkpatch: enable MAINTAINERS warning only for --strict,--subjective
Date: Wed, 17 Dec 2014 09:26:27 -0800 [thread overview]
Message-ID: <1418837187.14140.22.camel@perches.com> (raw)
In-Reply-To: <CAJiQ=7AxGdByudruUQtHMq-SNfmumPXP7EDzo-o2QyXWrMxv6A@mail.gmail.com>
On Wed, 2014-12-17 at 07:53 -0800, Kevin Cernekee wrote:
> On Wed, Dec 17, 2014 at 1:27 AM, Joe Perches <joe@perches.com> wrote:
> > On Tue, 2014-12-16 at 23:35 -0800, Brian Norris wrote:
> >> The rule which delivers this warning is very prone to errors:
> >> "added, moved or deleted file(s), does MAINTAINERS need updating?"
> >> so it should not be enabled by default.
> >
> > I don't think so.
> >
> > It's _far_ more common for people to forget to
> > update MAINTAINERS so I think it's quite useful
> > even if it's slightly noisy.
>
> In a recent submission I saw a bunch of these warnings too, even
> though I had already added MAINTAINERS entries.
>
> If this is just a friendly reminder ("hey, please double-check X
> before you send") rather than an indication that a suspected problem
> was detected in the patch, perhaps it would be better if it lived in
> Documentation/SubmitChecklist?
An entry might help.
Submit a patch to SubmitChecklist and see if the
overall MAINTAINERS patterns error rate changes
over a few release cycles.
Another thing that might help you not see these
by creating a .checkpatch.conf file and adding:
"--ignore=FILE_PATH_CHANGES"
next prev parent reply other threads:[~2014-12-17 17:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 7:35 [PATCH] checkpatch: enable MAINTAINERS warning only for --strict,--subjective Brian Norris
2014-12-17 9:27 ` Joe Perches
2014-12-17 15:53 ` Kevin Cernekee
2014-12-17 17:26 ` Joe Perches [this message]
2014-12-18 20:12 ` [PATCH] checkpatch: Fix MAINTAINERS search pattern Derek Chickles
2014-12-18 21:17 ` Joe Perches
2014-12-19 2:34 ` Chickles, Derek
2014-12-19 3:57 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418837187.14140.22.camel@perches.com \
--to=realty@perches.com \
--cc=apw@canonical.com \
--cc=cernekee@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.