From: Joe Perches <joe@perches.com>
To: "Chickles, Derek" <Derek.Chickles@caviumnetworks.com>
Cc: "apw@canonical.com" <apw@canonical.com>,
"computersforpeace@gmail.com" <computersforpeace@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"cernekee@gmail.com" <cernekee@gmail.com>
Subject: Re: [PATCH] checkpatch: Fix MAINTAINERS search pattern
Date: Thu, 18 Dec 2014 19:57:53 -0800 [thread overview]
Message-ID: <1418961473.25129.3.camel@perches.com> (raw)
In-Reply-To: <BLUPR07MB4845BEE1160E5945E113E8AFE6B0@BLUPR07MB484.namprd07.prod.outlook.com>
On Fri, 2014-12-19 at 02:34 +0000, Chickles, Derek wrote:
> > On Thu, 2014-12-18 at 12:12 -0800, Derek Chickles wrote:
> > > This fixes the check that was supposed to prevent the MAINTAINERS
> > > warning from appearing when you run checkpatch.pl on a patch that
> > > includes new files/directories and an updated MAINTAINERS file.
> >
> > This suggested patch doesn't work.
> >
> > $realfile isn't set until the file shows up
> > in the patch itself.
> >
> > The current test looks at the changelog
> > before the files are modified and is correct.
> >
>
> Thanks, you're right. My mistake was trying to run checkpatch.pl on a diff.
> My patch works on diffs while the original code does not. This is by chance
> really because MAINTAINERS is early in the patch. Using format-patch on
> something that is committed is clearly the correct solution.
Both tests can be used.
Send another patch without deleting the first test
and that'd be good to me.
prev parent reply other threads:[~2014-12-19 3:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-17 7:35 [PATCH] checkpatch: enable MAINTAINERS warning only for --strict,--subjective Brian Norris
2014-12-17 9:27 ` Joe Perches
2014-12-17 15:53 ` Kevin Cernekee
2014-12-17 17:26 ` Joe Perches
2014-12-18 20:12 ` [PATCH] checkpatch: Fix MAINTAINERS search pattern Derek Chickles
2014-12-18 21:17 ` Joe Perches
2014-12-19 2:34 ` Chickles, Derek
2014-12-19 3:57 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418961473.25129.3.camel@perches.com \
--to=joe@perches.com \
--cc=Derek.Chickles@caviumnetworks.com \
--cc=apw@canonical.com \
--cc=cernekee@gmail.com \
--cc=computersforpeace@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.