From: Joe Perches <joe@perches.com>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: Nagalakshmi Nandigama <nagalakshmi.nandigama@avagotech.com>,
Praveen Krishnamoorthy <praveen.krishnamoorthy@avagotech.com>,
Sreekanth Reddy <sreekanth.reddy@avagotech.com>,
Abhijit Mahajan <abhijit.mahajan@avagotech.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
MPT-FusionLinux.pdl@avagotech.com, linux-scsi@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] [SCSI] mpt2sas: Remove unnecessary use of a boolean variable
Date: Fri, 19 Dec 2014 12:26:31 +0000 [thread overview]
Message-ID: <1418991991.25129.10.camel@perches.com> (raw)
In-Reply-To: <20141219111345.GA19938@sloth>
On Fri, 2014-12-19 at 12:13 +0100, Quentin Lambert wrote:
[]
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
[]
> @@ -1414,12 +1414,8 @@ _base_enable_msix(struct MPT2SAS_ADAPTER *ioc)
> struct msix_entry *entries, *a;
> int r;
> int i;
> - u8 try_msix = 0;
>
> - if (msix_disable = -1 || msix_disable = 0)
> - try_msix = 1;
> -
> - if (!try_msix)
> + if (msix_disable != -1 || msix_disable != 0)
> goto try_ioapic;
logic not the same.
Now needs && not ||
WARNING: multiple messages have this Message-ID (diff)
From: Joe Perches <joe@perches.com>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: Nagalakshmi Nandigama <nagalakshmi.nandigama@avagotech.com>,
Praveen Krishnamoorthy <praveen.krishnamoorthy@avagotech.com>,
Sreekanth Reddy <sreekanth.reddy@avagotech.com>,
Abhijit Mahajan <abhijit.mahajan@avagotech.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
MPT-FusionLinux.pdl@avagotech.com, linux-scsi@vger.kernel.org,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] [SCSI] mpt2sas: Remove unnecessary use of a boolean variable
Date: Fri, 19 Dec 2014 04:26:31 -0800 [thread overview]
Message-ID: <1418991991.25129.10.camel@perches.com> (raw)
In-Reply-To: <20141219111345.GA19938@sloth>
On Fri, 2014-12-19 at 12:13 +0100, Quentin Lambert wrote:
[]
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_base.c b/drivers/scsi/mpt2sas/mpt2sas_base.c
[]
> @@ -1414,12 +1414,8 @@ _base_enable_msix(struct MPT2SAS_ADAPTER *ioc)
> struct msix_entry *entries, *a;
> int r;
> int i;
> - u8 try_msix = 0;
>
> - if (msix_disable == -1 || msix_disable == 0)
> - try_msix = 1;
> -
> - if (!try_msix)
> + if (msix_disable != -1 || msix_disable != 0)
> goto try_ioapic;
logic not the same.
Now needs && not ||
next prev parent reply other threads:[~2014-12-19 12:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 11:13 [PATCH 3/3] [SCSI] mpt2sas: Remove unnecessary use of a boolean variable Quentin Lambert
2014-12-19 11:13 ` Quentin Lambert
2014-12-19 12:26 ` Joe Perches [this message]
2014-12-19 12:26 ` Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1418991991.25129.10.camel@perches.com \
--to=joe@perches.com \
--cc=JBottomley@parallels.com \
--cc=MPT-FusionLinux.pdl@avagotech.com \
--cc=abhijit.mahajan@avagotech.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=lambert.quentin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nagalakshmi.nandigama@avagotech.com \
--cc=praveen.krishnamoorthy@avagotech.com \
--cc=sreekanth.reddy@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.