From: Prashant Sreedharan <prashant@broadcom.com>
To: <rajatxjain@gmail.com>
Cc: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Nils Holland <nholland@tisys.org>,
Michael Chan <mchan@broadcom.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Rafael Wysocki <rjw@rjwysocki.net>
Subject: Re: [bisected] tg3 broken in 3.18.0?
Date: Fri, 19 Dec 2014 10:53:48 -0800 [thread overview]
Message-ID: <1419015228.27773.3.camel@prashant> (raw)
In-Reply-To: <CAA93t1qOUZEmJEcuUNtkDS0M_pafb_1s==9Yqm9-+-+OmJmVuQ@mail.gmail.com>
On Fri, 2014-12-19 at 10:24 -0800, Rajat Jain wrote:
> One of the reasons to replace the condition (*l == 0xffff0001) with
> (*l & 0xffff) == 0x0001) was that some devices apparently returned
> 0001 for device id to indicate CRS, but returned actual vendor id in
> the vendor ID field (hence the need to ignore vendor field).
>
> Are we saying that the tg3 device returns 0x0001 for the device ID and
> yet expects it to be treated as a good value (not CRS)?
>
No it should not be treated as a good value, this commit has
surfaced/exposed a problem in 5722 chipset which was previously masked.
next prev parent reply other threads:[~2014-12-19 19:09 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-13 21:02 [bisected] tg3 broken in 3.18.0? Nils Holland
2014-12-15 15:06 ` Marcelo Ricardo Leitner
2014-12-16 16:04 ` Rajat Jain
2014-12-16 16:20 ` Bjorn Helgaas
2014-12-16 17:15 ` Michael Chan
2014-12-16 17:59 ` Marcelo Ricardo Leitner
2014-12-16 19:54 ` Michael Chan
2014-12-16 20:02 ` Marcelo Ricardo Leitner
2014-12-18 19:15 ` Bjorn Helgaas
2014-12-18 19:28 ` Prashant Sreedharan
2014-12-18 20:09 ` Marcelo Ricardo Leitner
2014-12-18 20:33 ` Marcelo Ricardo Leitner
2014-12-18 20:26 ` Nils Holland
2014-12-19 2:10 ` Prashant Sreedharan
2014-12-19 17:09 ` Bjorn Helgaas
2014-12-19 17:16 ` Marcelo Ricardo Leitner
2014-12-19 18:24 ` Rajat Jain
2014-12-19 18:53 ` Prashant Sreedharan [this message]
2014-12-19 19:37 ` Rajat Jain
2014-12-16 18:00 ` Marcelo Ricardo Leitner
2014-12-16 20:38 ` Nils Holland
2014-12-16 0:31 ` Bjorn Helgaas
-- strict thread matches above, loose matches on Subject: below --
2014-12-10 23:06 Nils Holland
2014-12-11 16:45 ` Marcelo Ricardo Leitner
2014-12-12 14:50 ` Jonathan Bither
2014-12-12 20:31 ` Nils Holland
2014-12-13 1:14 ` [bisected] " Nils Holland
2014-12-13 1:18 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419015228.27773.3.camel@prashant \
--to=prashant@broadcom.com \
--cc=bhelgaas@google.com \
--cc=davem@davemloft.net \
--cc=linux-pci@vger.kernel.org \
--cc=marcelo.leitner@gmail.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=nholland@tisys.org \
--cc=rajatxjain@gmail.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.