From: Paul Bolle <pebolle@tiscali.nl>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Valentin Rothberg <valentinrothberg@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Minchan Kim <minchan@kernel.org>, Dave Hansen <dave@sr71.net>,
Michal Nazarewicz <mina86@mina86.com>,
Jungsoo Son <jungsoo.son@lge.com>, Ingo Molnar <mingo@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/8] mm/debug-pagealloc: prepare boottime configurable on/off
Date: Mon, 22 Dec 2014 10:10:42 +0100 [thread overview]
Message-ID: <1419239442.30945.5.camel@x220> (raw)
In-Reply-To: <20141128073524.GC11802@js1304-P5Q-DELUXE>
Hi Joonsoo,
On Fri, 2014-11-28 at 16:35 +0900, Joonsoo Kim wrote:
> Hello, Paul.
>
> Thanks for spotting this.
> I attach the patch. :)
>
> Andrew,
> Could you kindly fold this into the patch in your tree?
>
> Thanks.
>
> ------------------->8---------------
> From a33c480160904cc93333807a448960151ac4c534 Mon Sep 17 00:00:00 2001
> From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Date: Fri, 28 Nov 2014 16:05:32 +0900
> Subject: [PATCH] mm/debug_pagealloc: remove obsolete Kconfig options
>
> These are obsolete since commit "mm/debug-pagealloc: prepare boottime
> configurable" is merged. So, remove it.
>
> [pebolle@tiscali.nl: find obsolete Kconfig options]
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> ---
> mm/Kconfig.debug | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug
> index 56badfc..957d3da 100644
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug
> @@ -14,7 +14,6 @@ config DEBUG_PAGEALLOC
> depends on !KMEMCHECK
> select PAGE_EXTENSION
> select PAGE_POISONING if !ARCH_SUPPORTS_DEBUG_PAGEALLOC
> - select PAGE_GUARD if ARCH_SUPPORTS_DEBUG_PAGEALLOC
> ---help---
> Unmap pages from the kernel linear mapping after free_pages().
> This results in a large slowdown, but helps to find certain types
> @@ -27,13 +26,5 @@ config DEBUG_PAGEALLOC
> that would result in incorrect warnings of memory corruption after
> a resume because free pages are not saved to the suspend image.
>
> -config WANT_PAGE_DEBUG_FLAGS
> - bool
> -
> config PAGE_POISONING
> bool
> - select WANT_PAGE_DEBUG_FLAGS
> -
> -config PAGE_GUARD
> - bool
> - select WANT_PAGE_DEBUG_FLAGS
This patch didn't make it into v3.19-rc1. And I think it never entered
linux-next. Did this fall through the cracks or was there some other
issue with this patch?
Thanks,
Paul Bolle
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Bolle <pebolle@tiscali.nl>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Valentin Rothberg <valentinrothberg@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Mel Gorman <mgorman@suse.de>,
Johannes Weiner <hannes@cmpxchg.org>,
Minchan Kim <minchan@kernel.org>, Dave Hansen <dave@sr71.net>,
Michal Nazarewicz <mina86@mina86.com>,
Jungsoo Son <jungsoo.son@lge.com>, Ingo Molnar <mingo@redhat.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/8] mm/debug-pagealloc: prepare boottime configurable on/off
Date: Mon, 22 Dec 2014 10:10:42 +0100 [thread overview]
Message-ID: <1419239442.30945.5.camel@x220> (raw)
In-Reply-To: <20141128073524.GC11802@js1304-P5Q-DELUXE>
Hi Joonsoo,
On Fri, 2014-11-28 at 16:35 +0900, Joonsoo Kim wrote:
> Hello, Paul.
>
> Thanks for spotting this.
> I attach the patch. :)
>
> Andrew,
> Could you kindly fold this into the patch in your tree?
>
> Thanks.
>
> ------------------->8---------------
> From a33c480160904cc93333807a448960151ac4c534 Mon Sep 17 00:00:00 2001
> From: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> Date: Fri, 28 Nov 2014 16:05:32 +0900
> Subject: [PATCH] mm/debug_pagealloc: remove obsolete Kconfig options
>
> These are obsolete since commit "mm/debug-pagealloc: prepare boottime
> configurable" is merged. So, remove it.
>
> [pebolle@tiscali.nl: find obsolete Kconfig options]
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
> ---
> mm/Kconfig.debug | 9 ---------
> 1 file changed, 9 deletions(-)
>
> diff --git a/mm/Kconfig.debug b/mm/Kconfig.debug
> index 56badfc..957d3da 100644
> --- a/mm/Kconfig.debug
> +++ b/mm/Kconfig.debug
> @@ -14,7 +14,6 @@ config DEBUG_PAGEALLOC
> depends on !KMEMCHECK
> select PAGE_EXTENSION
> select PAGE_POISONING if !ARCH_SUPPORTS_DEBUG_PAGEALLOC
> - select PAGE_GUARD if ARCH_SUPPORTS_DEBUG_PAGEALLOC
> ---help---
> Unmap pages from the kernel linear mapping after free_pages().
> This results in a large slowdown, but helps to find certain types
> @@ -27,13 +26,5 @@ config DEBUG_PAGEALLOC
> that would result in incorrect warnings of memory corruption after
> a resume because free pages are not saved to the suspend image.
>
> -config WANT_PAGE_DEBUG_FLAGS
> - bool
> -
> config PAGE_POISONING
> bool
> - select WANT_PAGE_DEBUG_FLAGS
> -
> -config PAGE_GUARD
> - bool
> - select WANT_PAGE_DEBUG_FLAGS
This patch didn't make it into v3.19-rc1. And I think it never entered
linux-next. Did this fall through the cracks or was there some other
issue with this patch?
Thanks,
Paul Bolle
next prev parent reply other threads:[~2014-12-22 9:10 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 8:15 [PATCH v3 0/8] Resurrect and use struct page extension for some debugging features Joonsoo Kim
2014-11-24 8:15 ` Joonsoo Kim
2014-11-24 8:15 ` [PATCH v3 1/8] mm/page_ext: resurrect struct page extending code for debugging Joonsoo Kim
2014-11-24 8:15 ` Joonsoo Kim
2014-12-03 1:18 ` Joonsoo Kim
2014-12-03 1:18 ` Joonsoo Kim
2014-11-24 8:15 ` [PATCH v3 2/8] mm/debug-pagealloc: prepare boottime configurable on/off Joonsoo Kim
2014-11-24 8:15 ` Joonsoo Kim
2014-11-27 12:35 ` Paul Bolle
2014-11-27 12:35 ` Paul Bolle
2014-11-28 7:35 ` Joonsoo Kim
2014-11-28 7:35 ` Joonsoo Kim
2014-12-22 9:10 ` Paul Bolle [this message]
2014-12-22 9:10 ` Paul Bolle
2014-12-23 4:56 ` Joonsoo Kim
2014-12-23 4:56 ` Joonsoo Kim
2014-11-24 8:15 ` [PATCH v3 3/8] mm/debug-pagealloc: make debug-pagealloc boottime configurable Joonsoo Kim
2014-11-24 8:15 ` Joonsoo Kim
2014-11-24 22:55 ` Andrew Morton
2014-11-24 22:55 ` Andrew Morton
2014-11-24 23:42 ` Joonsoo Kim
2014-11-24 23:42 ` Joonsoo Kim
2014-11-26 20:49 ` Andrew Morton
2014-11-26 20:49 ` Andrew Morton
2014-11-27 5:10 ` Joonsoo Kim
2014-11-27 5:10 ` Joonsoo Kim
2014-11-24 8:15 ` [PATCH v3 4/8] mm/nommu: use alloc_pages_exact() rather than it's own implementation Joonsoo Kim
2014-11-24 8:15 ` Joonsoo Kim
2014-11-24 8:15 ` [PATCH v3 5/8] stacktrace: introduce snprint_stack_trace for buffer output Joonsoo Kim
2014-11-24 8:15 ` Joonsoo Kim
2014-11-24 22:57 ` Andrew Morton
2014-11-24 22:57 ` Andrew Morton
2014-11-24 23:46 ` Joonsoo Kim
2014-11-24 23:46 ` Joonsoo Kim
2014-11-24 8:15 ` [PATCH v3 6/8] mm/page_owner: keep track of page owners Joonsoo Kim
2014-11-24 8:15 ` Joonsoo Kim
2014-12-03 13:24 ` Chintan Pandya
2014-12-03 13:24 ` Chintan Pandya
2014-12-04 6:56 ` Joonsoo Kim
2014-12-04 6:56 ` Joonsoo Kim
2014-11-24 8:15 ` [PATCH v3 7/8] mm/page_owner: correct owner information for early allocated pages Joonsoo Kim
2014-11-24 8:15 ` Joonsoo Kim
2014-11-24 8:15 ` [PATCH v3 8/8] Documentation: add new page_owner document Joonsoo Kim
2014-11-24 8:15 ` Joonsoo Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419239442.30945.5.camel@x220 \
--to=pebolle@tiscali.nl \
--cc=akpm@linux-foundation.org \
--cc=dave@sr71.net \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=jungsoo.son@lge.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@suse.de \
--cc=mina86@mina86.com \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=valentinrothberg@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.