From: Joe Perches <joe@perches.com>
To: Masahiro Yamada <yamada.m@jp.panasonic.com>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
Eric Miao <eric.y.miao@gmail.com>,
Haojian Zhuang <haojian.zhuang@gmail.com>,
Russell King <linux@arm.linux.org.uk>,
Daniel Mack <daniel@zonque.org>,
Robert Jarzmik <robert.jarzmik@free.fr>,
Linus Walleij <linus.walleij@linaro.org>,
Steven Rostedt <rostedt@goodmis.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Michal Nazarewicz <mina86@mina86.com>,
Ingo Molnar <mingo@kernel.org>,
Peter Zijlstra <peterz@infradead.org>,
Daniel Borkmann <dborkman@redhat.com>,
Alex Elder <alex.elder@linaro.org>,
Daniel Walter <dwalter@google.com>,
Peter Hurley <peter@hurleysoftware.com>,
linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] linux/kernel.h: merge ARRAY_AND_SIZE defines
Date: Tue, 23 Dec 2014 21:44:39 -0800 [thread overview]
Message-ID: <1419399879.6157.9.camel@perches.com> (raw)
In-Reply-To: <1419399496-5955-1-git-send-email-yamada.m@jp.panasonic.com>
On Wed, 2014-12-24 at 14:38 +0900, Masahiro Yamada wrote:
> ARRAY_AND_SIZE is a useful macro. Its definition is already
> duplicated in some headers. Move it to include/linux/kernel.h.
I think it's not a good/useful macro and
would prefer the uses expanded instead.
The uses of ARRAY_AND_SIZE in structure
definitions aren't particularly bad, but the
ARRAY_AND_SIZE uses that hide the number of
arguments in a function I think are suboptimal.
WARNING: multiple messages have this Message-ID (diff)
From: joe@perches.com (Joe Perches)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] linux/kernel.h: merge ARRAY_AND_SIZE defines
Date: Tue, 23 Dec 2014 21:44:39 -0800 [thread overview]
Message-ID: <1419399879.6157.9.camel@perches.com> (raw)
In-Reply-To: <1419399496-5955-1-git-send-email-yamada.m@jp.panasonic.com>
On Wed, 2014-12-24 at 14:38 +0900, Masahiro Yamada wrote:
> ARRAY_AND_SIZE is a useful macro. Its definition is already
> duplicated in some headers. Move it to include/linux/kernel.h.
I think it's not a good/useful macro and
would prefer the uses expanded instead.
The uses of ARRAY_AND_SIZE in structure
definitions aren't particularly bad, but the
ARRAY_AND_SIZE uses that hide the number of
arguments in a function I think are suboptimal.
next prev parent reply other threads:[~2014-12-24 5:44 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-24 5:38 [PATCH] linux/kernel.h: merge ARRAY_AND_SIZE defines Masahiro Yamada
2014-12-24 5:38 ` Masahiro Yamada
2014-12-24 5:44 ` Joe Perches [this message]
2014-12-24 5:44 ` Joe Perches
2014-12-24 14:02 ` Alex Elder
2014-12-24 14:02 ` Alex Elder
2015-01-04 23:38 ` Rusty Russell
2015-01-04 23:38 ` Rusty Russell
2015-01-04 23:38 ` Rusty Russell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1419399879.6157.9.camel@perches.com \
--to=joe@perches.com \
--cc=akpm@linux-foundation.org \
--cc=alex.elder@linaro.org \
--cc=daniel@zonque.org \
--cc=dborkman@redhat.com \
--cc=dwalter@google.com \
--cc=eric.y.miao@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mina86@mina86.com \
--cc=mingo@kernel.org \
--cc=peter@hurleysoftware.com \
--cc=peterz@infradead.org \
--cc=robert.jarzmik@free.fr \
--cc=rostedt@goodmis.org \
--cc=rusty@rustcorp.com.au \
--cc=yamada.m@jp.panasonic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.