[PATCH] acer-wmi: add 3 laptops to video backlight vendor mode quirk table

[PATCH] acer-wmi: add 3 laptops to video backlight vendor mode quirk table

[Lee, Chun-Yi]

Acer Extensa 5235, TravelMate 5760 and Aspire 5750 laptop have broken _BCM
implemenation, the AML code wrote value to EC register but firmware didn't
change brighenss.

Fortunately, the brightness control works on those machines with vendor mode.
So, add this machine to video backlight vendor mode quirk table.

Reference: bko#36322
        https://bugzilla.kernel.org/show_bug.cgi?id=36322
Reference: bko#42833
        https://bugzilla.kernel.org/show_bug.cgi?id=42833
Reference: bko#42993
        https://bugzilla.kernel.org/show_bug.cgi?id=42993

Cc: Christopher M. Penalver <christopher.penalver@gmx.com>
Cc: Bence Lukacs <lukacs.bence1@gmail.com>
Cc: Joern Heissler <kernelbugs2012@joern.heissler.de>
Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
Cc: Corentin Chary <corentincj@iksaif.net>
Cc: Thomas Renninger <trenn@suse.de>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
 drivers/platform/x86/acer-wmi.c |   24 ++++++++++++++++++++++++
 1 files changed, 24 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index c1a3fd8..ce875dc 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -523,6 +523,30 @@ static const struct dmi_system_id video_vendor_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 4750"),
 		},
 	},
+	{
+		.callback = video_set_backlight_video_vendor,
+		.ident = "Acer Extensa 5235",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Extensa 5235"),
+		},
+	},
+	{
+		.callback = video_set_backlight_video_vendor,
+		.ident = "Acer TravelMate 5760",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 5760"),
+		},
+	},
+	{
+		.callback = video_set_backlight_video_vendor,
+		.ident = "Acer Aspire 5750",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5750"),
+		},
+	},
 	{}
 };
 
-- 
1.6.0.2

Re: [PATCH] acer-wmi: add 3 laptops to video backlight vendor mode quirk table

[Carlos Corbacho]

On Saturday 05 May 2012 20:18:55 Lee, Chun-Yi wrote:
> Acer Extensa 5235, TravelMate 5760 and Aspire 5750 laptop have broken _BCM
> implemenation, the AML code wrote value to EC register but firmware didn't
> change brighenss.
> 
> Fortunately, the brightness control works on those machines with vendor
> mode. So, add this machine to video backlight vendor mode quirk table.

Is there no way we can auto-detect this somehow? Is there something peculiar 
about the broken implementation that we can use to do this detection instead?

-Carlos

Re: [PATCH] acer-wmi: add 3 laptops to video backlight vendor mode quirk table

[joeyli]

於 日，2012-05-06 於 00:09 +0100，Carlos Corbacho 提到：
> On Saturday 05 May 2012 20:18:55 Lee, Chun-Yi wrote:
> > Acer Extensa 5235, TravelMate 5760 and Aspire 5750 laptop have broken _BCM
> > implemenation, the AML code wrote value to EC register but firmware didn't
> > change brighenss.
> > 
> > Fortunately, the brightness control works on those machines with vendor
> > mode. So, add this machine to video backlight vendor mode quirk table.
> 
> Is there no way we can auto-detect this somehow? Is there something peculiar 
> about the broken implementation that we can use to do this detection instead?
> 
> -Carlos
> 

Unfortunately, I didn't see anyway can auto-detect the broken _BCM
implementation.
On those machines, the _BCM method write the brightness value to a EC
register, and, we make sure the value write success but EC didn't change
the brightness level.

_BCM like this:
        Method (_BCM, 1, NotSerialized)
        {  
            Divide (Arg0, 0x0A, Local0, Local1)
            Decrement (Local1)
            Store (Local1, ^^^LPCB.EC0.BRTS)     <=== write to BRTS register


Currently, didn't find good way to know EC doesn't really change the
brightness level.

I think Acer's ODM don't know this issue because on Vista and Windows 7
platform, they changed brightness through WDDM video driver but not
standard acpi method like _BCM. Some ODM only test brightness by human
eyes and they didn't check acpi method should also works.

Microsoft WDDM spec:
 http://msdn.microsoft.com/en-us/windows/hardware/gg487382.aspx

Actually, per WDDM spec, they should keep the standard acpi method works
for backward compatibility to XP or any OS doesn't support WDDM. 

I face to face told to Acer's PM at last year for this issue, and also
told them should keep the standard acpi methods works fine, he said will
check with ODM. But, finally, I didn't get further response from Acer.


Use a quirk table to set those machines to 'acpi_backlight=vendor' mode
is better then use 'acpi_osi=Linux', so, I hope experts can kindly
accept this patch to acer-wmi driver for those _BCM broken machines.


Thanks a lot!
Joey Lee

[PATCH] acer-wmi: add 3 laptops to video backlight vendor mode quirk table

[Lee, Chun-Yi]

Acer Extensa 5235, TravelMate 5760 and Aspire 5750 laptop have broken _BCM
implemenation, the AML code wrote value to EC register but firmware didn't
change brighenss.

Fortunately, the brightness control works on those machines with vendor mode.
So, add this machine to video backlight vendor mode quirk table.

Reference: bko#36322
        https://bugzilla.kernel.org/show_bug.cgi?id=36322
Reference: bko#42833
        https://bugzilla.kernel.org/show_bug.cgi?id=42833
Reference: bko#42993
        https://bugzilla.kernel.org/show_bug.cgi?id=42993

Cc: Christopher M. Penalver <christopher.penalver@gmx.com>
Cc: Bence Lukacs <lukacs.bence1@gmail.com>
Cc: Joern Heissler <kernelbugs2012@joern.heissler.de>
Cc: Carlos Corbacho <carlos@strangeworlds.co.uk>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Dmitry Torokhov <dtor@mail.ru>
Cc: Corentin Chary <corentincj@iksaif.net>
Cc: Thomas Renninger <trenn@suse.de>
Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
---
 drivers/platform/x86/acer-wmi.c |   24 ++++++++++++++++++++++++
 1 files changed, 24 insertions(+), 0 deletions(-)

diff --git a/drivers/platform/x86/acer-wmi.c b/drivers/platform/x86/acer-wmi.c
index c1a3fd8..ce875dc 100644
--- a/drivers/platform/x86/acer-wmi.c
+++ b/drivers/platform/x86/acer-wmi.c
@@ -523,6 +523,30 @@ static const struct dmi_system_id video_vendor_dmi_table[] = {
 			DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 4750"),
 		},
 	},
+	{
+		.callback = video_set_backlight_video_vendor,
+		.ident = "Acer Extensa 5235",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Extensa 5235"),
+		},
+	},
+	{
+		.callback = video_set_backlight_video_vendor,
+		.ident = "Acer TravelMate 5760",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 5760"),
+		},
+	},
+	{
+		.callback = video_set_backlight_video_vendor,
+		.ident = "Acer Aspire 5750",
+		.matches = {
+			DMI_MATCH(DMI_BOARD_VENDOR, "Acer"),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Aspire 5750"),
+		},
+	},
 	{}
 };
 
-- 
1.6.0.2

Re: [PATCH] acer-wmi: add 3 laptops to video backlight vendor mode quirk table

[Matthew Garrett]

Applied, thanks.

-- 
Matthew Garrett | mjg59@srcf.ucam.org