From: Antonio Quartulli <antonio@meshcoding.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, "Martin Hundebøll" <martin@hundeboll.net>,
b.a.t.m.a.n@lists.open-mesh.org,
"Marek Lindner" <mareklindner@neomailbox.ch>,
"Antonio Quartulli" <antonio@meshcoding.com>
Subject: [B.A.T.M.A.N.] [PATCH 3/6] batman-adv: fix lock class for decoding hash in network-coding.c
Date: Tue, 6 Jan 2015 12:10:02 +0100 [thread overview]
Message-ID: <1420542605-28865-4-git-send-email-antonio@meshcoding.com> (raw)
In-Reply-To: <1420542605-28865-1-git-send-email-antonio@meshcoding.com>
From: Martin Hundebøll <martin@hundeboll.net>
batadv_has_set_lock_class() is called with the wrong hash table as first
argument (probably due to a copy-paste error), which leads to false
positives when running with lockdep.
Introduced-by: 612d2b4fe0a1ff2f8389462a6f8be34e54124c05
("batman-adv: network coding - save overheard and tx packets for decoding")
Signed-off-by: Martin Hundebøll <martin@hundeboll.net>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
net/batman-adv/network-coding.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c
index 8d04d17..fab47f1 100644
--- a/net/batman-adv/network-coding.c
+++ b/net/batman-adv/network-coding.c
@@ -133,7 +133,7 @@ int batadv_nc_mesh_init(struct batadv_priv *bat_priv)
if (!bat_priv->nc.decoding_hash)
goto err;
- batadv_hash_set_lock_class(bat_priv->nc.coding_hash,
+ batadv_hash_set_lock_class(bat_priv->nc.decoding_hash,
&batadv_nc_decoding_hash_lock_class_key);
INIT_DELAYED_WORK(&bat_priv->nc.work, batadv_nc_worker);
--
2.2.1
WARNING: multiple messages have this Message-ID (diff)
From: Antonio Quartulli <antonio@meshcoding.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, b.a.t.m.a.n@lists.open-mesh.org,
"Martin Hundebøll" <martin@hundeboll.net>,
"Marek Lindner" <mareklindner@neomailbox.ch>,
"Antonio Quartulli" <antonio@meshcoding.com>
Subject: [PATCH 3/6] batman-adv: fix lock class for decoding hash in network-coding.c
Date: Tue, 6 Jan 2015 12:10:02 +0100 [thread overview]
Message-ID: <1420542605-28865-4-git-send-email-antonio@meshcoding.com> (raw)
In-Reply-To: <1420542605-28865-1-git-send-email-antonio@meshcoding.com>
From: Martin Hundebøll <martin@hundeboll.net>
batadv_has_set_lock_class() is called with the wrong hash table as first
argument (probably due to a copy-paste error), which leads to false
positives when running with lockdep.
Introduced-by: 612d2b4fe0a1ff2f8389462a6f8be34e54124c05
("batman-adv: network coding - save overheard and tx packets for decoding")
Signed-off-by: Martin Hundebøll <martin@hundeboll.net>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <antonio@meshcoding.com>
---
net/batman-adv/network-coding.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/batman-adv/network-coding.c b/net/batman-adv/network-coding.c
index 8d04d17..fab47f1 100644
--- a/net/batman-adv/network-coding.c
+++ b/net/batman-adv/network-coding.c
@@ -133,7 +133,7 @@ int batadv_nc_mesh_init(struct batadv_priv *bat_priv)
if (!bat_priv->nc.decoding_hash)
goto err;
- batadv_hash_set_lock_class(bat_priv->nc.coding_hash,
+ batadv_hash_set_lock_class(bat_priv->nc.decoding_hash,
&batadv_nc_decoding_hash_lock_class_key);
INIT_DELAYED_WORK(&bat_priv->nc.work, batadv_nc_worker);
--
2.2.1
next prev parent reply other threads:[~2015-01-06 11:10 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-06 11:09 [B.A.T.M.A.N.] pull request [net]: batman-adv 20150106 Antonio Quartulli
2015-01-06 11:09 ` Antonio Quartulli
2015-01-06 11:10 ` [B.A.T.M.A.N.] [PATCH 1/6] batman-adv: fix and simplify condition when bonding should be used Antonio Quartulli
2015-01-06 11:10 ` Antonio Quartulli
2015-01-06 11:10 ` [B.A.T.M.A.N.] [PATCH 2/6] batman-adv: fix delayed foreign originator recognition Antonio Quartulli
2015-01-06 11:10 ` Antonio Quartulli
2015-01-06 11:10 ` Antonio Quartulli [this message]
2015-01-06 11:10 ` [PATCH 3/6] batman-adv: fix lock class for decoding hash in network-coding.c Antonio Quartulli
2015-01-06 11:10 ` [B.A.T.M.A.N.] [PATCH 4/6] batman-adv: fix counter for multicast supporting nodes Antonio Quartulli
2015-01-06 11:10 ` Antonio Quartulli
2015-01-06 11:10 ` [B.A.T.M.A.N.] [PATCH 5/6] batman-adv: fix multicast counter when purging originators Antonio Quartulli
2015-01-06 11:10 ` Antonio Quartulli
2015-01-06 11:10 ` [B.A.T.M.A.N.] [PATCH 6/6] batman-adv: fix potential TT client + orig-node memory leak Antonio Quartulli
2015-01-06 11:10 ` Antonio Quartulli
2015-01-06 19:25 ` [B.A.T.M.A.N.] pull request [net]: batman-adv 20150106 David Miller
2015-01-06 19:25 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1420542605-28865-4-git-send-email-antonio@meshcoding.com \
--to=antonio@meshcoding.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=mareklindner@neomailbox.ch \
--cc=martin@hundeboll.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.