* check-headers error in staging
@ 2015-01-07 12:37 Olaf Hering
2015-01-07 12:45 ` Andrew Cooper
0 siblings, 1 reply; 6+ messages in thread
From: Olaf Hering @ 2015-01-07 12:37 UTC (permalink / raw)
To: xen-devel
After upgrade to current staging, my test packages fail to build:
[ 289s] + make -j4 -k -C tools/include/xen-foreign
[ 289s] make: Entering directory `/usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign'
[ 289s] python mkheader.py arm32 arm32.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/public/arch-arm.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/public/xen.h
[ 289s] python mkheader.py arm64 arm64.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/public/arch-arm.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/public/xen.h
[ 289s] python mkheader.py x86_32 x86_32.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/public/arch-x86/xen-x86_32.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/
[ 289s] python mkheader.py x86_64 x86_64.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/public/arch-x86/xen-x86_64.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/
[ 289s] python mkchecker.py checker.c arm32 arm64 x86_32 x86_64
[ 289s] gcc -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -Wdeclaration-after-statement -o checker checker.c
[ 289s] ./checker > tmp.size
[ 289s] diff -u reference.size tmp.size
[ 289s] --- reference.size 2015-01-07 10:28:57.000000000 +0000
[ 289s] +++ tmp.size 2015-01-07 12:28:33.564911299 +0000
[ 289s] @@ -9,6 +9,6 @@
[ 289s] arch_vcpu_info | 0 0 24 16
[ 289s] vcpu_time_info | 32 32 32 32
[ 289s] vcpu_info | 48 48 64 64
[ 289s] -arch_shared_info | 0 0 268 280
[ 289s] -shared_info | 1088 1088 2584 3368
[ 289s] +arch_shared_info | 0 0 24 48
[ 289s] +shared_info | 1088 1088 2340 3136
[ 289s]
[ 289s] make: *** [check-headers] Error 1
this was the last successful build:
xen_hg_changeset Mon Dec 15 17:40:12 2014 +0000 hg: 30046:cefc36150538
this build fails:
xen_hg_changeset Wed Jan 07 11:28:57 2015 +0100 hg: 30084:88d114af72d8
So it looks like something between git commites dcd8486..dd94cac causes this failure.
Olaf
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: check-headers error in staging
2015-01-07 12:37 check-headers error in staging Olaf Hering
@ 2015-01-07 12:45 ` Andrew Cooper
2015-01-07 13:05 ` Jan Beulich
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cooper @ 2015-01-07 12:45 UTC (permalink / raw)
To: Olaf Hering, xen-devel
On 07/01/15 12:37, Olaf Hering wrote:
> After upgrade to current staging, my test packages fail to build:
>
> [ 289s] + make -j4 -k -C tools/include/xen-foreign
> [ 289s] make: Entering directory `/usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign'
> [ 289s] python mkheader.py arm32 arm32.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/public/arch-arm.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/public/xen.h
> [ 289s] python mkheader.py arm64 arm64.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/public/arch-arm.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/public/xen.h
> [ 289s] python mkheader.py x86_32 x86_32.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/public/arch-x86/xen-x86_32.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/
> [ 289s] python mkheader.py x86_64 x86_64.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/public/arch-x86/xen-x86_64.h /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../../../xen/include/
> [ 289s] python mkchecker.py checker.c arm32 arm64 x86_32 x86_64
> [ 289s] gcc -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer -fno-strict-aliasing -Wdeclaration-after-statement -o checker checker.c
> [ 289s] ./checker > tmp.size
> [ 289s] diff -u reference.size tmp.size
> [ 289s] --- reference.size 2015-01-07 10:28:57.000000000 +0000
> [ 289s] +++ tmp.size 2015-01-07 12:28:33.564911299 +0000
> [ 289s] @@ -9,6 +9,6 @@
> [ 289s] arch_vcpu_info | 0 0 24 16
> [ 289s] vcpu_time_info | 32 32 32 32
> [ 289s] vcpu_info | 48 48 64 64
> [ 289s] -arch_shared_info | 0 0 268 280
> [ 289s] -shared_info | 1088 1088 2584 3368
> [ 289s] +arch_shared_info | 0 0 24 48
> [ 289s] +shared_info | 1088 1088 2340 3136
> [ 289s]
> [ 289s] make: *** [check-headers] Error 1
>
>
> this was the last successful build:
> xen_hg_changeset Mon Dec 15 17:40:12 2014 +0000 hg: 30046:cefc36150538
>
> this build fails:
> xen_hg_changeset Wed Jan 07 11:28:57 2015 +0100 hg: 30084:88d114af72d8
>
>
> So it looks like something between git commites dcd8486..dd94cac causes this failure.
It will be c/s dac6d3b1a "expand x86 arch_shared_info to support linear
p2m list"
There is a shrink to the size of arch_shared_info, but was argued and
accepted as safe to do.
~Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: check-headers error in staging
2015-01-07 12:45 ` Andrew Cooper
@ 2015-01-07 13:05 ` Jan Beulich
2015-01-07 13:36 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Jan Beulich @ 2015-01-07 13:05 UTC (permalink / raw)
To: Olaf Hering, Andrew Cooper, Juergen Gross; +Cc: xen-devel
>>> On 07.01.15 at 13:45, <andrew.cooper3@citrix.com> wrote:
> On 07/01/15 12:37, Olaf Hering wrote:
>> After upgrade to current staging, my test packages fail to build:
>>
>> [ 289s] + make -j4 -k -C tools/include/xen-foreign
>> [ 289s] make: Entering directory
> `/usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign'
>> [ 289s] python mkheader.py arm32 arm32.h
> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> ./../xen/include/public/arch-arm.h
> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/..
> /../../xen/include/public/xen.h
>> [ 289s] python mkheader.py arm64 arm64.h
> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> ./../xen/include/public/arch-arm.h
> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/..
> /../../xen/include/public/xen.h
>> [ 289s] python mkheader.py x86_32 x86_32.h
> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> ./../xen/include/public/arch-x86/xen-x86_32.h
> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> ./../xen/include/
>> [ 289s] python mkheader.py x86_64 x86_64.h
> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> ./../xen/include/public/arch-x86/xen-x86_64.h
> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> ./../xen/include/
>> [ 289s] python mkchecker.py checker.c arm32 arm64 x86_32 x86_64
>> [ 289s] gcc -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer
> -fno-strict-aliasing -Wdeclaration-after-statement -o checker checker.c
>> [ 289s] ./checker > tmp.size
>> [ 289s] diff -u reference.size tmp.size
>> [ 289s] --- reference.size 2015-01-07 10:28:57.000000000 +0000
>> [ 289s] +++ tmp.size 2015-01-07 12:28:33.564911299 +0000
>> [ 289s] @@ -9,6 +9,6 @@
>> [ 289s] arch_vcpu_info | 0 0 24 16
>> [ 289s] vcpu_time_info | 32 32 32 32
>> [ 289s] vcpu_info | 48 48 64 64
>> [ 289s] -arch_shared_info | 0 0 268 280
>> [ 289s] -shared_info | 1088 1088 2584 3368
>> [ 289s] +arch_shared_info | 0 0 24 48
>> [ 289s] +shared_info | 1088 1088 2340 3136
>> [ 289s]
>> [ 289s] make: *** [check-headers] Error 1
>>
>>
>> this was the last successful build:
>> xen_hg_changeset Mon Dec 15 17:40:12 2014 +0000 hg: 30046:cefc36150538
>>
>> this build fails:
>> xen_hg_changeset Wed Jan 07 11:28:57 2015 +0100 hg: 30084:88d114af72d8
>>
>>
>> So it looks like something between git commites dcd8486..dd94cac causes this
> failure.
>
> It will be c/s dac6d3b1a "expand x86 arch_shared_info to support linear
> p2m list"
>
> There is a shrink to the size of arch_shared_info, but was argued and
> accepted as safe to do.
So it looks like I should revert that one then, as it'll cause an
unconditional build failure in the tools part of the build afaict. Plus
it's not clear how to properly express the now variable size to the
checking logic, i.e. resolving the issue may take some time.
Jan
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: check-headers error in staging
2015-01-07 13:05 ` Jan Beulich
@ 2015-01-07 13:36 ` Ian Campbell
2015-01-07 13:39 ` Andrew Cooper
0 siblings, 1 reply; 6+ messages in thread
From: Ian Campbell @ 2015-01-07 13:36 UTC (permalink / raw)
To: Jan Beulich; +Cc: Juergen Gross, Andrew Cooper, Olaf Hering, xen-devel
On Wed, 2015-01-07 at 13:05 +0000, Jan Beulich wrote:
> >>> On 07.01.15 at 13:45, <andrew.cooper3@citrix.com> wrote:
> > On 07/01/15 12:37, Olaf Hering wrote:
> >> After upgrade to current staging, my test packages fail to build:
> >>
> >> [ 289s] + make -j4 -k -C tools/include/xen-foreign
> >> [ 289s] make: Entering directory
> > `/usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign'
> >> [ 289s] python mkheader.py arm32 arm32.h
> > /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> > ./../xen/include/public/arch-arm.h
> > /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/..
> > /../../xen/include/public/xen.h
> >> [ 289s] python mkheader.py arm64 arm64.h
> > /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> > ./../xen/include/public/arch-arm.h
> > /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/..
> > /../../xen/include/public/xen.h
> >> [ 289s] python mkheader.py x86_32 x86_32.h
> > /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> > ./../xen/include/public/arch-x86/xen-x86_32.h
> > /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> > ./../xen/include/
> >> [ 289s] python mkheader.py x86_64 x86_64.h
> > /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> > ./../xen/include/public/arch-x86/xen-x86_64.h
> > /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> > ./../xen/include/
> >> [ 289s] python mkchecker.py checker.c arm32 arm64 x86_32 x86_64
> >> [ 289s] gcc -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer
> > -fno-strict-aliasing -Wdeclaration-after-statement -o checker checker.c
> >> [ 289s] ./checker > tmp.size
> >> [ 289s] diff -u reference.size tmp.size
> >> [ 289s] --- reference.size 2015-01-07 10:28:57.000000000 +0000
> >> [ 289s] +++ tmp.size 2015-01-07 12:28:33.564911299 +0000
> >> [ 289s] @@ -9,6 +9,6 @@
> >> [ 289s] arch_vcpu_info | 0 0 24 16
> >> [ 289s] vcpu_time_info | 32 32 32 32
> >> [ 289s] vcpu_info | 48 48 64 64
> >> [ 289s] -arch_shared_info | 0 0 268 280
> >> [ 289s] -shared_info | 1088 1088 2584 3368
> >> [ 289s] +arch_shared_info | 0 0 24 48
> >> [ 289s] +shared_info | 1088 1088 2340 3136
> >> [ 289s]
> >> [ 289s] make: *** [check-headers] Error 1
> >>
> >>
> >> this was the last successful build:
> >> xen_hg_changeset Mon Dec 15 17:40:12 2014 +0000 hg: 30046:cefc36150538
> >>
> >> this build fails:
> >> xen_hg_changeset Wed Jan 07 11:28:57 2015 +0100 hg: 30084:88d114af72d8
> >>
> >>
> >> So it looks like something between git commites dcd8486..dd94cac causes this
> > failure.
> >
> > It will be c/s dac6d3b1a "expand x86 arch_shared_info to support linear
> > p2m list"
> >
> > There is a shrink to the size of arch_shared_info, but was argued and
> > accepted as safe to do.
>
> So it looks like I should revert that one then, as it'll cause an
> unconditional build failure in the tools part of the build afaict. Plus
> it's not clear how to properly express the now variable size to the
> checking logic, i.e. resolving the issue may take some time.
It's not sufficient just to reinstate the appropriate amount of padding?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: check-headers error in staging
2015-01-07 13:36 ` Ian Campbell
@ 2015-01-07 13:39 ` Andrew Cooper
2015-01-07 13:44 ` Ian Campbell
0 siblings, 1 reply; 6+ messages in thread
From: Andrew Cooper @ 2015-01-07 13:39 UTC (permalink / raw)
To: Ian Campbell, Jan Beulich; +Cc: Juergen Gross, Olaf Hering, xen-devel
On 07/01/15 13:36, Ian Campbell wrote:
> On Wed, 2015-01-07 at 13:05 +0000, Jan Beulich wrote:
>>>>> On 07.01.15 at 13:45, <andrew.cooper3@citrix.com> wrote:
>>> On 07/01/15 12:37, Olaf Hering wrote:
>>>> After upgrade to current staging, my test packages fail to build:
>>>>
>>>> [ 289s] + make -j4 -k -C tools/include/xen-foreign
>>>> [ 289s] make: Entering directory
>>> `/usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign'
>>>> [ 289s] python mkheader.py arm32 arm32.h
>>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
>>> ./../xen/include/public/arch-arm.h
>>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/..
>>> /../../xen/include/public/xen.h
>>>> [ 289s] python mkheader.py arm64 arm64.h
>>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
>>> ./../xen/include/public/arch-arm.h
>>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/..
>>> /../../xen/include/public/xen.h
>>>> [ 289s] python mkheader.py x86_32 x86_32.h
>>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
>>> ./../xen/include/public/arch-x86/xen-x86_32.h
>>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
>>> ./../xen/include/
>>>> [ 289s] python mkheader.py x86_64 x86_64.h
>>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
>>> ./../xen/include/public/arch-x86/xen-x86_64.h
>>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
>>> ./../xen/include/
>>>> [ 289s] python mkchecker.py checker.c arm32 arm64 x86_32 x86_64
>>>> [ 289s] gcc -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer
>>> -fno-strict-aliasing -Wdeclaration-after-statement -o checker checker.c
>>>> [ 289s] ./checker > tmp.size
>>>> [ 289s] diff -u reference.size tmp.size
>>>> [ 289s] --- reference.size 2015-01-07 10:28:57.000000000 +0000
>>>> [ 289s] +++ tmp.size 2015-01-07 12:28:33.564911299 +0000
>>>> [ 289s] @@ -9,6 +9,6 @@
>>>> [ 289s] arch_vcpu_info | 0 0 24 16
>>>> [ 289s] vcpu_time_info | 32 32 32 32
>>>> [ 289s] vcpu_info | 48 48 64 64
>>>> [ 289s] -arch_shared_info | 0 0 268 280
>>>> [ 289s] -shared_info | 1088 1088 2584 3368
>>>> [ 289s] +arch_shared_info | 0 0 24 48
>>>> [ 289s] +shared_info | 1088 1088 2340 3136
>>>> [ 289s]
>>>> [ 289s] make: *** [check-headers] Error 1
>>>>
>>>>
>>>> this was the last successful build:
>>>> xen_hg_changeset Mon Dec 15 17:40:12 2014 +0000 hg: 30046:cefc36150538
>>>>
>>>> this build fails:
>>>> xen_hg_changeset Wed Jan 07 11:28:57 2015 +0100 hg: 30084:88d114af72d8
>>>>
>>>>
>>>> So it looks like something between git commites dcd8486..dd94cac causes this
>>> failure.
>>>
>>> It will be c/s dac6d3b1a "expand x86 arch_shared_info to support linear
>>> p2m list"
>>>
>>> There is a shrink to the size of arch_shared_info, but was argued and
>>> accepted as safe to do.
>> So it looks like I should revert that one then, as it'll cause an
>> unconditional build failure in the tools part of the build afaict. Plus
>> it's not clear how to properly express the now variable size to the
>> checking logic, i.e. resolving the issue may take some time.
> It's not sufficient just to reinstate the appropriate amount of padding?
>
>
The padding was previously in terms of uint64_t's, whereas the new
amount of padding is $N - (3 * unsigned long) which is arch dependent
and awkward to cleanly express. We discussed that, as it was the last
field all zeroes anyway, with the backing page also being zeroed,
dropping the padding in its entirety was safe.
~Andrew
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: check-headers error in staging
2015-01-07 13:39 ` Andrew Cooper
@ 2015-01-07 13:44 ` Ian Campbell
0 siblings, 0 replies; 6+ messages in thread
From: Ian Campbell @ 2015-01-07 13:44 UTC (permalink / raw)
To: Andrew Cooper; +Cc: Juergen Gross, Olaf Hering, Jan Beulich, xen-devel
On Wed, 2015-01-07 at 13:39 +0000, Andrew Cooper wrote:
> On 07/01/15 13:36, Ian Campbell wrote:
> > On Wed, 2015-01-07 at 13:05 +0000, Jan Beulich wrote:
> >>>>> On 07.01.15 at 13:45, <andrew.cooper3@citrix.com> wrote:
> >>> On 07/01/15 12:37, Olaf Hering wrote:
> >>>> After upgrade to current staging, my test packages fail to build:
> >>>>
> >>>> [ 289s] + make -j4 -k -C tools/include/xen-foreign
> >>>> [ 289s] make: Entering directory
> >>> `/usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign'
> >>>> [ 289s] python mkheader.py arm32 arm32.h
> >>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> >>> ./../xen/include/public/arch-arm.h
> >>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/..
> >>> /../../xen/include/public/xen.h
> >>>> [ 289s] python mkheader.py arm64 arm64.h
> >>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> >>> ./../xen/include/public/arch-arm.h
> >>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/..
> >>> /../../xen/include/public/xen.h
> >>>> [ 289s] python mkheader.py x86_32 x86_32.h
> >>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> >>> ./../xen/include/public/arch-x86/xen-x86_32.h
> >>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> >>> ./../xen/include/
> >>>> [ 289s] python mkheader.py x86_64 x86_64.h
> >>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> >>> ./../xen/include/public/arch-x86/xen-x86_64.h
> >>> /usr/src/packages/BUILD/xen-4.6.0.30084/non-dbg/tools/include/xen-foreign/../.
> >>> ./../xen/include/
> >>>> [ 289s] python mkchecker.py checker.c arm32 arm64 x86_32 x86_64
> >>>> [ 289s] gcc -Wall -Werror -Wstrict-prototypes -O2 -fomit-frame-pointer
> >>> -fno-strict-aliasing -Wdeclaration-after-statement -o checker checker.c
> >>>> [ 289s] ./checker > tmp.size
> >>>> [ 289s] diff -u reference.size tmp.size
> >>>> [ 289s] --- reference.size 2015-01-07 10:28:57.000000000 +0000
> >>>> [ 289s] +++ tmp.size 2015-01-07 12:28:33.564911299 +0000
> >>>> [ 289s] @@ -9,6 +9,6 @@
> >>>> [ 289s] arch_vcpu_info | 0 0 24 16
> >>>> [ 289s] vcpu_time_info | 32 32 32 32
> >>>> [ 289s] vcpu_info | 48 48 64 64
> >>>> [ 289s] -arch_shared_info | 0 0 268 280
> >>>> [ 289s] -shared_info | 1088 1088 2584 3368
> >>>> [ 289s] +arch_shared_info | 0 0 24 48
> >>>> [ 289s] +shared_info | 1088 1088 2340 3136
> >>>> [ 289s]
> >>>> [ 289s] make: *** [check-headers] Error 1
> >>>>
> >>>>
> >>>> this was the last successful build:
> >>>> xen_hg_changeset Mon Dec 15 17:40:12 2014 +0000 hg: 30046:cefc36150538
> >>>>
> >>>> this build fails:
> >>>> xen_hg_changeset Wed Jan 07 11:28:57 2015 +0100 hg: 30084:88d114af72d8
> >>>>
> >>>>
> >>>> So it looks like something between git commites dcd8486..dd94cac causes this
> >>> failure.
> >>>
> >>> It will be c/s dac6d3b1a "expand x86 arch_shared_info to support linear
> >>> p2m list"
> >>>
> >>> There is a shrink to the size of arch_shared_info, but was argued and
> >>> accepted as safe to do.
> >> So it looks like I should revert that one then, as it'll cause an
> >> unconditional build failure in the tools part of the build afaict. Plus
> >> it's not clear how to properly express the now variable size to the
> >> checking logic, i.e. resolving the issue may take some time.
> > It's not sufficient just to reinstate the appropriate amount of padding?
> >
> >
>
> The padding was previously in terms of uint64_t's, whereas the new
> amount of padding is $N - (3 * unsigned long) which is arch dependent
> and awkward to cleanly express. We discussed that, as it was the last
> field all zeroes anyway, with the backing page also being zeroed,
> dropping the padding in its entirety was safe.
I think this could be fixed by updating reference.size, it already has
separate columns for x86_32 and x86_64 (I'd originally thought Jan meant
variable as in dynamic, rather than just different between subarches).
In fact they appear to have been different in size before anyway, they
are just differently different now...
Otherwise either ifdef the padding or make the new fields uint64_t,
neither seems all that intolerable.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-01-07 13:44 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-07 12:37 check-headers error in staging Olaf Hering
2015-01-07 12:45 ` Andrew Cooper
2015-01-07 13:05 ` Jan Beulich
2015-01-07 13:36 ` Ian Campbell
2015-01-07 13:39 ` Andrew Cooper
2015-01-07 13:44 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.