Re: [PATCH 01/10] xen/arm: Implement hip04-d01 platform

[Ian Campbell <Ian.Campbell@citrix.com>]

On Mon, 2014-11-03 at 10:11 +0000, Frediano Ziglio wrote:
> Add this new platform to Xen.
> This platform require specific code to initialize CPUs.

What is the "bootwrapper"? Are you running this on real silicon or on an
emulator? Can the platform be made to do PSCI instead?

> +    np_fab = dt_find_compatible_node(NULL, NULL, "hisilicon,hip04-fabric");

Please add a reference to the DT bindings document for these values.

linux/Documentation/devicetree/bindings/arm/hisilicon/hisilicon.txt
seems related but doesn't talk about most of these fields.

> +    msg = "hisilicon,hip04-fabric missing in DT\n";
> +    if ( !np_fab )
> +        goto err;
> +
> +    msg = "failed to get bootwrapper-phys\n";
> +    if ( !dt_property_read_u32(np, "bootwrapper-phys",
> +                               &hip04_boot.bootwrapper_phys) )
> +        goto err;
> +
> +    msg = "failed to get bootwrapper-size\n";
> +    if ( !dt_property_read_u32(np, "bootwrapper-size",
> +                               &hip04_boot.bootwrapper_size) )
> +        goto err;
> +
> +    msg = "failed to get bootwrapper-magic\n";
> +    if ( !dt_property_read_u32(np, "bootwrapper-magic",
> +                               &hip04_boot.bootwrapper_magic) )
> +        goto err;
> +
> +    msg = "failed to get relocation-entry\n";
> +    if ( !dt_property_read_u32(np, "relocation-entry",
> +                               &hip04_boot.relocation_entry) )
> +        goto err;
> +
> +    msg = "failed to get relocation-size\n";
> +    if ( !dt_property_read_u32(np, "relocation-size",
> +                 &hip04_boot.relocation_size) )
> +        goto err;