* [PATCH] pcmcia: add missing include for new pci resource handler
@ 2015-01-13 14:11 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2015-01-13 14:11 UTC (permalink / raw)
To: linux-arm-kernel
The recently added rsrc_pci.c file calls pci_bus_alloc_resource without
including the header file that declares it, and that sometimes causes
a build warning on ARM:
drivers/pcmcia/rsrc_pci.c: In function 'find_io_region':
drivers/pcmcia/rsrc_pci.c:40:2: error: implicit declaration of function 'pci_bus_alloc_resource' [-Werror=implicit-function-declaration]
This adds the missing include statement.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fixes: 02b03846bb2be ("pcmcia: add a new resource manager for non ISA systems")
---
diff --git a/drivers/pcmcia/rsrc_pci.c b/drivers/pcmcia/rsrc_pci.c
index 8934d3c01f80..21c3683b1a53 100644
--- a/drivers/pcmcia/rsrc_pci.c
+++ b/drivers/pcmcia/rsrc_pci.c
@@ -1,6 +1,7 @@
#include <linux/slab.h>
#include <linux/module.h>
#include <linux/kernel.h>
+#include <linux/pci.h>
#include <pcmcia/ss.h>
#include <pcmcia/cistpl.h>
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] pcmcia: add missing include for new pci resource handler
@ 2015-01-13 14:11 ` Arnd Bergmann
0 siblings, 0 replies; 4+ messages in thread
From: Arnd Bergmann @ 2015-01-13 14:11 UTC (permalink / raw)
To: Greg Kroah-Hartman; +Cc: Alan Cox, linux-pcmcia, linux-kernel, linux-arm-kernel
The recently added rsrc_pci.c file calls pci_bus_alloc_resource without
including the header file that declares it, and that sometimes causes
a build warning on ARM:
drivers/pcmcia/rsrc_pci.c: In function 'find_io_region':
drivers/pcmcia/rsrc_pci.c:40:2: error: implicit declaration of function 'pci_bus_alloc_resource' [-Werror=implicit-function-declaration]
This adds the missing include statement.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Alan Cox <alan@linux.intel.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Fixes: 02b03846bb2be ("pcmcia: add a new resource manager for non ISA systems")
---
diff --git a/drivers/pcmcia/rsrc_pci.c b/drivers/pcmcia/rsrc_pci.c
index 8934d3c01f80..21c3683b1a53 100644
--- a/drivers/pcmcia/rsrc_pci.c
+++ b/drivers/pcmcia/rsrc_pci.c
@@ -1,6 +1,7 @@
#include <linux/slab.h>
#include <linux/module.h>
#include <linux/kernel.h>
+#include <linux/pci.h>
#include <pcmcia/ss.h>
#include <pcmcia/cistpl.h>
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] pcmcia: add missing include for new pci resource handler
2015-01-13 14:11 ` Arnd Bergmann
@ 2015-01-13 17:10 ` Alan Cox
-1 siblings, 0 replies; 4+ messages in thread
From: Alan Cox @ 2015-01-13 17:10 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2015-01-13 at 15:11 +0100, Arnd Bergmann wrote:
> The recently added rsrc_pci.c file calls pci_bus_alloc_resource without
> including the header file that declares it, and that sometimes causes
> a build warning on ARM:
>
> drivers/pcmcia/rsrc_pci.c: In function 'find_io_region':
> drivers/pcmcia/rsrc_pci.c:40:2: error: implicit declaration of function 'pci_bus_alloc_resource' [-Werror=implicit-function-declaration]
>
> This adds the missing include statement.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Alan Cox <alan@linux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Fixes: 02b03846bb2be ("pcmcia: add a new resource manager for non ISA systems"
Acked-by: Alan Cox <alan@linux.intel.com>
I hadn't intended it to be sucked on ARM although I guess it ought to
work there just fine.
Alan
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] pcmcia: add missing include for new pci resource handler
@ 2015-01-13 17:10 ` Alan Cox
0 siblings, 0 replies; 4+ messages in thread
From: Alan Cox @ 2015-01-13 17:10 UTC (permalink / raw)
To: Arnd Bergmann
Cc: Greg Kroah-Hartman, linux-pcmcia, linux-kernel, linux-arm-kernel
On Tue, 2015-01-13 at 15:11 +0100, Arnd Bergmann wrote:
> The recently added rsrc_pci.c file calls pci_bus_alloc_resource without
> including the header file that declares it, and that sometimes causes
> a build warning on ARM:
>
> drivers/pcmcia/rsrc_pci.c: In function 'find_io_region':
> drivers/pcmcia/rsrc_pci.c:40:2: error: implicit declaration of function 'pci_bus_alloc_resource' [-Werror=implicit-function-declaration]
>
> This adds the missing include statement.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Cc: Alan Cox <alan@linux.intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Fixes: 02b03846bb2be ("pcmcia: add a new resource manager for non ISA systems"
Acked-by: Alan Cox <alan@linux.intel.com>
I hadn't intended it to be sucked on ARM although I guess it ought to
work there just fine.
Alan
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-01-13 17:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-13 14:11 [PATCH] pcmcia: add missing include for new pci resource handler Arnd Bergmann
2015-01-13 14:11 ` Arnd Bergmann
2015-01-13 17:10 ` Alan Cox
2015-01-13 17:10 ` Alan Cox
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.