* [PATCH] ConfHandler: Rename oldfn to parentfn to be clearer
@ 2015-01-15 9:41 Richard Purdie
0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2015-01-15 9:41 UTC (permalink / raw)
To: bitbake-devel
Looking at this function I had no idea what oldfn was, I doubt anyone
else would either without looking up what the caller does. "parentfn"
would seem a more appropriate name so rename it.
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
diff --git a/bitbake/lib/bb/parse/parse_py/ConfHandler.py b/bitbake/lib/bb/parse/parse_py/ConfHandler.py
index 978ebe4..9d592f7 100644
--- a/bitbake/lib/bb/parse/parse_py/ConfHandler.py
+++ b/bitbake/lib/bb/parse/parse_py/ConfHandler.py
@@ -66,21 +66,21 @@ def init(data):
def supports(fn, d):
return fn[-5:] == ".conf"
-def include(oldfn, fn, lineno, data, error_out):
+def include(parentfn, fn, lineno, data, error_out):
"""
error_out: A string indicating the verb (e.g. "include", "inherit") to be
used in a ParseError that will be raised if the file to be included could
not be included. Specify False to avoid raising an error in this case.
"""
- if oldfn == fn: # prevent infinite recursion
+ if parentfn == fn: # prevent infinite recursion
return None
import bb
fn = data.expand(fn)
- oldfn = data.expand(oldfn)
+ parentfn = data.expand(parentfn)
if not os.path.isabs(fn):
- dname = os.path.dirname(oldfn)
+ dname = os.path.dirname(parentfn)
bbpath = "%s:%s" % (dname, data.getVar("BBPATH", True))
abs_fn, attempts = bb.utils.which(bbpath, fn, history=True)
if abs_fn and bb.parse.check_dependency(data, abs_fn):
@@ -97,7 +97,7 @@ def include(oldfn, fn, lineno, data, error_out):
ret = handle(fn, data, True)
except (IOError, OSError):
if error_out:
- raise ParseError("Could not %(error_out)s file %(fn)s" % vars(), oldfn, lineno)
+ raise ParseError("Could not %(error_out)s file %(fn)s" % vars(), parentfn, lineno)
logger.debug(2, "CONF file '%s' not found", fn)
bb.parse.mark_dependency(data, fn)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-01-15 9:41 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-15 9:41 [PATCH] ConfHandler: Rename oldfn to parentfn to be clearer Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.