* [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs @ 2015-01-08 17:47 Dario Faggioli 2015-01-12 16:52 ` Ian Jackson 0 siblings, 1 reply; 9+ messages in thread From: Dario Faggioli @ 2015-01-08 17:47 UTC (permalink / raw) To: xen-devel; +Cc: Ian.Jackson, Wei Liu, Ian Campbell Scheduling related tests are ok to run on ARM, so do not cut them off. They also do not depend on a particular Dom0 architecture. The net effect is that the following tests are removed: test-amd64-i386-xl-credit2 test-amd64-i386-xl-multivcpu while the following new ones are created: test-amd64-amd64-xl-credit2 test-amd64-amd64-xl-multivcpu test-armhf-armhf-xl-credit2 test-armhf-armhf-xl-multivcpu test-armhf-armhf-xl-sedf test-armhf-armhf-xl-sedf-pin Signed-off-by: Dario Faggioli <dario.faggioli@citrix.com> --- make-flight | 29 ++++++++++++++++------------- 1 file changed, 16 insertions(+), 13 deletions(-) diff --git a/make-flight b/make-flight index a91f256..977e624 100755 --- a/make-flight +++ b/make-flight @@ -241,7 +241,7 @@ do_hvm_rhel6_tests () { } do_sedf_tests () { - if [ $xenarch != amd64 -o $dom0arch != amd64 ]; then + if [ $xenarch != $dom0arch ]; then return fi @@ -256,7 +256,7 @@ do_sedf_tests () { } do_credit2_tests () { - if [ $xenarch != amd64 -o $dom0arch != i386 ]; then + if [ $xenarch != $dom0arch ]; then return fi @@ -266,6 +266,16 @@ do_credit2_tests () { $debian_runvars all_hostflags=$most_hostflags } +do_multivcpu_tests () { + if [ $xenarch != $dom0arch ]; then + return + fi + + job_create_test test-$xenarch$kern-$dom0arch-xl-multivcpu \ + test-debian xl $xenarch $dom0arch guests_vcpus=4 \ + $debian_runvars all_hostflags=$most_hostflags +} + do_passthrough_tests () { if [ $xenarch != amd64 -o $dom0arch != amd64 -o "$kern" != "" ]; then return @@ -293,6 +303,10 @@ test_matrix_do_one () { $xenarch $dom0arch \ $debian_runvars all_hostflags=$most_hostflags + do_multivcpu_tests + do_sedf_tests + do_credit2_tests + # No further arm tests at the moment if [ $dom0arch = armhf ]; then return @@ -364,17 +378,6 @@ test_matrix_do_one () { $debian_runvars \ all_hostflags=$most_hostflags,equiv-1 - do_sedf_tests - do_credit2_tests - - if [ $xenarch = amd64 -a $dom0arch = i386 ]; then - - job_create_test test-$xenarch$kern-$dom0arch-xl-multivcpu \ - test-debian xl $xenarch $dom0arch guests_vcpus=4 \ - $debian_runvars all_hostflags=$most_hostflags - - fi - if [ x$test_pvh = xy -a $xenarch = amd64 -a $dom0arch = amd64 ]; then for cpuvendor in amd intel; do ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs 2015-01-08 17:47 [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs Dario Faggioli @ 2015-01-12 16:52 ` Ian Jackson 2015-01-13 14:15 ` Dario Faggioli 0 siblings, 1 reply; 9+ messages in thread From: Ian Jackson @ 2015-01-12 16:52 UTC (permalink / raw) To: Dario Faggioli; +Cc: Wei Liu, Ian Campbell, xen-devel Dario Faggioli writes ("[OSSTEST PATCH] make-flight: reorganize scheduling related test jobs"): > Scheduling related tests are ok to run on ARM, so do > not cut them off. They also do not depend on a > particular Dom0 architecture. > > The net effect is that the following tests are removed: > test-amd64-i386-xl-credit2 > test-amd64-i386-xl-multivcpu > > while the following new ones are created: > test-amd64-amd64-xl-credit2 > test-amd64-amd64-xl-multivcpu > test-armhf-armhf-xl-credit2 > test-armhf-armhf-xl-multivcpu > test-armhf-armhf-xl-sedf > test-armhf-armhf-xl-sedf-pin This looks plausible but can you include the output of a diff between the two sets of runvars, please ? Thanks, Ian. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs 2015-01-12 16:52 ` Ian Jackson @ 2015-01-13 14:15 ` Dario Faggioli 2015-01-14 16:56 ` Ian Jackson 0 siblings, 1 reply; 9+ messages in thread From: Dario Faggioli @ 2015-01-13 14:15 UTC (permalink / raw) To: Ian Jackson; +Cc: Wei Liu, Ian Campbell, xen-devel [-- Attachment #1.1: Type: text/plain, Size: 38107 bytes --] On Mon, 2015-01-12 at 16:52 +0000, Ian Jackson wrote: > Dario Faggioli writes ("[OSSTEST PATCH] make-flight: reorganize scheduling related test jobs"): > > Scheduling related tests are ok to run on ARM, so do > > not cut them off. They also do not depend on a > > particular Dom0 architecture. > > > > The net effect is that the following tests are removed: > > test-amd64-i386-xl-credit2 > > test-amd64-i386-xl-multivcpu > > > > while the following new ones are created: > > test-amd64-amd64-xl-credit2 > > test-amd64-amd64-xl-multivcpu > > test-armhf-armhf-xl-credit2 > > test-armhf-armhf-xl-multivcpu > > test-armhf-armhf-xl-sedf > > test-armhf-armhf-xl-sedf-pin > > This looks plausible but can you include the output of a diff between > the two sets of runvars, please ? > Not sure I'm getting. I will put down here a diff of two invocation of `./mg-show-flight-runvars standalone', one done before the other after the patch... Was it that? $ diff -Nru runvars.orig runvars.patched --- runvars.orig 2015-01-13 09:49:17.402478000 +0000 +++ runvars.patched 2015-01-13 09:49:56.794085000 +0000 @@ -3,6 +3,7 @@ test-amd64-amd64-rumpuserxen-amd64 all_hostflags arch-amd64,arch-xen-amd64,suite-wheezy,purpose-test test-amd64-amd64-xl all_hostflags arch-amd64,arch-xen-amd64,suite-wheezy,purpose-test test-amd64-amd64-xl-credit2 all_hostflags arch-amd64,arch-xen-amd64,suite-wheezy,purpose-test +test-amd64-amd64-xl-multivcpu all_hostflags arch-amd64,arch-xen-amd64,suite-wheezy,purpose-test test-amd64-amd64-xl-pcipt-intel all_hostflags arch-amd64,arch-xen-amd64,suite-wheezy,purpose-test,hvm-intel,pcipassthrough-nic test-amd64-amd64-xl-pvh-amd all_hostflags arch-amd64,arch-xen-amd64,suite-wheezy,purpose-test,hvm-amd test-amd64-amd64-xl-pvh-intel all_hostflags arch-amd64,arch-xen-amd64,suite-wheezy,purpose-test,hvm-intel @@ -29,7 +30,6 @@ test-amd64-i386-rhel6hvm-intel all_hostflags arch-i386,arch-xen-amd64,suite-wheezy,purpose-test,hvm-intel test-amd64-i386-rumpuserxen-i386 all_hostflags arch-i386,arch-xen-amd64,suite-wheezy,purpose-test test-amd64-i386-xl all_hostflags arch-i386,arch-xen-amd64,suite-wheezy,purpose-test -test-amd64-i386-xl-multivcpu all_hostflags arch-i386,arch-xen-amd64,suite-wheezy,purpose-test test-amd64-i386-xl-qemut-debianhvm-amd64 all_hostflags arch-i386,arch-xen-amd64,suite-wheezy,purpose-test,hvm test-amd64-i386-xl-qemut-win7-amd64 all_hostflags arch-i386,arch-xen-amd64,suite-wheezy,purpose-test,hvm test-amd64-i386-xl-qemut-winxpsp3 all_hostflags arch-i386,arch-xen-amd64,suite-wheezy,purpose-test,hvm @@ -44,6 +44,10 @@ test-amd64-i386-xl-winxpsp3-vcpus1 all_hostflags arch-i386,arch-xen-amd64,suite-wheezy,purpose-test,hvm test-armhf-armhf-libvirt all_hostflags arch-armhf,arch-xen-armhf,suite-wheezy,purpose-test test-armhf-armhf-xl all_hostflags arch-armhf,arch-xen-armhf,suite-wheezy,purpose-test +test-armhf-armhf-xl-credit2 all_hostflags arch-armhf,arch-xen-armhf,suite-wheezy,purpose-test +test-armhf-armhf-xl-multivcpu all_hostflags arch-armhf,arch-xen-armhf,suite-wheezy,purpose-test +test-armhf-armhf-xl-sedf all_hostflags arch-armhf,arch-xen-armhf,suite-wheezy,purpose-test +test-armhf-armhf-xl-sedf-pin all_hostflags arch-armhf,arch-xen-armhf,suite-wheezy,purpose-test build-amd64 arch amd64 build-amd64-libvirt arch amd64 build-amd64-oldkern arch amd64 @@ -62,6 +66,7 @@ test-amd64-amd64-rumpuserxen-amd64 arch amd64 test-amd64-amd64-xl arch amd64 test-amd64-amd64-xl-credit2 arch amd64 +test-amd64-amd64-xl-multivcpu arch amd64 test-amd64-amd64-xl-pcipt-intel arch amd64 test-amd64-amd64-xl-pvh-amd arch amd64 test-amd64-amd64-xl-pvh-intel arch amd64 @@ -88,7 +93,6 @@ test-amd64-i386-rhel6hvm-intel arch i386 test-amd64-i386-rumpuserxen-i386 arch i386 test-amd64-i386-xl arch i386 -test-amd64-i386-xl-multivcpu arch i386 test-amd64-i386-xl-qemut-debianhvm-amd64 arch i386 test-amd64-i386-xl-qemut-win7-amd64 arch i386 test-amd64-i386-xl-qemut-winxpsp3 arch i386 @@ -103,6 +107,10 @@ test-amd64-i386-xl-winxpsp3-vcpus1 arch i386 test-armhf-armhf-libvirt arch armhf test-armhf-armhf-xl arch armhf +test-armhf-armhf-xl-credit2 arch armhf +test-armhf-armhf-xl-multivcpu arch armhf +test-armhf-armhf-xl-sedf arch armhf +test-armhf-armhf-xl-sedf-pin arch armhf test-amd64-amd64-xl-qemut-debianhvm-amd64 bios rombios test-amd64-amd64-xl-qemuu-debianhvm-amd64 bios seabios test-amd64-amd64-xl-qemuu-ovmf-amd64 bios ovmf @@ -132,6 +140,7 @@ test-amd64-amd64-rumpuserxen-amd64 buildjob build-amd64 test-amd64-amd64-xl buildjob build-amd64 test-amd64-amd64-xl-credit2 buildjob build-amd64 +test-amd64-amd64-xl-multivcpu buildjob build-amd64 test-amd64-amd64-xl-pcipt-intel buildjob build-amd64 test-amd64-amd64-xl-pvh-amd buildjob build-amd64 test-amd64-amd64-xl-pvh-intel buildjob build-amd64 @@ -158,7 +167,6 @@ test-amd64-i386-rhel6hvm-intel buildjob build-i386 test-amd64-i386-rumpuserxen-i386 buildjob build-i386 test-amd64-i386-xl buildjob build-i386 -test-amd64-i386-xl-multivcpu buildjob build-i386 test-amd64-i386-xl-qemut-debianhvm-amd64 buildjob build-i386 test-amd64-i386-xl-qemut-win7-amd64 buildjob build-i386 test-amd64-i386-xl-qemut-winxpsp3 buildjob build-i386 @@ -173,10 +181,15 @@ test-amd64-i386-xl-winxpsp3-vcpus1 buildjob build-i386 test-armhf-armhf-libvirt buildjob build-armhf test-armhf-armhf-xl buildjob build-armhf +test-armhf-armhf-xl-credit2 buildjob build-armhf +test-armhf-armhf-xl-multivcpu buildjob build-armhf +test-armhf-armhf-xl-sedf buildjob build-armhf +test-armhf-armhf-xl-sedf-pin buildjob build-armhf test-amd64-amd64-libvirt debian_arch amd64 test-amd64-amd64-pair debian_arch amd64 test-amd64-amd64-xl debian_arch amd64 test-amd64-amd64-xl-credit2 debian_arch amd64 +test-amd64-amd64-xl-multivcpu debian_arch amd64 test-amd64-amd64-xl-pcipt-intel debian_arch amd64 test-amd64-amd64-xl-pvh-amd debian_arch amd64 test-amd64-amd64-xl-pvh-intel debian_arch amd64 @@ -185,13 +198,17 @@ test-amd64-i386-libvirt debian_arch i386 test-amd64-i386-pair debian_arch i386 test-amd64-i386-xl debian_arch i386 -test-amd64-i386-xl-multivcpu debian_arch i386 test-armhf-armhf-libvirt debian_arch armhf test-armhf-armhf-xl debian_arch armhf +test-armhf-armhf-xl-credit2 debian_arch armhf +test-armhf-armhf-xl-multivcpu debian_arch armhf +test-armhf-armhf-xl-sedf debian_arch armhf +test-armhf-armhf-xl-sedf-pin debian_arch armhf test-amd64-amd64-libvirt debian_kernkind pvops test-amd64-amd64-pair debian_kernkind pvops test-amd64-amd64-xl debian_kernkind pvops test-amd64-amd64-xl-credit2 debian_kernkind pvops +test-amd64-amd64-xl-multivcpu debian_kernkind pvops test-amd64-amd64-xl-pcipt-intel debian_kernkind pvops test-amd64-amd64-xl-pvh-amd debian_kernkind pvops test-amd64-amd64-xl-pvh-intel debian_kernkind pvops @@ -200,9 +217,12 @@ test-amd64-i386-libvirt debian_kernkind pvops test-amd64-i386-pair debian_kernkind pvops test-amd64-i386-xl debian_kernkind pvops -test-amd64-i386-xl-multivcpu debian_kernkind pvops test-armhf-armhf-libvirt debian_kernkind pvops test-armhf-armhf-xl debian_kernkind pvops +test-armhf-armhf-xl-credit2 debian_kernkind pvops +test-armhf-armhf-xl-multivcpu debian_kernkind pvops +test-armhf-armhf-xl-sedf debian_kernkind pvops +test-armhf-armhf-xl-sedf-pin debian_kernkind pvops test-amd64-amd64-xl-pcipt-intel debian_pcipassthrough_nic host test-amd64-amd64-xl-pvh-amd debian_pvh 1 test-amd64-amd64-xl-pvh-intel debian_pvh 1 @@ -245,13 +265,17 @@ test-amd64-amd64-rumpuserxen-amd64 guests_rumpuserxenbuildjob build-amd64-rumpuserxen test-amd64-i386-rumpuserxen-i386 guests_rumpuserxenbuildjob build-i386-rumpuserxen test-amd64-amd64-xl-credit2 guests_vcpus 4 +test-amd64-amd64-xl-multivcpu guests_vcpus 4 test-amd64-amd64-xl-pcipt-intel guests_vcpus 4 test-amd64-amd64-xl-sedf guests_vcpus 4 test-amd64-amd64-xl-sedf-pin guests_vcpus 4 -test-amd64-i386-xl-multivcpu guests_vcpus 4 test-amd64-i386-xl-qemut-winxpsp3-vcpus1 guests_vcpus 1 test-amd64-i386-xl-qemuu-winxpsp3-vcpus1 guests_vcpus 1 test-amd64-i386-xl-winxpsp3-vcpus1 guests_vcpus 1 +test-armhf-armhf-xl-credit2 guests_vcpus 4 +test-armhf-armhf-xl-multivcpu guests_vcpus 4 +test-armhf-armhf-xl-sedf guests_vcpus 4 +test-armhf-armhf-xl-sedf-pin guests_vcpus 4 build-amd64 host_hostflags share-build-wheezy-amd64,arch-amd64,suite-wheezy,purpose-build build-amd64-libvirt host_hostflags share-build-wheezy-amd64,arch-amd64,suite-wheezy,purpose-build build-amd64-oldkern host_hostflags share-build-wheezy-amd64,arch-amd64,suite-wheezy,purpose-build @@ -276,6 +300,7 @@ test-amd64-amd64-rumpuserxen-amd64 kernbuildjob build-amd64-pvops test-amd64-amd64-xl kernbuildjob build-amd64-pvops test-amd64-amd64-xl-credit2 kernbuildjob build-amd64-pvops +test-amd64-amd64-xl-multivcpu kernbuildjob build-amd64-pvops test-amd64-amd64-xl-pcipt-intel kernbuildjob build-amd64-pvops test-amd64-amd64-xl-pvh-amd kernbuildjob build-amd64-pvops test-amd64-amd64-xl-pvh-intel kernbuildjob build-amd64-pvops @@ -302,7 +327,6 @@ test-amd64-i386-rhel6hvm-intel kernbuildjob build-i386-pvops test-amd64-i386-rumpuserxen-i386 kernbuildjob build-i386-pvops test-amd64-i386-xl kernbuildjob build-i386-pvops -test-amd64-i386-xl-multivcpu kernbuildjob build-i386-pvops test-amd64-i386-xl-qemut-debianhvm-amd64 kernbuildjob build-i386-pvops test-amd64-i386-xl-qemut-win7-amd64 kernbuildjob build-i386-pvops test-amd64-i386-xl-qemut-winxpsp3 kernbuildjob build-i386-pvops @@ -317,11 +341,16 @@ test-amd64-i386-xl-winxpsp3-vcpus1 kernbuildjob build-i386-pvops test-armhf-armhf-libvirt kernbuildjob build-armhf-pvops test-armhf-armhf-xl kernbuildjob build-armhf-pvops +test-armhf-armhf-xl-credit2 kernbuildjob build-armhf-pvops +test-armhf-armhf-xl-multivcpu kernbuildjob build-armhf-pvops +test-armhf-armhf-xl-sedf kernbuildjob build-armhf-pvops +test-armhf-armhf-xl-sedf-pin kernbuildjob build-armhf-pvops test-amd64-amd64-libvirt kernkind pvops test-amd64-amd64-pair kernkind pvops test-amd64-amd64-rumpuserxen-amd64 kernkind pvops test-amd64-amd64-xl kernkind pvops test-amd64-amd64-xl-credit2 kernkind pvops +test-amd64-amd64-xl-multivcpu kernkind pvops test-amd64-amd64-xl-pcipt-intel kernkind pvops test-amd64-amd64-xl-pvh-amd kernkind pvops test-amd64-amd64-xl-pvh-intel kernkind pvops @@ -348,7 +377,6 @@ test-amd64-i386-rhel6hvm-intel kernkind pvops test-amd64-i386-rumpuserxen-i386 kernkind pvops test-amd64-i386-xl kernkind pvops -test-amd64-i386-xl-multivcpu kernkind pvops test-amd64-i386-xl-qemut-debianhvm-amd64 kernkind pvops test-amd64-i386-xl-qemut-win7-amd64 kernkind pvops test-amd64-i386-xl-qemut-winxpsp3 kernkind pvops @@ -363,6 +391,10 @@ test-amd64-i386-xl-winxpsp3-vcpus1 kernkind pvops test-armhf-armhf-libvirt kernkind pvops test-armhf-armhf-xl kernkind pvops +test-armhf-armhf-xl-credit2 kernkind pvops +test-armhf-armhf-xl-multivcpu kernkind pvops +test-armhf-armhf-xl-sedf kernkind pvops +test-armhf-armhf-xl-sedf-pin kernkind pvops build-amd64-oldkern kimagefile vmlinux build-i386-oldkern kimagefile vmlinux test-amd64-amd64-libvirt libvirtbuildjob build-amd64-libvirt @@ -370,6 +402,8 @@ test-armhf-armhf-libvirt libvirtbuildjob build-armhf-libvirt test-amd64-amd64-xl-sedf linux_boot_append loglevel=9 debug test-amd64-amd64-xl-sedf-pin linux_boot_append loglevel=9 debug +test-armhf-armhf-xl-sedf linux_boot_append loglevel=9 debug +test-armhf-armhf-xl-sedf-pin linux_boot_append loglevel=9 debug test-amd64-i386-qemut-rhel6hvm-amd redhat_image rhel-server-6.1-i386-dvd.iso test-amd64-i386-qemut-rhel6hvm-intel redhat_image rhel-server-6.1-i386-dvd.iso test-amd64-i386-qemuu-rhel6hvm-amd redhat_image rhel-server-6.1-i386-dvd.iso @@ -414,6 +448,7 @@ test-amd64-amd64-rumpuserxen-amd64 toolstack xl test-amd64-amd64-xl toolstack xl test-amd64-amd64-xl-credit2 toolstack xl +test-amd64-amd64-xl-multivcpu toolstack xl test-amd64-amd64-xl-pcipt-intel toolstack xl test-amd64-amd64-xl-pvh-amd toolstack xl test-amd64-amd64-xl-pvh-intel toolstack xl @@ -440,7 +475,6 @@ test-amd64-i386-rhel6hvm-intel toolstack xl test-amd64-i386-rumpuserxen-i386 toolstack xl test-amd64-i386-xl toolstack xl -test-amd64-i386-xl-multivcpu toolstack xl test-amd64-i386-xl-qemut-debianhvm-amd64 toolstack xl test-amd64-i386-xl-qemut-win7-amd64 toolstack xl test-amd64-i386-xl-qemut-winxpsp3 toolstack xl @@ -455,6 +489,10 @@ test-amd64-i386-xl-winxpsp3-vcpus1 toolstack xl test-armhf-armhf-libvirt toolstack libvirt test-armhf-armhf-xl toolstack xl +test-armhf-armhf-xl-credit2 toolstack xl +test-armhf-armhf-xl-multivcpu toolstack xl +test-armhf-armhf-xl-sedf toolstack xl +test-armhf-armhf-xl-sedf-pin toolstack xl build-amd64-libvirt tree_libvirt git://libvirt.org/libvirt.git build-armhf-libvirt tree_libvirt git://libvirt.org/libvirt.git build-i386-libvirt tree_libvirt git://libvirt.org/libvirt.git @@ -514,11 +552,15 @@ test-amd64-amd64-xl-credit2 xen_boot_append sched=credit2 test-amd64-amd64-xl-sedf xen_boot_append sched=sedf loglvl=all test-amd64-amd64-xl-sedf-pin xen_boot_append sched=sedf loglvl=all dom0_vcpus_pin +test-armhf-armhf-xl-credit2 xen_boot_append sched=credit2 +test-armhf-armhf-xl-sedf xen_boot_append sched=sedf loglvl=all +test-armhf-armhf-xl-sedf-pin xen_boot_append sched=sedf loglvl=all dom0_vcpus_pin test-amd64-amd64-libvirt xenbuildjob build-amd64 test-amd64-amd64-pair xenbuildjob build-amd64 test-amd64-amd64-rumpuserxen-amd64 xenbuildjob build-amd64 test-amd64-amd64-xl xenbuildjob build-amd64 test-amd64-amd64-xl-credit2 xenbuildjob build-amd64 +test-amd64-amd64-xl-multivcpu xenbuildjob build-amd64 test-amd64-amd64-xl-pcipt-intel xenbuildjob build-amd64 test-amd64-amd64-xl-pvh-amd xenbuildjob build-amd64 test-amd64-amd64-xl-pvh-intel xenbuildjob build-amd64 @@ -545,7 +587,6 @@ test-amd64-i386-rhel6hvm-intel xenbuildjob build-amd64 test-amd64-i386-rumpuserxen-i386 xenbuildjob build-amd64 test-amd64-i386-xl xenbuildjob build-amd64 -test-amd64-i386-xl-multivcpu xenbuildjob build-amd64 test-amd64-i386-xl-qemut-debianhvm-amd64 xenbuildjob build-amd64 test-amd64-i386-xl-qemut-win7-amd64 xenbuildjob build-amd64 test-amd64-i386-xl-qemut-winxpsp3 xenbuildjob build-amd64 @@ -560,6 +601,10 @@ test-amd64-i386-xl-winxpsp3-vcpus1 xenbuildjob build-amd64 test-armhf-armhf-libvirt xenbuildjob build-armhf test-armhf-armhf-xl xenbuildjob build-armhf +test-armhf-armhf-xl-credit2 xenbuildjob build-armhf +test-armhf-armhf-xl-multivcpu xenbuildjob build-armhf +test-armhf-armhf-xl-sedf xenbuildjob build-armhf +test-armhf-armhf-xl-sedf-pin xenbuildjob build-armhf test-amd64-amd64-rumpuserxen-amd64 xenstorels_builtimage :/usr/local/bin/xenstore test-amd64-i386-rumpuserxen-i386 xenstorels_builtimage :/usr/local/bin/xenstore test-amd64-amd64-rumpuserxen-amd64 xenstorels_cmdline ls -fp device -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) [-- Attachment #1.2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 181 bytes --] [-- Attachment #2: Type: text/plain, Size: 126 bytes --] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs 2015-01-13 14:15 ` Dario Faggioli @ 2015-01-14 16:56 ` Ian Jackson 2015-01-15 9:31 ` Ian Campbell 2015-01-20 15:39 ` Dario Faggioli 0 siblings, 2 replies; 9+ messages in thread From: Ian Jackson @ 2015-01-14 16:56 UTC (permalink / raw) To: Dario Faggioli; +Cc: Wei Liu, Ian Campbell, xen-devel Dario Faggioli writes ("Re: [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs"): > On Mon, 2015-01-12 at 16:52 +0000, Ian Jackson wrote: > > This looks plausible but can you include the output of a diff between > > the two sets of runvars, please ? ... > I will put down here a diff of two invocation of > `./mg-show-flight-runvars standalone', one done before the other after > the patch... Was it that? That's what I meant, exactly. But looking at it shows that it would benefit from being the output of ./mg-show-flight-runvars standalone | sort Can you provide that diff ? This is the usual way that I check that a patch like yours dues what I think it does. Ian. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs 2015-01-14 16:56 ` Ian Jackson @ 2015-01-15 9:31 ` Ian Campbell 2015-01-15 11:10 ` Ian Jackson 2015-01-20 15:39 ` Dario Faggioli 1 sibling, 1 reply; 9+ messages in thread From: Ian Campbell @ 2015-01-15 9:31 UTC (permalink / raw) To: Ian Jackson; +Cc: Dario Faggioli, Wei Liu, xen-devel On Wed, 2015-01-14 at 16:56 +0000, Ian Jackson wrote: > Dario Faggioli writes ("Re: [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs"): > > On Mon, 2015-01-12 at 16:52 +0000, Ian Jackson wrote: > > > This looks plausible but can you include the output of a diff between > > > the two sets of runvars, please ? > ... > > I will put down here a diff of two invocation of > > `./mg-show-flight-runvars standalone', one done before the other after > > the patch... Was it that? > > That's what I meant, exactly. But looking at it shows that it would > benefit from being the output of > ./mg-show-flight-runvars standalone | sort FWIW I've often thought that mg-show-flight-runvars sorts on the wrong column, at least for the majority of my use cases. 8<------------------ >From 5eedcbb7f635d63176824c2c7c274260ec11cfa2 Mon Sep 17 00:00:00 2001 From: Ian Campbell <ian.campbell@citrix.com> Date: Thu, 15 Jan 2015 09:30:45 +0000 Subject: [PATCH] mg-show-flight-runvars: sort by job before name Signed-off-by: Ian Campbell <ian.campbell@citrix.com> --- mg-show-flight-runvars | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mg-show-flight-runvars b/mg-show-flight-runvars index 62d5cba..d243466 100755 --- a/mg-show-flight-runvars +++ b/mg-show-flight-runvars @@ -52,7 +52,7 @@ my @colws = $dbh_tests->selectrow_array ("SELECT ".(join ',', map { "max(length($_))" } @cols)." $qfrom"); my $q = $dbh_tests->prepare - ("SELECT ".(join ',', @cols)." $qfrom ORDER BY name, job"); + ("SELECT ".(join ',', @cols)." $qfrom ORDER BY job, name"); $q->execute(); while (my $row = $q->fetchrow_arrayref()) { -- 2.1.1 ^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs 2015-01-15 9:31 ` Ian Campbell @ 2015-01-15 11:10 ` Ian Jackson 2015-01-15 11:15 ` Ian Campbell 0 siblings, 1 reply; 9+ messages in thread From: Ian Jackson @ 2015-01-15 11:10 UTC (permalink / raw) To: Ian Campbell; +Cc: Dario Faggioli, Wei Liu, xen-devel Ian Campbell writes ("Re: [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs"): > On Wed, 2015-01-14 at 16:56 +0000, Ian Jackson wrote: > > That's what I meant, exactly. But looking at it shows that it would > > benefit from being the output of > > ./mg-show-flight-runvars standalone | sort > > FWIW I've often thought that mg-show-flight-runvars sorts on the wrong > column, at least for the majority of my use cases. It's more useful for it to sort on a non-initial column. If you wanted it sorted on the initial column, you can use sort(1). Whereas after your patch, if I want to see all the values of a particular variable in all the jobs, I have to do something complicated. So if you're going to change this please add an option to make it sort the other way. When I last considered this I thought it more effort than it was worth... Thanks, Ian. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs 2015-01-15 11:10 ` Ian Jackson @ 2015-01-15 11:15 ` Ian Campbell 0 siblings, 0 replies; 9+ messages in thread From: Ian Campbell @ 2015-01-15 11:15 UTC (permalink / raw) To: Ian Jackson; +Cc: Dario Faggioli, Wei Liu, xen-devel On Thu, 2015-01-15 at 11:10 +0000, Ian Jackson wrote: > Ian Campbell writes ("Re: [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs"): > > On Wed, 2015-01-14 at 16:56 +0000, Ian Jackson wrote: > > > That's what I meant, exactly. But looking at it shows that it would > > > benefit from being the output of > > > ./mg-show-flight-runvars standalone | sort > > > > FWIW I've often thought that mg-show-flight-runvars sorts on the wrong > > column, at least for the majority of my use cases. > > It's more useful for it to sort on a non-initial column. If you > wanted it sorted on the initial column, you can use sort(1). Whereas > after your patch, if I want to see all the values of a particular > variable in all the jobs, I have to do something complicated. Like grep ;-) > So if you're going to change this please add an option to make it sort > the other way. When I last considered this I thought it more effort > than it was worth... Yeah, I think I just need to learn to remember to sort. My finger macros will figure it out eventually. Ian. ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs 2015-01-14 16:56 ` Ian Jackson 2015-01-15 9:31 ` Ian Campbell @ 2015-01-20 15:39 ` Dario Faggioli 2015-01-20 15:54 ` Ian Jackson 1 sibling, 1 reply; 9+ messages in thread From: Dario Faggioli @ 2015-01-20 15:39 UTC (permalink / raw) To: Ian Jackson; +Cc: Wei Liu, Ian Campbell, xen-devel [-- Attachment #1.1: Type: text/plain, Size: 14404 bytes --] On Wed, 2015-01-14 at 16:56 +0000, Ian Jackson wrote: > Dario Faggioli writes ("Re: [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs"): > > On Mon, 2015-01-12 at 16:52 +0000, Ian Jackson wrote: > > > This looks plausible but can you include the output of a diff between > > > the two sets of runvars, please ? > ... > > I will put down here a diff of two invocation of > > `./mg-show-flight-runvars standalone', one done before the other after > > the patch... Was it that? > > That's what I meant, exactly. But looking at it shows that it would > benefit from being the output of > ./mg-show-flight-runvars standalone | sort > > Can you provide that diff ? > Yes, here it comes. Sorry for the delay (wasn't working for most of last week). Any better? dariof@hoopak:~/osstest.git$ diff -Nru runvars.orig runvars.patched --- runvars.orig 2015-01-20 15:31:50.213269000 +0000 +++ runvars.patched 2015-01-20 15:35:55.272099000 +0000 @@ -175,6 +175,16 @@ test-amd64-amd64-xl debian_kernkind pvops test-amd64-amd64-xl kernbuildjob build-amd64-pvops test-amd64-amd64-xl kernkind pvops +test-amd64-amd64-xl-multivcpu all_hostflags arch-amd64,arch-xen-amd64,suite-wheezy,purpose-test +test-amd64-amd64-xl-multivcpu arch amd64 +test-amd64-amd64-xl-multivcpu buildjob build-amd64 +test-amd64-amd64-xl-multivcpu debian_arch amd64 +test-amd64-amd64-xl-multivcpu debian_kernkind pvops +test-amd64-amd64-xl-multivcpu guests_vcpus 4 +test-amd64-amd64-xl-multivcpu kernbuildjob build-amd64-pvops +test-amd64-amd64-xl-multivcpu kernkind pvops +test-amd64-amd64-xl-multivcpu toolstack xl +test-amd64-amd64-xl-multivcpu xenbuildjob build-amd64 test-amd64-amd64-xl-pcipt-intel all_hostflags arch-amd64,arch-xen-amd64,suite-wheezy,purpose-test,hvm-intel,pcipassthrough-nic test-amd64-amd64-xl-pcipt-intel arch amd64 test-amd64-amd64-xl-pcipt-intel buildjob build-amd64 @@ -422,16 +432,6 @@ test-amd64-i386-xl debian_kernkind pvops test-amd64-i386-xl kernbuildjob build-i386-pvops test-amd64-i386-xl kernkind pvops -test-amd64-i386-xl-multivcpu all_hostflags arch-i386,arch-xen-amd64,suite-wheezy,purpose-test -test-amd64-i386-xl-multivcpu arch i386 -test-amd64-i386-xl-multivcpu buildjob build-i386 -test-amd64-i386-xl-multivcpu debian_arch i386 -test-amd64-i386-xl-multivcpu debian_kernkind pvops -test-amd64-i386-xl-multivcpu guests_vcpus 4 -test-amd64-i386-xl-multivcpu kernbuildjob build-i386-pvops -test-amd64-i386-xl-multivcpu kernkind pvops -test-amd64-i386-xl-multivcpu toolstack xl -test-amd64-i386-xl-multivcpu xenbuildjob build-amd64 test-amd64-i386-xl-qemut-debianhvm-amd64 all_hostflags arch-i386,arch-xen-amd64,suite-wheezy,purpose-test,hvm test-amd64-i386-xl-qemut-debianhvm-amd64 arch i386 test-amd64-i386-xl-qemut-debianhvm-amd64 bios rombios @@ -558,9 +558,54 @@ test-armhf-armhf-xl all_hostflags arch-armhf,arch-xen-armhf,suite-wheezy,purpose-test test-armhf-armhf-xl arch armhf test-armhf-armhf-xl buildjob build-armhf +test-armhf-armhf-xl-credit2 all_hostflags arch-armhf,arch-xen-armhf,suite-wheezy,purpose-test +test-armhf-armhf-xl-credit2 arch armhf +test-armhf-armhf-xl-credit2 buildjob build-armhf +test-armhf-armhf-xl-credit2 debian_arch armhf +test-armhf-armhf-xl-credit2 debian_kernkind pvops +test-armhf-armhf-xl-credit2 guests_vcpus 4 +test-armhf-armhf-xl-credit2 kernbuildjob build-armhf-pvops +test-armhf-armhf-xl-credit2 kernkind pvops +test-armhf-armhf-xl-credit2 toolstack xl +test-armhf-armhf-xl-credit2 xen_boot_append sched=credit2 +test-armhf-armhf-xl-credit2 xenbuildjob build-armhf test-armhf-armhf-xl debian_arch armhf test-armhf-armhf-xl debian_kernkind pvops test-armhf-armhf-xl kernbuildjob build-armhf-pvops test-armhf-armhf-xl kernkind pvops +test-armhf-armhf-xl-multivcpu all_hostflags arch-armhf,arch-xen-armhf,suite-wheezy,purpose-test +test-armhf-armhf-xl-multivcpu arch armhf +test-armhf-armhf-xl-multivcpu buildjob build-armhf +test-armhf-armhf-xl-multivcpu debian_arch armhf +test-armhf-armhf-xl-multivcpu debian_kernkind pvops +test-armhf-armhf-xl-multivcpu guests_vcpus 4 +test-armhf-armhf-xl-multivcpu kernbuildjob build-armhf-pvops +test-armhf-armhf-xl-multivcpu kernkind pvops +test-armhf-armhf-xl-multivcpu toolstack xl +test-armhf-armhf-xl-multivcpu xenbuildjob build-armhf +test-armhf-armhf-xl-sedf all_hostflags arch-armhf,arch-xen-armhf,suite-wheezy,purpose-test +test-armhf-armhf-xl-sedf arch armhf +test-armhf-armhf-xl-sedf buildjob build-armhf +test-armhf-armhf-xl-sedf debian_arch armhf +test-armhf-armhf-xl-sedf debian_kernkind pvops +test-armhf-armhf-xl-sedf guests_vcpus 4 +test-armhf-armhf-xl-sedf kernbuildjob build-armhf-pvops +test-armhf-armhf-xl-sedf kernkind pvops +test-armhf-armhf-xl-sedf linux_boot_append loglevel=9 debug +test-armhf-armhf-xl-sedf-pin all_hostflags arch-armhf,arch-xen-armhf,suite-wheezy,purpose-test +test-armhf-armhf-xl-sedf-pin arch armhf +test-armhf-armhf-xl-sedf-pin buildjob build-armhf +test-armhf-armhf-xl-sedf-pin debian_arch armhf +test-armhf-armhf-xl-sedf-pin debian_kernkind pvops +test-armhf-armhf-xl-sedf-pin guests_vcpus 4 +test-armhf-armhf-xl-sedf-pin kernbuildjob build-armhf-pvops +test-armhf-armhf-xl-sedf-pin kernkind pvops +test-armhf-armhf-xl-sedf-pin linux_boot_append loglevel=9 debug +test-armhf-armhf-xl-sedf-pin toolstack xl +test-armhf-armhf-xl-sedf-pin xen_boot_append sched=sedf loglvl=all dom0_vcpus_pin +test-armhf-armhf-xl-sedf-pin xenbuildjob build-armhf +test-armhf-armhf-xl-sedf toolstack xl +test-armhf-armhf-xl-sedf xen_boot_append sched=sedf loglvl=all +test-armhf-armhf-xl-sedf xenbuildjob build-armhf test-armhf-armhf-xl toolstack xl test-armhf-armhf-xl xenbuildjob build-armhf -- <<This happens because I choose it to happen!>> (Raistlin Majere) ----------------------------------------------------------------- Dario Faggioli, Ph.D, http://about.me/dario.faggioli Senior Software Engineer, Citrix Systems R&D Ltd., Cambridge (UK) [-- Attachment #1.2: This is a digitally signed message part --] [-- Type: application/pgp-signature, Size: 181 bytes --] [-- Attachment #2: Type: text/plain, Size: 126 bytes --] _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel ^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs 2015-01-20 15:39 ` Dario Faggioli @ 2015-01-20 15:54 ` Ian Jackson 0 siblings, 0 replies; 9+ messages in thread From: Ian Jackson @ 2015-01-20 15:54 UTC (permalink / raw) To: Dario Faggioli; +Cc: Wei Liu, Ian Campbell, xen-devel Dario Faggioli writes ("Re: [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs"): > Yes, here it comes. Sorry for the delay (wasn't working for most of last > week). Any better? Brilliant, thanks. LGTM. Acked-by: Ian Jackson <ian.jackson@eu.citrix.com> Ian. ^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2015-01-20 15:54 UTC | newest] Thread overview: 9+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2015-01-08 17:47 [OSSTEST PATCH] make-flight: reorganize scheduling related test jobs Dario Faggioli 2015-01-12 16:52 ` Ian Jackson 2015-01-13 14:15 ` Dario Faggioli 2015-01-14 16:56 ` Ian Jackson 2015-01-15 9:31 ` Ian Campbell 2015-01-15 11:10 ` Ian Jackson 2015-01-15 11:15 ` Ian Campbell 2015-01-20 15:39 ` Dario Faggioli 2015-01-20 15:54 ` Ian Jackson
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.