From: Ian Campbell <Ian.Campbell@citrix.com>
To: Julien Grall <julien.grall@linaro.org>
Cc: Keir Fraser <keir@xen.org>,
Ian Jackson <ian.jackson@eu.citrix.com>,
tim@xen.org, stefano.stabellini@citrix.com,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH] xen/arm: Update documentation in the public header arch-arm.h
Date: Thu, 15 Jan 2015 13:48:59 +0000 [thread overview]
Message-ID: <1421329739.5437.10.camel@citrix.com> (raw)
In-Reply-To: <1421240029-9478-1-git-send-email-julien.grall@linaro.org>
On Wed, 2015-01-14 at 12:53 +0000, Julien Grall wrote:
> Minor updates to the documentation in xen/include/public/arch-arm.h:
> - Comments coding style fix
> - Typoes
> - Update the list of supported hypercalls by ARM
> - Remove uncessary comment about 64bit.
"unnecessary"
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Keir Fraser <keir@xen.org>
>
> ---
> I'm not sure if we usually backport documentation. If so, I'd like
> to request backporting for Xen 4.5.
I don't think we need to TBH, any development should be against unstable
and we publish these headers online for ease of access.
> + * All generic sub-operations
> *
> * HYPERVISOR_domctl
> * All generic sub-operations, with the exception of:
> - * * XEN_DOMCTL_iomem_permission (not yet implemented)
> * * XEN_DOMCTL_irq_permission (not yet implemented)
> *
> * HYPERVISOR_sched_op
> @@ -183,7 +178,7 @@
> * XEN_GUEST_HANDLE represents a guest pointer, when passed as a field
> * in a struct in memory. On ARM is always 8 bytes sizes and 8 bytes
> * aligned.
> - * XEN_GUEST_HANDLE_PARAM represent a guest pointer, when passed as an
> + * XEN_GUEST_HANDLE_PARAM represents a guest pointer, when passed as an
> * hypercall argument. It is 4 bytes on aarch and 8 bytes on aarch64.
Is there a "32" missing in this last sentence do you think? (not the bit
you touched)
I can fix the "unnecessary" on commit, so:
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Ian.
next prev parent reply other threads:[~2015-01-15 13:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-14 12:53 [PATCH] xen/arm: Update documentation in the public header arch-arm.h Julien Grall
2015-01-15 13:48 ` Ian Campbell [this message]
2015-01-15 13:53 ` Julien Grall
2015-01-15 13:59 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421329739.5437.10.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=julien.grall@linaro.org \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.