[PATCH 0/2] xen/arm: Misc for grant-table

[PATCH 0/2] xen/arm: Misc for grant-table

[Julien Grall]

Hi all,

This series contains a couple of change for the grant-table header.

The first one only removed an unused/misplaced define. The second one,
increase the number of grant frame iniatialize when the domain is created.

Regards,

Julien Grall (2):
  xen/arm: Remove the define INVALID_GFN from arch-arm/grant_table.h
  xen/arm: grant-table: Increased the initial number of grant frame to 4

 xen/include/asm-arm/grant_table.h | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

-- 
2.1.4

[PATCH 1/2] xen/arm: Remove the define INVALID_GFN from arch-arm/grant_table.h

[Julien Grall]

The define INVALID_GFN is misplaced in arch-arm/grant_table.h and is
never used in neither in ARM nor in the common code.

Therefore we can safely remove it.

Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
 xen/include/asm-arm/grant_table.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/xen/include/asm-arm/grant_table.h b/xen/include/asm-arm/grant_table.h
index 0edad67..88ee3c6 100644
--- a/xen/include/asm-arm/grant_table.h
+++ b/xen/include/asm-arm/grant_table.h
@@ -3,7 +3,6 @@
 
 #include <xen/grant_table.h>
 
-#define INVALID_GFN (-1UL)
 #define INITIAL_NR_GRANT_FRAMES 1
 
 void gnttab_clear_flag(unsigned long nr, uint16_t *addr);
-- 
2.1.4

Re: [PATCH 1/2] xen/arm: Remove the define INVALID_GFN from arch-arm/grant_table.h

[Ian Campbell]

On Tue, 2015-01-13 at 18:17 +0000, Julien Grall wrote:
> The define INVALID_GFN is misplaced in arch-arm/grant_table.h and is
> never used in neither in ARM nor in the common code.

Yeah, it appears to be an x86-ism which we copied over at some point.

> Therefore we can safely remove it.
> 
> Signed-off-by: Julien Grall <julien.grall@linaro.org>

Acked + applied, thanks.

[PATCH 2/2] xen/arm: grant-table: Increased the initial number of grant frame to 4

[Julien Grall]

When a domain is created on ARM, the grant table code initialized one
grant frame. With a basic load (i.e disk usage), Xen is quickly trying
to expand the number of frames:

(XEN) grant_table.c:1305:d2v0 Expanding dom (2) grant table from (1) to (2) frames.
(XEN) grant_table.c:1305:d2v0 Expanding dom (2) grant table from (2) to (3) frames.
(XEN) grant_table.c:311:d0v0 Increased maptrack size to 2 frames
(XEN) grant_table.c:311:d0v0 Increased maptrack size to 3 frames

The x86 code is initialied 4 frames (I didn't find the exact reason). I
think we could use the same default value.

Signed-off-by: Julien Grall <julien.grall@linaro.org>
---
 xen/include/asm-arm/grant_table.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/xen/include/asm-arm/grant_table.h b/xen/include/asm-arm/grant_table.h
index 88ee3c6..5e076cc 100644
--- a/xen/include/asm-arm/grant_table.h
+++ b/xen/include/asm-arm/grant_table.h
@@ -3,7 +3,7 @@
 
 #include <xen/grant_table.h>
 
-#define INITIAL_NR_GRANT_FRAMES 1
+#define INITIAL_NR_GRANT_FRAMES 4
 
 void gnttab_clear_flag(unsigned long nr, uint16_t *addr);
 int create_grant_host_mapping(unsigned long gpaddr,
-- 
2.1.4

Re: [PATCH 2/2] xen/arm: grant-table: Increased the initial number of grant frame to 4

[Ian Campbell]

On Tue, 2015-01-13 at 18:17 +0000, Julien Grall wrote:
> When a domain is created on ARM, the grant table code initialized one
> grant frame. With a basic load (i.e disk usage), Xen is quickly trying
> to expand the number of frames:
> 
> (XEN) grant_table.c:1305:d2v0 Expanding dom (2) grant table from (1) to (2) frames.
> (XEN) grant_table.c:1305:d2v0 Expanding dom (2) grant table from (2) to (3) frames.
> (XEN) grant_table.c:311:d0v0 Increased maptrack size to 2 frames
> (XEN) grant_table.c:311:d0v0 Increased maptrack size to 3 frames
> 
> The x86 code is initialied 4 frames (I didn't find the exact reason). I
> think we could use the same default value.
> 
> Signed-off-by: Julien Grall <julien.grall@linaro.org>

Acked + applied.

> ---
>  xen/include/asm-arm/grant_table.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/xen/include/asm-arm/grant_table.h b/xen/include/asm-arm/grant_table.h
> index 88ee3c6..5e076cc 100644
> --- a/xen/include/asm-arm/grant_table.h
> +++ b/xen/include/asm-arm/grant_table.h
> @@ -3,7 +3,7 @@
>  
>  #include <xen/grant_table.h>
>  
> -#define INITIAL_NR_GRANT_FRAMES 1
> +#define INITIAL_NR_GRANT_FRAMES 4
>  
>  void gnttab_clear_flag(unsigned long nr, uint16_t *addr);
>  int create_grant_host_mapping(unsigned long gpaddr,