From: Ian Campbell <Ian.Campbell@eu.citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Keir Fraser <keir@xen.org>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Jan Beulich <JBeulich@suse.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH v2] make error codes a formal part of the ABI
Date: Thu, 15 Jan 2015 16:40:32 +0000 [thread overview]
Message-ID: <1421340032.6926.4.camel@eu.citrix.com> (raw)
In-Reply-To: <54B7EA7E.20800@citrix.com>
On Thu, 2015-01-15 at 16:27 +0000, Andrew Cooper wrote:
> On 15/01/15 15:25, Jan Beulich wrote:
>
> > Now that we have two cases where patches against hvmloader got
> > submitted needing to include the hypervisor's errno.h (for the host's
> > system header not necessarily reflecting the correct numbers), take
> > this as a strong sign that we need to make the error return values part
> > of the hypervisor ABI (which de-fact they've always been).
> >
> > Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> How do the non XEN_ prefixed E$FOO get generated with this? All
> "#define XEN_ERRNO(...)" tokenise XEN_## onto the name.
I thought that too at first, but
+#define XEN_ERRNO(name, value) name = XEN_##name,
adds XEN_ on the value, not the name.
Ian.
next prev parent reply other threads:[~2015-01-15 16:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 15:25 [PATCH v2] make error codes a formal part of the ABI Jan Beulich
2015-01-15 16:27 ` Andrew Cooper
2015-01-15 16:40 ` Ian Campbell [this message]
2015-01-15 16:49 ` Jan Beulich
2015-01-15 16:58 ` Andrew Cooper
2015-01-20 12:37 ` Ian Campbell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421340032.6926.4.camel@eu.citrix.com \
--to=ian.campbell@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@eu.citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.