Re: [PATCH 0/6] jffs2: extend write verification to all write paths

[Richard Weinberger <richard@nod.at>]

----- Ursprüngliche Mail -----
> Von: "zhouminqiang" <zhouminqiang2@huawei.com>
> Thank you for your review and feedback.
> 
> Sorry for the confusion caused by my cover letter. We are not using
> JFFS2 on NAND flash devices. Our primary goal is to extend write
> verification to the NOR flash path because we have encountered data
> corruption incidents in production environment and currently lack a
> quick diagnostic tool to isolate the cause. While reviewing the
> code flow, we noticed that the NAND buffered write path also lacked
> verification, so we took the opportunity to extend it as well.
> 
> Although JFFS2 is in "Odd fixes" maintenance mode, there are still
> a significant number of devices in production that rely on JFFS2,

Okay, this makes more sense.

> and we are encountering data corruption issues on live nodes.
> Extending write verification to the NOR flash path would provide a
> diagnostic tool for fault isolation. We notice that WBUF_VERIFY has
> existed since 2007 (a6bc432e296d), so we want to extend the same
> diagnostic facility to cover the write paths it missed, so that it
> can serve ongoing product issue diagnosis. IMHO, this is a
> debugging/maintenance feature, not introducing new functionality.
> 
> We respect your judgment and will leave the final decision to you.

These days many patches are created by an LLM where people change software
for the sake of changing.
But if it solves a real problem you're facing in production things are different,
of course.

Please have a look at Sashiko review, maybe it's useful (maybe not...)
and resend with an updated cover letter.

Thanks,
//richard