From: jamesjj.liao@mediatek.com (James Liao)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 1/4] clk: dts: mediatek: add Mediatek MT8135 clock bindings
Date: Tue, 20 Jan 2015 10:10:40 +0800 [thread overview]
Message-ID: <1421719840.11981.4.camel@mtksdaap41> (raw)
In-Reply-To: <20150119153549.22722.67372@quantum>
On Mon, 2015-01-19 at 07:35 -0800, Mike Turquette wrote:
> Quoting James Liao (2015-01-06 19:25:20)
> > +Example: I2C controller node that consumes the clock generated by the clock
> > + controller (refer to the standard clock bindings for information about
> > + "clocks" and "clock-names" properties):
> > +
> > + i2c0: i2c at 1100d000 {
> > + compatible = "mediatek,mt8135-i2c", "mediatek,mt6589-i2c";
> > + reg = <0 0x1100d000 0 0x70>, <0 0x11000300 0 0x80>;
> > + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_LOW>;
> > + clock-div = <16>;
> > + clocks = <&pericfg PERI_I2C0_CK>, <&pericfg PERI_AP_DMA_CK>;
> > + clock-names = "main", "dma";
> > + };
>
> Hello,
>
> Patch looks good to me overall. One suggestion for the next version is
> that your example above include a node for the clock controller itself,
> followed by the i2c controller example above.
OK, I'll add pericfg in next patch.
Best regards,
James
WARNING: multiple messages have this Message-ID (diff)
From: James Liao <jamesjj.liao@mediatek.com>
To: Mike Turquette <mturquette@linaro.org>
Cc: Mark Rutland <mark.rutland@arm.com>,
Ashwin Chaugule <ashwin.chaugule@linaro.org>,
Vladimir Murzin <vladimir.murzin@arm.com>,
Russell King <linux@arm.linux.org.uk>,
Pawel Moll <pawel.moll@arm.com>,
srv_heupstream@mediatek.com,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-kernel@vger.kernel.org, henryc.chen@mediatek.com,
jamesjj.liao@mediatek.com, devicetree@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Sascha Hauer <kernel@pengutronix.de>,
Kumar Gala <galak@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
"Joe.C" <yingjoe.chen@mediatek.com>,
eddie.huang@mediatek.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3 1/4] clk: dts: mediatek: add Mediatek MT8135 clock bindings
Date: Tue, 20 Jan 2015 10:10:40 +0800 [thread overview]
Message-ID: <1421719840.11981.4.camel@mtksdaap41> (raw)
In-Reply-To: <20150119153549.22722.67372@quantum>
On Mon, 2015-01-19 at 07:35 -0800, Mike Turquette wrote:
> Quoting James Liao (2015-01-06 19:25:20)
> > +Example: I2C controller node that consumes the clock generated by the clock
> > + controller (refer to the standard clock bindings for information about
> > + "clocks" and "clock-names" properties):
> > +
> > + i2c0: i2c@1100d000 {
> > + compatible = "mediatek,mt8135-i2c", "mediatek,mt6589-i2c";
> > + reg = <0 0x1100d000 0 0x70>, <0 0x11000300 0 0x80>;
> > + interrupts = <GIC_SPI 44 IRQ_TYPE_LEVEL_LOW>;
> > + clock-div = <16>;
> > + clocks = <&pericfg PERI_I2C0_CK>, <&pericfg PERI_AP_DMA_CK>;
> > + clock-names = "main", "dma";
> > + };
>
> Hello,
>
> Patch looks good to me overall. One suggestion for the next version is
> that your example above include a node for the clock controller itself,
> followed by the i2c controller example above.
OK, I'll add pericfg in next patch.
Best regards,
James
next prev parent reply other threads:[~2015-01-20 2:10 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 3:25 [PATCH v3 0/4] clk: mediatek: Add common clock support for Mediatek MT8135 James Liao
2015-01-07 3:25 ` James Liao
2015-01-07 3:25 ` [PATCH v3 1/4] clk: dts: mediatek: add Mediatek MT8135 clock bindings James Liao
2015-01-07 3:25 ` James Liao
2015-01-19 15:35 ` Mike Turquette
2015-01-19 15:35 ` Mike Turquette
2015-01-20 2:10 ` James Liao [this message]
2015-01-20 2:10 ` James Liao
2015-01-07 3:25 ` [PATCH v3 2/4] clk: mediatek: Add initial common clock support for Mediatek SoCs James Liao
2015-01-07 3:25 ` James Liao
2015-01-07 17:22 ` Matthias Brugger
2015-01-07 17:22 ` Matthias Brugger
2015-01-08 2:55 ` James Liao
2015-01-08 2:55 ` James Liao
2015-01-19 16:28 ` Mike Turquette
2015-01-19 16:28 ` Mike Turquette
2015-01-20 12:39 ` Matthias Brugger
2015-01-20 12:39 ` Matthias Brugger
2015-01-20 12:39 ` Matthias Brugger
2015-01-21 7:49 ` James Liao
2015-01-21 7:49 ` James Liao
2015-01-07 3:25 ` [PATCH v3 3/4] clk: mediatek: Add basic clocks for Mediatek MT8135 James Liao
2015-01-07 3:25 ` James Liao
2015-01-07 17:31 ` Matthias Brugger
2015-01-07 17:31 ` Matthias Brugger
2015-01-08 2:59 ` James Liao
2015-01-08 2:59 ` James Liao
2015-01-07 3:25 ` [PATCH v3 4/4] dts: mediatek: Enable clock support " James Liao
2015-01-07 3:25 ` James Liao
2015-01-07 16:25 ` Matthias Brugger
2015-01-07 16:25 ` Matthias Brugger
2015-01-07 16:25 ` Matthias Brugger
2015-01-08 2:34 ` James Liao
2015-01-08 2:34 ` James Liao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421719840.11981.4.camel@mtksdaap41 \
--to=jamesjj.liao@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.