From: Ian Campbell <Ian.Campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Stefano Stabellini <stefano.stabellini@citrix.com>,
Tim Deegan <tim@xen.org>, Keir Fraser <keir@xen.org>,
Jan Beulich <JBeulich@suse.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 4/4] xen/many: Drop redundant MAX_VIRT_CPUS bounds checks
Date: Tue, 20 Jan 2015 11:06:15 +0000 [thread overview]
Message-ID: <1421751975.10440.215.camel@citrix.com> (raw)
In-Reply-To: <1421666496-10676-5-git-send-email-andrew.cooper3@citrix.com>
On Mon, 2015-01-19 at 11:21 +0000, Andrew Cooper wrote:
> In all 4 cases, visible in the context are bounds check against d->max_vcpus.
> Domain building will ensure that d->max_vcpus never exceeds an appropriate
> bound. In the x86 case, different types of domains have different maxima for
> vcpus, making the checks wrong as opposed to simply redundant.
>
> For vpsci in ARM, 'vcpuid' is an unsigned type so could never be less than 0.
>
> For the common changes to do_{,compat}_vcpu_op(), these changes do result in a
> guest visible change, but only in so far as certain invalid vcpu ids will now
> fail with -ENOENT rather than -EINVAL.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Keir Fraser <keir@xen.org>
> CC: Jan Beulich <JBeulich@suse.com>
> CC: Ian Campbell <ian.campbell@citrix.com>
> CC: Stefano Stabellini <stefano.stabellini@citrix.com>
> CC: Tim Deegan <tim@xen.org>
For ARM: Acked-by: Ian Campbell <ian.campbell@citrix.com>
prev parent reply other threads:[~2015-01-20 11:06 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-19 11:21 [PATCH 0/4] Reduce the use of MAX_VIRT_CPUS in tree Andrew Cooper
2015-01-19 11:21 ` [PATCH 1/4] xen/domain: Introduce domain_max_vcpus() helper and implement per arch Andrew Cooper
2015-01-19 12:16 ` Simon Rowe
2015-01-19 12:52 ` Andrew Cooper
2015-01-19 12:57 ` Ian Campbell
2015-01-19 12:59 ` Andrew Cooper
2015-01-20 10:27 ` Jan Beulich
2015-01-20 14:06 ` [PATCH v2 " Andrew Cooper
2015-01-20 11:05 ` [PATCH " Ian Campbell
2015-01-19 11:21 ` [PATCH 2/4] xen/evtchn: Reduce the size of the poll_mask where possible Andrew Cooper
2015-01-20 10:28 ` Jan Beulich
2015-01-19 11:21 ` [PATCH 3/4] sched/arinc653: Remove MAX_VIRT_CPUS bounds check Andrew Cooper
2015-01-20 10:34 ` Jan Beulich
2015-01-20 14:20 ` Robert VanVossen
2015-01-19 11:21 ` [PATCH 4/4] xen/many: Drop redundant MAX_VIRT_CPUS bounds checks Andrew Cooper
2015-01-20 10:36 ` Jan Beulich
2015-01-20 11:06 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421751975.10440.215.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=keir@xen.org \
--cc=stefano.stabellini@citrix.com \
--cc=tim@xen.org \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.