From: Joe Perches <joe@perches.com>
To: Mohamed Lotfy Hammad <mohamed.lotfy.hammad@gmail.com>
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org,
lidza.louina@gmail.com, markh@compro.net,
gregkh@linuxfoundation.org,
driverdev-devel@linuxdriverproject.org
Subject: Re: [PATCH] staging: dgnc: warning line over 80 characters
Date: Tue, 20 Jan 2015 10:19:10 -0800 [thread overview]
Message-ID: <1421777950.2724.7.camel@perches.com> (raw)
In-Reply-To: <20150120140827.GA8352@lotfy1893-Ubuntu>
On Tue, 2015-01-20 at 16:08 +0200, Mohamed Lotfy Hammad wrote:
> This patch fixes the following checkpatch.pl warning:
> fix line over 80 characters
[]
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
[]
> @@ -54,14 +54,14 @@ MODULE_SUPPORTED_DEVICE("dgnc");
> * protos for this file
> *
> */
> -static int dgnc_start(void);
> -static int dgnc_finalize_board_init(struct dgnc_board *brd);
> -static void dgnc_init_globals(void);
> -static int dgnc_found_board(struct pci_dev *pdev, int id);
> -static void dgnc_cleanup_board(struct dgnc_board *brd);
> -static void dgnc_poll_handler(ulong dummy);
> -static int dgnc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
> -static void dgnc_do_remap(struct dgnc_board *brd);
> +static int dgnc_start(void);
> +static int dgnc_finalize_board_init(struct dgnc_board *brd);
> +static void dgnc_init_globals(void);
> +static int dgnc_found_board(struct pci_dev *pdev, int id);
> +static void dgnc_cleanup_board(struct dgnc_board *brd);
> +static void dgnc_poll_handler(ulong dummy);
> +static int dgnc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
> +static void dgnc_do_remap(struct dgnc_board *brd);
Better still would be to eventually rearrange the code
to avoid the need for static forward declarations.
prev parent reply other threads:[~2015-01-20 18:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-20 14:08 [PATCH] staging: dgnc: warning line over 80 characters Mohamed Lotfy Hammad
2015-01-20 18:19 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421777950.2724.7.camel@perches.com \
--to=joe@perches.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markh@compro.net \
--cc=mohamed.lotfy.hammad@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.