* [PATCH] staging: dgnc: warning line over 80 characters
@ 2015-01-20 14:08 Mohamed Lotfy Hammad
2015-01-20 18:19 ` Joe Perches
0 siblings, 1 reply; 2+ messages in thread
From: Mohamed Lotfy Hammad @ 2015-01-20 14:08 UTC (permalink / raw)
To: devel; +Cc: linux-kernel, lidza.louina, markh, gregkh, driverdev-devel
This patch fixes the following checkpatch.pl warning:
fix line over 80 characters
Signed-off-by: Mohamed Lotfy Hammad <mohamed.lotfy.hammad@gmail.com>
---
drivers/staging/dgnc/dgnc_driver.c | 16 ++++++++--------
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
index ba98ff3..050061e 100644
--- a/drivers/staging/dgnc/dgnc_driver.c
+++ b/drivers/staging/dgnc/dgnc_driver.c
@@ -54,14 +54,14 @@ MODULE_SUPPORTED_DEVICE("dgnc");
* protos for this file
*
*/
-static int dgnc_start(void);
-static int dgnc_finalize_board_init(struct dgnc_board *brd);
-static void dgnc_init_globals(void);
-static int dgnc_found_board(struct pci_dev *pdev, int id);
-static void dgnc_cleanup_board(struct dgnc_board *brd);
-static void dgnc_poll_handler(ulong dummy);
-static int dgnc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
-static void dgnc_do_remap(struct dgnc_board *brd);
+static int dgnc_start(void);
+static int dgnc_finalize_board_init(struct dgnc_board *brd);
+static void dgnc_init_globals(void);
+static int dgnc_found_board(struct pci_dev *pdev, int id);
+static void dgnc_cleanup_board(struct dgnc_board *brd);
+static void dgnc_poll_handler(ulong dummy);
+static int dgnc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
+static void dgnc_do_remap(struct dgnc_board *brd);
/*
* File operations permitted on Control/Management major.
--
2.1.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] staging: dgnc: warning line over 80 characters
2015-01-20 14:08 [PATCH] staging: dgnc: warning line over 80 characters Mohamed Lotfy Hammad
@ 2015-01-20 18:19 ` Joe Perches
0 siblings, 0 replies; 2+ messages in thread
From: Joe Perches @ 2015-01-20 18:19 UTC (permalink / raw)
To: Mohamed Lotfy Hammad
Cc: devel, linux-kernel, lidza.louina, markh, gregkh, driverdev-devel
On Tue, 2015-01-20 at 16:08 +0200, Mohamed Lotfy Hammad wrote:
> This patch fixes the following checkpatch.pl warning:
> fix line over 80 characters
[]
> diff --git a/drivers/staging/dgnc/dgnc_driver.c b/drivers/staging/dgnc/dgnc_driver.c
[]
> @@ -54,14 +54,14 @@ MODULE_SUPPORTED_DEVICE("dgnc");
> * protos for this file
> *
> */
> -static int dgnc_start(void);
> -static int dgnc_finalize_board_init(struct dgnc_board *brd);
> -static void dgnc_init_globals(void);
> -static int dgnc_found_board(struct pci_dev *pdev, int id);
> -static void dgnc_cleanup_board(struct dgnc_board *brd);
> -static void dgnc_poll_handler(ulong dummy);
> -static int dgnc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
> -static void dgnc_do_remap(struct dgnc_board *brd);
> +static int dgnc_start(void);
> +static int dgnc_finalize_board_init(struct dgnc_board *brd);
> +static void dgnc_init_globals(void);
> +static int dgnc_found_board(struct pci_dev *pdev, int id);
> +static void dgnc_cleanup_board(struct dgnc_board *brd);
> +static void dgnc_poll_handler(ulong dummy);
> +static int dgnc_init_one(struct pci_dev *pdev, const struct pci_device_id *ent);
> +static void dgnc_do_remap(struct dgnc_board *brd);
Better still would be to eventually rearrange the code
to avoid the need for static forward declarations.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-20 18:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-20 14:08 [PATCH] staging: dgnc: warning line over 80 characters Mohamed Lotfy Hammad
2015-01-20 18:19 ` Joe Perches
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.