* [PATCH] server/process: Fix select call
@ 2015-01-21 17:43 Richard Purdie
0 siblings, 0 replies; only message in thread
From: Richard Purdie @ 2015-01-21 17:43 UTC (permalink / raw)
To: bitbake-devel
There was a report that bitbake -e | less would use 100% cpu when it shouldn't
really. The issue appears to be a bogus file descriptor in the select call. We
shouldn't be blocking if there is event data pending to a *reader* from server
context.
[YOCTO #7138]
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
diff --git a/bitbake/lib/bb/server/process.py b/bitbake/lib/bb/server/process.py
index d362f8d..7671b26 100644
--- a/bitbake/lib/bb/server/process.py
+++ b/bitbake/lib/bb/server/process.py
@@ -115,7 +115,7 @@ class ProcessServer(Process, BaseImplServer):
self.quitout.recv()
self.quit = True
- self.idle_commands(.1, [self.event_queue._reader, self.command_channel, self.quitout])
+ self.idle_commands(.1, [self.command_channel, self.quitout])
except Exception:
logger.exception('Running command %s', command)
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2015-01-21 17:44 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-21 17:43 [PATCH] server/process: Fix select call Richard Purdie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.