From: Joe Perches <joe@perches.com>
To: micky_ching@realsil.com.cn
Cc: sameo@linux.intel.com, lee.jones@linaro.org,
devel@linuxdriverproject.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, rogerable@realtek.com,
wei_wang@realsil.com.cn
Subject: Re: [RESEND PATCH v2 4/9] mfd: rtsx: update driving settings
Date: Wed, 21 Jan 2015 23:40:52 -0800 [thread overview]
Message-ID: <1421912452.18480.4.camel@perches.com> (raw)
In-Reply-To: <382f3e7b2285ffd06931b43d015cc8a6967a19eb.1421911636.git.micky_ching@realsil.com.cn>
On Thu, 2015-01-22 at 15:30 +0800, micky_ching@realsil.com.cn wrote:
> update card drive settings, This setting can be used for rts5249
> rts524A and rts525A.
[]
> diff --git a/drivers/mfd/rts5249.c b/drivers/mfd/rts5249.c
> @@ -36,16 +36,16 @@ static u8 rts5249_get_ic_version(struct rtsx_pcr *pcr)
> static void rts5249_fill_driving(struct rtsx_pcr *pcr, u8 voltage)
> {
> u8 driving_3v3[4][3] = {
It'd be nice to make these arrays static const
> - {0x11, 0x11, 0x11},
> + {0x11, 0x11, 0x18},
> {0x55, 0x55, 0x5C},
> - {0x99, 0x99, 0x92},
> - {0x99, 0x99, 0x92},
> + {0xFF, 0xFF, 0xFF},
> + {0x96, 0x96, 0x96},
> };
> u8 driving_1v8[4][3] = {
> + {0xC4, 0xC4, 0xC4},
> {0x3C, 0x3C, 0x3C},
> - {0xB3, 0xB3, 0xB3},
> {0xFE, 0xFE, 0xFE},
> - {0xC4, 0xC4, 0xC4},
> + {0xB3, 0xB3, 0xB3},
> };
> u8 (*driving)[3], drive_sel;
next prev parent reply other threads:[~2015-01-22 7:41 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 7:30 [RESEND PATCH v2 0/9] mfd: rtsx: add support for new rts524A and rts525A micky_ching
2015-01-22 7:30 ` [RESEND PATCH v2 1/9] mfd: rtsx: replace TAB by SPC after #define micky_ching
2015-01-22 7:30 ` [RESEND PATCH v2 2/9] mfd: rtsx: place register address and values togather micky_ching
2015-01-22 7:30 ` [RESEND PATCH v2 3/9] mfd: rtsx: update PETXCFG address micky_ching
2015-01-22 7:30 ` [RESEND PATCH v2 4/9] mfd: rtsx: update driving settings micky_ching
2015-01-22 7:40 ` Joe Perches [this message]
2015-01-22 7:30 ` [RESEND PATCH v2 5/9] mfd: rtsx: update phy register micky_ching
2015-02-16 14:07 ` Lee Jones
2015-01-22 7:30 ` [RESEND PATCH v2 6/9] mfd: rtsx: remove LCTLR defination micky_ching
2015-02-16 14:31 ` Lee Jones
2015-01-22 7:30 ` [RESEND PATCH v2 7/9] mfd: rtsx: add support for rts524A micky_ching
2015-02-02 1:07 ` 敬锐
2015-02-02 8:52 ` Lee Jones
2015-02-16 14:28 ` Lee Jones
2015-02-25 3:27 ` 敬锐
2015-02-25 7:21 ` Lee Jones
2015-01-22 7:30 ` [RESEND PATCH v2 8/9] mfd: rtsx: add support for rts525A micky_ching
2015-02-16 14:37 ` Lee Jones
2015-01-22 7:30 ` [RESEND PATCH v2 9/9] mfd: rtsx: using pcr_dbg replace dev_dbg micky_ching
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1421912452.18480.4.camel@perches.com \
--to=joe@perches.com \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=micky_ching@realsil.com.cn \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.