From: Jarkko Sakkinen <jarkko.sakkinen-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Jason Gunthorpe
<jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Cc: Scot Doyle <lkml14-enLWO88E2pdl57MIdRCFDg@public.gmane.org>,
peterhuewe-Mmb7MZpHnFY@public.gmane.org,
ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org,
christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
jason.gunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org,
linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
trousers-tech-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: [tpmdd-devel] [PATCH] tpm: fix suspend/resume paths for TPM 2.0
Date: Tue, 27 Jan 2015 19:23:37 +0200 [thread overview]
Message-ID: <1422379417.2912.4.camel@linux.intel.com> (raw)
In-Reply-To: <20150127170308.GA10140-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On Tue, 2015-01-27 at 10:03 -0700, Jason Gunthorpe wrote:
> On Tue, Jan 27, 2015 at 06:57:22PM +0200, Jarkko Sakkinen wrote:
> > > > + /* TPM 1.2 requires self-test on resume. */
> > > > + if (!(chip->flags & TPM_CHIP_FLAG_TPM2)) {
> > > > + ret = tpm_do_selftest(chip);
> > > > + if (ret < 0)
> > > > + return ret;
> > >
> > > Just to note, the return value from tpm_do_selftest() on TPM 1.2 chips was
> > > previously ignored. Mine does return 0.
> >
> > Right. I can update the patch to ignore return value if the majority
> > wants that.
>
> What happens to the system when pnp_driver.resume() returns failure?
>
> Should tpm ever report failure on resume to the rest of the kernel?
>
> Shouldn't this stuff be in tpm_pm_resume common code anyhow?
I think it should but not in the scope of this bug fix IMHO.
> Jason
/Jarkko
WARNING: multiple messages have this Message-ID (diff)
From: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
To: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
Cc: Scot Doyle <lkml14@scotdoyle.com>,
peterhuewe@gmx.de, ashley@ashleylai.com,
christophe.ricard@gmail.com,
jason.gunthorpe@obsidianresearch.com, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org, tpmdd-devel@lists.sourceforge.net,
trousers-tech@lists.sourceforge.net
Subject: Re: [tpmdd-devel] [PATCH] tpm: fix suspend/resume paths for TPM 2.0
Date: Tue, 27 Jan 2015 19:23:37 +0200 [thread overview]
Message-ID: <1422379417.2912.4.camel@linux.intel.com> (raw)
In-Reply-To: <20150127170308.GA10140@obsidianresearch.com>
On Tue, 2015-01-27 at 10:03 -0700, Jason Gunthorpe wrote:
> On Tue, Jan 27, 2015 at 06:57:22PM +0200, Jarkko Sakkinen wrote:
> > > > + /* TPM 1.2 requires self-test on resume. */
> > > > + if (!(chip->flags & TPM_CHIP_FLAG_TPM2)) {
> > > > + ret = tpm_do_selftest(chip);
> > > > + if (ret < 0)
> > > > + return ret;
> > >
> > > Just to note, the return value from tpm_do_selftest() on TPM 1.2 chips was
> > > previously ignored. Mine does return 0.
> >
> > Right. I can update the patch to ignore return value if the majority
> > wants that.
>
> What happens to the system when pnp_driver.resume() returns failure?
>
> Should tpm ever report failure on resume to the rest of the kernel?
>
> Shouldn't this stuff be in tpm_pm_resume common code anyhow?
I think it should but not in the scope of this bug fix IMHO.
> Jason
/Jarkko
next prev parent reply other threads:[~2015-01-27 17:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 11:02 [PATCH] tpm: fix suspend/resume paths for TPM 2.0 Jarkko Sakkinen
2015-01-27 11:02 ` Jarkko Sakkinen
2015-01-27 16:52 ` [tpmdd-devel] " Scot Doyle
[not found] ` <alpine.DEB.2.11.1501271620520.1725-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2015-01-27 16:57 ` Jarkko Sakkinen
2015-01-27 16:57 ` Jarkko Sakkinen
[not found] ` <1422377842.2912.1.camel-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
2015-01-27 17:03 ` Jason Gunthorpe
2015-01-27 17:03 ` Jason Gunthorpe
[not found] ` <20150127170308.GA10140-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
2015-01-27 17:23 ` Jarkko Sakkinen [this message]
2015-01-27 17:23 ` Jarkko Sakkinen
2015-01-27 17:33 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422379417.2912.4.camel@linux.intel.com \
--to=jarkko.sakkinen-vuqaysv1563yd54fqh9/ca@public.gmane.org \
--cc=ashley-fm2HMyfA2y6tG0bUXCXiUA@public.gmane.org \
--cc=christophe.ricard-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=jason.gunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org \
--cc=linux-api-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=lkml14-enLWO88E2pdl57MIdRCFDg@public.gmane.org \
--cc=peterhuewe-Mmb7MZpHnFY@public.gmane.org \
--cc=tpmdd-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=trousers-tech-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.