From: Ian Campbell <Ian.Campbell@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <Ian.Jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools/libxl: Correct static pattern rule for pkgconfig files
Date: Wed, 28 Jan 2015 10:23:15 +0000 [thread overview]
Message-ID: <1422440595.16180.53.camel@citrix.com> (raw)
In-Reply-To: <1422390842-4949-1-git-send-email-andrew.cooper3@citrix.com>
On Tue, 2015-01-27 at 20:34 +0000, Andrew Cooper wrote:
> Attempting to build libxl causes Make to emit the following warnings
>
> andrewcoop@andrewcoop:xen.git$ make -C tools/libxl all
> ...
> Makefile:253: target `xenlight.pc' doesn't match the target pattern
> Makefile:253: target `xlutil.pc' doesn't match the target pattern
> ...
>
> because the static pattern rule is malformed. 'Makefile' as the only
> prereq-pattern does not contain a pattern.
>
> The rule ends up working because of the use of $@.in where $< should have been
> used, but lacked any dependency between a $FOO.pc and its .in source file.
>
> Signed-off-by: Andrew Cooper <andrew.cooper3@citrix.com>
> CC: Ian Campbell <Ian.Campbell@citrix.com>
> CC: Ian Jackson <Ian.Jackson@eu.citrix.com>
> CC: Wei Liu <wei.liu2@citrix.com>
Acked + applied, thanks.
prev parent reply other threads:[~2015-01-28 10:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-27 20:34 [PATCH] tools/libxl: Correct static pattern rule for pkgconfig files Andrew Cooper
2015-01-28 10:23 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422440595.16180.53.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.