From: Ian Campbell <Ian.Campbell@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: xen-devel@lists.xenproject.org
Subject: Re: [OSSTEST PATCH] ts-hosts-allocate-Executive: Fix an undefined warning
Date: Thu, 29 Jan 2015 12:53:10 +0000 [thread overview]
Message-ID: <1422535990.3943.3.camel@citrix.com> (raw)
In-Reply-To: <1422535788-7466-1-git-send-email-ian.jackson@eu.citrix.com>
On Thu, 2015-01-29 at 12:49 +0000, Ian Jackson wrote:
> $esrow is autovivified as { } by
> $candrow->{EquivMostRecentStatus} = $esrow->{status}
> so use %$esrow which in scalar context is true iff the
> hash is nonempty.
>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
I'll either push this ontop of the existing queue if that needs
restarting for some reason, or along with the libvirt stuff which we
discussed would go in next (along with your ap-push linux cleanups)
> ---
> ts-hosts-allocate-Executive | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ts-hosts-allocate-Executive b/ts-hosts-allocate-Executive
> index 4d5e3bb..7a9411d 100755
> --- a/ts-hosts-allocate-Executive
> +++ b/ts-hosts-allocate-Executive
> @@ -372,7 +372,7 @@ END
> $candrow->{EquivMostRecentStatus} = $esrow->{status};
> print DEBUG "$dbg EQUIV-MOST-RECENT ";
> print DEBUG ("$esrow->{flight}.$esrow->{job}".
> - " $esrow->{val} $esrow->{status}") if $esrow;
> + " $esrow->{val} $esrow->{status}") if %$esrow;
> print DEBUG ".\n";
> }
>
prev parent reply other threads:[~2015-01-29 12:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-29 12:49 [OSSTEST PATCH] ts-hosts-allocate-Executive: Fix an undefined warning Ian Jackson
2015-01-29 12:53 ` Ian Campbell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1422535990.3943.3.camel@citrix.com \
--to=ian.campbell@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.