* [PATCH] xen: random: Add missing include xen/cache.h
@ 2015-01-29 13:32 Julien Grall
2015-01-29 13:37 ` Ian Campbell
0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2015-01-29 13:32 UTC (permalink / raw)
To: xen-devel
Cc: Keir Fraser, ian.campbell, tim, Julien Grall, Ian Jackson,
stefano.stabellini, Jan Beulich, Chao Peng
The commit f6c9698 " x86: allow reading MSR_IA32_TSC with XENPF_resource_op"
introduced a built regression on ARM platform.
random.c:8:28: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘boot_random’
unsigned int __read_mostly boot_random;
^
The define __read_mostly is defined in asm/cache.h which is included by
other headers on x86 but not on ARM. Include xen/cache.h to fix the
build.
Signed-off-by: Julien Grall <julien.grall@linaro.org>
Cc: Chao Peng <chao.p.peng@linux.intel.com>
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Jan Beulich <jbeulich@suse.com>
Cc: Keir Fraser <keir@xen.org>
---
xen/common/random.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xen/common/random.c b/xen/common/random.c
index cb9187c..fb805b0 100644
--- a/xen/common/random.c
+++ b/xen/common/random.c
@@ -1,3 +1,4 @@
+#include <xen/cache.h>
#include <xen/init.h>
#include <xen/percpu.h>
#include <xen/random.h>
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xen: random: Add missing include xen/cache.h
2015-01-29 13:32 [PATCH] xen: random: Add missing include xen/cache.h Julien Grall
@ 2015-01-29 13:37 ` Ian Campbell
0 siblings, 0 replies; 2+ messages in thread
From: Ian Campbell @ 2015-01-29 13:37 UTC (permalink / raw)
To: Julien Grall
Cc: Keir Fraser, Ian Jackson, tim, stefano.stabellini, Jan Beulich,
Chao Peng, xen-devel
On Thu, 2015-01-29 at 13:32 +0000, Julien Grall wrote:
> The commit f6c9698 " x86: allow reading MSR_IA32_TSC with XENPF_resource_op"
> introduced a built regression on ARM platform.
>
> random.c:8:28: error: expected ‘=’, ‘,’, ‘;’, ‘asm’ or ‘__attribute__’ before ‘boot_random’
> unsigned int __read_mostly boot_random;
> ^
> The define __read_mostly is defined in asm/cache.h which is included by
> other headers on x86 but not on ARM. Include xen/cache.h to fix the
> build.
>
> Signed-off-by: Julien Grall <julien.grall@linaro.org>
> Cc: Chao Peng <chao.p.peng@linux.intel.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Jan Beulich <jbeulich@suse.com>
> Cc: Keir Fraser <keir@xen.org>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
> ---
> xen/common/random.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/xen/common/random.c b/xen/common/random.c
> index cb9187c..fb805b0 100644
> --- a/xen/common/random.c
> +++ b/xen/common/random.c
> @@ -1,3 +1,4 @@
> +#include <xen/cache.h>
> #include <xen/init.h>
> #include <xen/percpu.h>
> #include <xen/random.h>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
http://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-29 13:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-29 13:32 [PATCH] xen: random: Add missing include xen/cache.h Julien Grall
2015-01-29 13:37 ` Ian Campbell
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.