[PATCH] data_smart: Don't use mutable objects as default args

[PATCH] data_smart: Don't use mutable objects as default args

[Richard Purdie]

These only have one instance created which means your subsequent datastores
can contain echos of previous ones. Obviously this is not the behaviour
we want/expect. It doesn't affect bitbake too badly as we only have one
datastore, it does massively potentially break our selftests though.

Thanks to Tim Amsell for pointing out the now obvious problem!

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/bitbake/lib/bb/data_smart.py b/bitbake/lib/bb/data_smart.py
index 68d273b..b1ea33f 100644
--- a/bitbake/lib/bb/data_smart.py
+++ b/bitbake/lib/bb/data_smart.py
@@ -296,9 +296,14 @@ class VariableHistory(object):
                 self.variables[var] = []
 
 class DataSmart(MutableMapping):
-    def __init__(self, special = COWDictBase.copy(), seen = COWDictBase.copy() ):
+    def __init__(self, special = None, seen = None ):
         self.dict = {}
 
+        if special is None:
+            special = COWDictBase.copy()
+        if seen is None:
+            seen = COWDictBase.copy()
+
         self.inchistory = IncludeHistory()
         self.varhistory = VariableHistory(self)
         self._tracking = False

Re: [PATCH] data_smart: Don't use mutable objects as default args

[Christopher Larson]

[-- Attachment #1: Type: text/plain, Size: 770 bytes --]

On Thu, Jan 29, 2015 at 7:35 AM, Richard Purdie <
richard.purdie@linuxfoundation.org> wrote:

> These only have one instance created which means your subsequent datastores
> can contain echos of previous ones. Obviously this is not the behaviour
> we want/expect. It doesn't affect bitbake too badly as we only have one
> datastore, it does massively potentially break our selftests though.
>
> Thanks to Tim Amsell for pointing out the now obvious problem!
>
> Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
>

Wow, obvious indeed, once you look at it. Nicely spotted, Tim.
-- 
Christopher Larson
clarson at kergoth dot com
Founder - BitBake, OpenEmbedded, OpenZaurus
Maintainer - Tslib
Senior Software Engineer, Mentor Graphics

[-- Attachment #2: Type: text/html, Size: 1219 bytes --]