Re: [OSSTEST PATCH v4 1/9] overlay: update overlay/etc/grub.d/20_linux_xen

[Ian Campbell <Ian.Campbell@citrix.com>]

On Wed, 2014-12-10 at 22:21 +0000, Wei Liu wrote:
> This file was originally created to work around Debian bug #633127
> ("/etc/grub/20_linux does not recognise some old Xen kernels").
> 
> According to Debian bug tracker [0], #633127 bug is fixed in Wheezy. As
> we're now using Wheezy in OSSTest we can safely remove the old overlay
> file if there's no further bugs discovered.
> 
> However we have another bug #690538 ("grub-common: Please make submenu
> creation optional or at least allow users to disable it easily") that
> would break OSSTest.  We're now using Wheezy in production. There's no
> way to disable submenu in Wheezy. And submenu breaks OSSTest's grub menu
> parser.
> 
> So update this overlay file to Wheezy's version and take care of Debian
> bug #690538 by removing the lines to generate submenu.
> 
> Also work around GRUB bug #43420 ("20_linux_xen doesn't support Xen XSM
> policy file") by applying a small patch proposed in [2].
> 
> Add a note to reference #633127 and #690538 above grub2 setup function.
> 
> 0: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=633127
> 1: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=690538
> 2: https://savannah.gnu.org/bugs/?43420
> 
> Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>

Acked-by: Ian Campbell <ian.campbell@citrix.com>